Code review request: 8011124: Make KerberosTime immutable

2013-04-03 Thread Weijun Wang
http://cr.openjdk.java.net/~weijun/8011124/webrev.00/ KerberosTime is a very basic data type and it is nice to be immutable. One test is updated. No new regression test for this code change. Considered noreg-cleanup. Thanks Max

hg: jdk8/tl/jdk: 8011234: Performance regression with ftp protocol when uploading in image mode

2013-04-03 Thread alan . bateman
Changeset: c534937f6e94 Author:alanb Date: 2013-04-03 13:15 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c534937f6e94 8011234: Performance regression with ftp protocol when uploading in image mode Reviewed-by: chegar ! src/share/classes/sun/net/ftp/impl/FtpClient.java

hg: jdk8/tl/jdk: 8011373: Property java.runtime.profile should be removed (left-over code)

2013-04-03 Thread alan . bateman
Changeset: eb8f7bc6f964 Author:alanb Date: 2013-04-03 13:41 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/eb8f7bc6f964 8011373: Property java.runtime.profile should be removed (left-over code) Reviewed-by: lancea, dholmes ! src/share/classes/sun/misc/Version.java.template

hg: jdk8/tl/jdk: 7091601: Arabic Locale: can not set type of digit in application level

2013-04-03 Thread naoto . sato
Changeset: 9a6ef3391f32 Author:naoto Date: 2013-04-03 10:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9a6ef3391f32 7091601: Arabic Locale: can not set type of digit in application level Reviewed-by: okutsu ! src/macosx/native/sun/util/locale/provider/HostLocaleProviderA

hg: jdk8/tl/langtools: 8011052: Add DEFAULT to javax.lang.model.Modifier

2013-04-03 Thread joe . darcy
Changeset: 0d47e6131490 Author:darcy Date: 2013-04-03 12:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0d47e6131490 8011052: Add DEFAULT to javax.lang.model.Modifier Reviewed-by: abuckley, jjg ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/clas

Re: code review request: 7171982 Cipher getParameters() throws RuntimeException: Cannot find SunJCE provider

2013-04-03 Thread Anthony Scarpino
Update webrev after a talk about getInstance(), along with comment embedded below. http://cr.openjdk.java.net/~mullan/webrevs/ascarpin/7171982/webrev.00/ On 03/28/2013 06:00 PM, Anthony Scarpino wrote: On 03/28/2013 02:34 PM, Brad Wetmore wrote: (Vinnie, what do you think about the SunJCE it

Re: simple code review request: 8001596

2013-04-03 Thread Anthony Scarpino
Updated code review with regression test. http://cr.openjdk.java.net/~mullan/webrevs/ascarpin/8001596/webrev.02/ Tony

Re: simple code review request: 8001596

2013-04-03 Thread Brad Wetmore
Looks good. Be sure to check in the closed version when you get your changes finished. Also, check to see if anyone else will be checking in signed jar files. I should have a changeset coming within the next week or so. Thanks, Brad On 4/3/2013 4:31 PM, Anthony Scarpino wrote: Updated

Re: Code Review Request for 7155720: PKCS11 minor issues in native code

2013-04-03 Thread Weijun Wang
Looks fine. Thanks Max On 3/30/13 8:32 AM, Valerie (Yu-Ching) Peng wrote: Trivial fix - just add null check and OOM error handling for the 2 malloc calls inside src/solaris/native/sun/security/pkcs11/wrapper/p11_md.c. Please find webrev against JDK8 at: http://cr.openjdk.java.net/~valeriep/7

hg: jdk8/tl: 8011350: hgforest.sh uses non-POSIX sh features that may fail with some shells

2013-04-03 Thread mike . duigou
Changeset: 575f2ca947ab Author:mduigou Date: 2013-04-03 16:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/575f2ca947ab 8011350: hgforest.sh uses non-POSIX sh features that may fail with some shells Reviewed-by: tbell, katleman, dholmes ! common/bin/hgforest.sh