hg: jdk8/tl/jdk: 8015978: Incorrect transformation of XPath expression "string(-0)"

2013-06-14 Thread sean . coffey
Changeset: 45a3584bfacf Author:coffeys Date: 2013-06-14 15:14 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/45a3584bfacf 8015978: Incorrect transformation of XPath expression "string(-0)" Reviewed-by: darcy, joehw Contributed-by: [email protected] + test/javax/xml/j

hg: jdk8/tl/jaxp: 8015978: Incorrect transformation of XPath expression "string(-0)"

2013-06-14 Thread sean . coffey
Changeset: 659828443145 Author:coffeys Date: 2013-06-14 15:14 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/659828443145 8015978: Incorrect transformation of XPath expression "string(-0)" Reviewed-by: darcy, joehw Contributed-by: [email protected] ! src/com/sun/org

hg: jdk8/tl/jdk: 8014307: Memory leak ... security/jgss/wrapper/GSSLibStub.c

2013-06-14 Thread sean . mullan
Changeset: f695f447f6b7 Author:jzavgren Date: 2013-06-14 09:13 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f695f447f6b7 8014307: Memory leak ... security/jgss/wrapper/GSSLibStub.c Summary: I modified the native procedure: Java_sun_security_jgss_wrapper_GSSLibStub_initCont

hg: jdk8/tl/langtools: 8016569: javac, add new flag for polymorphic method signatures

2013-06-14 Thread vicente . romero
Changeset: 6b48ebae2569 Author:vromero Date: 2013-06-14 16:25 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6b48ebae2569 8016569: javac, add new flag for polymorphic method signatures Reviewed-by: jjg Contributed-by: [email protected] ! src/share/classes/

javax.security.auth.Destroyable

2013-06-14 Thread Michael StJohns
Generic questions for possible future work: As a general guideline, would it make sense to add javax.security.auth.Destroyable to the set of interfaces for SecretKey and PrivateKey implementation objects where possible? Should the methods that use secret and private keys check to see if those k

Re: javax.security.auth.Destroyable

2013-06-14 Thread Matthew Hall
I asked about this once before. I didn't get very far because Java doesn't try to be compliant with FIPS or any of the other standards relating to key security. In addition with the garbage collector relocating things it is difficult to ensure you've really emptied these objects out in the way y

hg: jdk8/tl/langtools: 8008023: Get rid of utf8 chars in two tests

2013-06-14 Thread vicente . romero
Changeset: 1936a884b290 Author:vromero Date: 2013-06-14 18:01 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1936a884b290 8008023: Get rid of utf8 chars in two tests Reviewed-by: jjg ! test/tools/javac/api/6437999/Utf8.java ! test/tools/javac/api/T6306137.java

Re: javax.security.auth.Destroyable

2013-06-14 Thread Vincent Ryan
Thanks Mike. Both those classes were extended, as you suggest, for JDK 8: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/8ee6d45348ba A separate effort is also underway to enhance the classes that implement SecretKey and PrivateKey. Applications may first check whether a key class is an instance

[8] code review request for 7165807: Non optimized initialization of NSS crypto library leads to scalability issues

2013-06-14 Thread Vincent Ryan
Please review the following fix: http://cr.openjdk.java.net/~vinnie/7165807/webrev.00/ http://bugs.sun.com/view_bug.do?bug_id=7165807 NSS may be initialized to favour performance or to favour memory footprint. This fix introduces a new configuration flag to allow Java applications to choose. By

Re: javax.security.auth.Destroyable

2013-06-14 Thread Michael StJohns
That's what I get for pawing around in the JDK7 code instead of the JDK8 code... I'm surprised this is a sub interface to private key etc rather than just having this added to the sun implementations.Doing it this way isn't backwards compatible and is going to blow up a number of other pro

Re: javax.security.auth.Destroyable

2013-06-14 Thread Vincent Ryan
On 14 Jun 2013, at 18:40, Michael StJohns wrote: > That's what I get for pawing around in the JDK7 code instead of the JDK8 > code... > > I'm surprised this is a sub interface to private key etc rather than just > having this added to the sun implementations.Doing it this way isn't > back

Re: [8] code review request for 7165807: Non optimized initialization of NSS crypto library leads to scalability issues

2013-06-14 Thread Matthew Hall
On Fri, Jun 14, 2013 at 06:38:16PM +0100, Vincent Ryan wrote: > NSS may be initialized to favour performance or to favour memory footprint. > This fix introduces a new configuration flag to allow Java applications to > choose. By default, NSS will be initialized for performance. The original Sun

Re: RFR JDK-8014307

2013-06-14 Thread Valerie (Yu-Ching) Peng
Looks fine to me now. Thanks, Valerie On 06/13/13 05:35, John Zavgren wrote: All: Please give this change one more consideration. Thanks! John Original Message Subject:Re: Re: RFR JDK-8014307 Date: Fri, 24 May 2013 15:56:11 -0400 From: John Zavgren To: Secur

Re: Code review request for 8012637: Adjust CipherInputStream class to work in AEAD/GCM mode

2013-06-14 Thread Valerie (Yu-Ching) Peng
Ok, I will update that. Thanks for the review, Valerie On 06/13/13 03:02, Xuelei Fan wrote: Looks fine to me. A very very minor comment is about the code conversions. Personally, I prefer to use braces around all statements (if-else, while, etc). See also: http://www.oracle.com/technetwork/jav