Re: Code review request: 8017453: ReplayCache tests fail on multiple platforms (was Re: Please be prepared for possible test failures (was Fwd: [JBS] (JDK-8001326) Improve Kerberos replay caching))

2013-06-23 Thread Wang Weijun
Send again. And BTW, JPRT runs fine. 在 Jun 23, 2013，6:29 PM，Weijun Wang 写道： > The macosx problem found, the machine's native GSS does not support shared > replaycache. > > *Valerie* and/or *Xuelei*, can you please review the fix? > > http://cr.openjdk.java.net/~weijun/8017453/webrev.00/ >

Re: Code review request: 8017453: ReplayCache tests fail on multiple platforms (was Re: Please be prepared for possible test failures (was Fwd: [JBS] (JDK-8001326) Improve Kerberos replay caching))

2013-06-23 Thread Xuelei Fan
ReplayCacheTestProc.java 75 String os = System.getProperty("os.name", "???"); What happens if "os" is "???"? Xuelei On 6/24/2013 12:36 AM, Wang Weijun wrote: > Send again. And BTW, JPRT runs fine. > > 在 Jun 23, 2013，6:29 PM，Weijun Wang 写道： > >> The macosx proble

Re: Code review request: 8017453: ReplayCache tests fail on multiple platforms (was Re: Please be prepared for possible test failures (was Fwd: [JBS] (JDK-8001326) Improve Kerberos replay caching))

2013-06-23 Thread Weijun Wang
On 6/24/13 9:49 AM, Xuelei Fan wrote: > ReplayCacheTestProc.java > > 75 String os = System.getProperty("os.name", "???"); > > What happens if "os" is "???"? Then it's neither Windows nor Mac OS X. :) I gave a default value so that the result will not be null. Alt

Re: Code review request: 8017453: ReplayCache tests fail on multiple platforms (was Re: Please be prepared for possible test failures (was Fwd: [JBS] (JDK-8001326) Improve Kerberos replay caching))

2013-06-23 Thread Xuelei Fan
On 6/24/2013 10:01 AM, Weijun Wang wrote: > > > On 6/24/13 9:49 AM, Xuelei Fan wrote: >> ReplayCacheTestProc.java >> >> 75 String os = System.getProperty("os.name", "???"); >> >> What happens if "os" is "???"? > > Then it's neither Windows nor Mac OS X. :) > The c

Re: Code review request: 8017453: ReplayCache tests fail on multiple platforms (was Re: Please be prepared for possible test failures (was Fwd: [JBS] (JDK-8001326) Improve Kerberos replay caching))

2013-06-23 Thread Weijun Wang
How about if (!os.startsWith("Solaris") || !os.startsWith("Linux")) { mode = -1; } Thanks Max On 6/24/13 10:35 AM, Xuelei Fan wrote: > On 6/24/2013 10:01 AM, Weijun Wang wrote: >> >> >> On 6/24/13 9:49 AM, Xuelei Fan wrote: >>> ReplayCacheTestProc.java >>

Re: Code review request: 8017453: ReplayCache tests fail on multiple platforms (was Re: Please be prepared for possible test failures (was Fwd: [JBS] (JDK-8001326) Improve Kerberos replay caching))

2013-06-23 Thread Weijun Wang
Oh, no if (!os.startsWith("Solaris") && !os.startsWith("Linux")) { --Max On 6/24/13 11:01 AM, Weijun Wang wrote: > How about > > if (!os.startsWith("Solaris") || !os.startsWith("Linux")) { > mode = -1; > } > > Thanks > Max > > > On 6/24/13 10:35 AM

Re: Code review request: 8017453: ReplayCache tests fail on multiple platforms (was Re: Please be prepared for possible test failures (was Fwd: [JBS] (JDK-8001326) Improve Kerberos replay caching))

2013-06-23 Thread Xuelei Fan
On 6/24/2013 11:04 AM, Weijun Wang wrote: > Oh, no > > if (!os.startsWith("Solaris") && !os.startsWith("Linux")) { > Good. Xuelei > --Max > > On 6/24/13 11:01 AM, Weijun Wang wrote: >> How about >> >> if (!os.startsWith("Solaris") || !os.startsWith("Linux")) { >>

Re: Code review request: 8017453: ReplayCache tests fail on multiple platforms (was Re: Please be prepared for possible test failures (was Fwd: [JBS] (JDK-8001326) Improve Kerberos replay caching))

2013-06-23 Thread Weijun Wang
Oh, actually it should be SunOS. On 6/24/13 11:28 AM, Xuelei Fan wrote: > On 6/24/2013 11:04 AM, Weijun Wang wrote: >> Oh, no >> >> if (!os.startsWith("Solaris") && !os.startsWith("Linux")) { >> > Good. > > Xuelei > >> --Max >> >> On 6/24/13 11:01 AM, Weijun Wang wrote: >>> How about >>> >>>

Re: Code review request: 8017453: ReplayCache tests fail on multiple platforms (was Re: Please be prepared for possible test failures (was Fwd: [JBS] (JDK-8001326) Improve Kerberos replay caching))

2013-06-23 Thread Xuelei Fan
On 6/24/2013 12:29 PM, Weijun Wang wrote: > Oh, actually it should be SunOS. > Really? Then I would suggest you also check "Solaris". http://www.javaneverdie.com/java/java-os-name-property-values/ Xuelei > On 6/24/13 11:28 AM, Xuelei Fan wrote: >> On 6/24/2013 11:04 AM, Weijun Wang wrote: >>> O

Re: Code review request: 8017453: ReplayCache tests fail on multiple platforms (was Re: Please be prepared for possible test failures (was Fwd: [JBS] (JDK-8001326) Improve Kerberos replay caching))

2013-06-23 Thread Weijun Wang
I would stick to SunOS since that's how the JGSS native provider detects the OS. Maybe do a detailed check later. On 6/24/13 12:36 PM, Xuelei Fan wrote: > On 6/24/2013 12:29 PM, Weijun Wang wrote: >> Oh, actually it should be SunOS. >> > Really? Then I would suggest you also check "Solaris". > >

Re: Code review request: 8017453: ReplayCache tests fail on multiple platforms (was Re: Please be prepared for possible test failures (was Fwd: [JBS] (JDK-8001326) Improve Kerberos replay caching))

2013-06-23 Thread Xuelei Fan
On 6/24/2013 12:41 PM, Weijun Wang wrote: > I would stick to SunOS since that's how the JGSS native provider detects > the OS. Maybe do a detailed check later. > OK. Xuelei > On 6/24/13 12:36 PM, Xuelei Fan wrote: >> On 6/24/2013 12:29 PM, Weijun Wang wrote: >>> Oh, actually it should be SunOS. >>