Hi Artem
Line 221 is a little too long, you may want to break it. Otherwise, fine.
Have you tried running JPRT with at least the jdk_security test?
Thanks
Max
On 6/25/2013 1:35 PM, Artem Smotrakov wrote:
Hi,
please review this fix for 8:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8
Hi Max
I updated the webrev:
http://1.smotrakov.z8.ru/8016051/webrev.01/src/share/classes/sun/security/krb5/KdcComm.java.udiff.html
I built OpenJDK on Linux x64 according to
http://hg.openjdk.java.net/jdk8/build/raw-file/tip/README-builds.html,
and ran JCK, SQE (related to Kerberos), jdk_secu
Changeset: 01fcca3d2b8c
Author:bpb
Date: 2013-06-20 12:15 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/01fcca3d2b8c
4641897: Faster string conversion of large integers
Summary: Accelerate conversion to string by means of Schoenhage recursive base
conversion.
Reviewed-by: b
Changeset: 4a4d910e1504
Author:alanb
Date: 2013-06-25 13:53 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4a4d910e1504
8017570: jfr.jar should not be in compact3 (for now)
Reviewed-by: erikj
! makefiles/profile-includes.txt
Changeset: 89631a384ee6
Author:weijun
Date: 2013-06-25 21:51 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/89631a384ee6
8016051: Possible ClassCastException in KdcComm
Reviewed-by: weijun
Contributed-by: Artem Smotrakov
! src/share/classes/sun/security/krb5/KdcComm.java
I pushed the changeset to
http://hg.openjdk.java.net/jdk8/tl/jdk/rev/89631a384ee6
You have some TAB characters and one trailing whitespace. I've removed them.
Thanks
Max
On 6/25/13 8:33 PM, Artem Smotrakov wrote:
Hi Max
I updated the webrev:
http://1.smotrakov.z8.ru/8016051/webrev.01/src
Greetings:
I made a change to
src/share/native/sun/security/pkcs11/wrapper/p11_convert.c... I replaced
all the code that looks like this:
struct fubar bar;
memset(&bar, 0, sizeof(struct fubar));
with code that looks like this:
struct fubar bar = {0};
Also, I looked for similar usage patter
Changeset: 831467c4c6a7
Author:vromero
Date: 2013-06-25 16:12 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/831467c4c6a7
8017104: javac should have a class for primitive types that inherits from Type
Reviewed-by: jjg
! src/share/classes/com/sun/tools/javac/api/JavacTr
Changeset: aceae9ceebbe
Author:kizune
Date: 2013-06-25 20:08 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/aceae9ceebbe
8006973: jtreg test fails:
test/tools/javac/warnings/AuxiliaryClass/SelfClassWithAux.java
Reviewed-by: ksrini
! test/tools/javac/warnings/Auxiliary
Changeset: ac61efd8c593
Author:shade
Date: 2013-06-25 20:06 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ac61efd8c593
8014233: java.lang.Thread should have @Contended on TLR fields
Summary: add the @Contended over three TLR fields.
Reviewed-by: psandoz, chegar, dholmes, dl
Hi Jason,
The javadoc changes look good to go back.
Thanks,
-Joe
On 6/25/2013 1:23 PM, Jason Uh wrote:
Joe,
Here are the updated webrevs:
- java.security.cert:
http://cr.openjdk.java.net/~juh/8017325/webrev.02/
- java.security.spec:
http://cr.openjdk.java.net/~juh/8017326/webrev.0
Changeset: 757290440a2f
Author:juh
Date: 2013-06-25 14:31 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/757290440a2f
8017325: Cleanup of the javadoc tag in java.security.cert
Summary: Convert javadoc ... and ... tags to {@code ...}
Reviewed-by: darcy
! src/share/classes/ja
Changeset: 3700bb58c9a2
Author:juh
Date: 2013-06-25 14:41 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3700bb58c9a2
8017326: Cleanup of the javadoc tag in java.security.spec
Summary: Convert javadoc and tags to {@code ...}
Reviewed-by: darcy
! src/share/classes/java/sec
Changeset: bf020de5a6db
Author:emc
Date: 2013-06-24 22:03 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bf020de5a6db
8012722: Single comma in array initializer should parse
Summary: Annotations of the form @Foo({,}) should parse
Reviewed-by: jjg
! src/share/classes/co
Hi everyone,
I've been playing with smart cards and faced some issues.
Long story short:
*Prerequisites*:
- I set up a basic Kerberos realm via Windows Active Directory.
- I managed to successfully login into service via *login/password* pair
using Java Kerberos(Krb5LoginModule), which
It's covered by SQE interoperability tests.
In terms of regression tests, I think we should not put any 3rd party
provider-related stuff.
I can add a regression test to make sure that optional component doesn't
affect the equals check if you see value in doing this kind of test.
Thanks,
Valerie
- The private static native boolean nssInit(...) method should be
removed? It seems obsolete by nssInitWithOptions(...) and I didn't see
it being used anywhere. Same goes for the corresponding JNI method impl,
i.e. Java_sun_security_pkcs11_Secmod_nssInit, in the j2secmod.c file.
- Particul
在 Jun 26, 2013，6:51 AM，"Valerie (Yu-Ching) Peng" 写道：
> It's covered by SQE interoperability tests.
That's enough.
> In terms of regression tests, I think we should not put any 3rd party
> provider-related stuff.
> I can add a regression test to make sure that optional component doesn't
> af
I'm not authoritative, but AFAIK there is no smart card support in Java, though
there is pkcs11 support.
If I had to do it, I would do the smart card/PKINIT stuff outside Java, and
then let Java use the acquired tgt.
On Jun 25, 2013, at 5:52 AM, Ostap Andrusiv wrote:
> Hi everyone,
>
> I've
Great, thanks for the review!
Valerie
On 06/25/13 16:34, Wang Weijun wrote:
>
> 在 Jun 26, 2013，6:51 AM，"Valerie (Yu-Ching) Peng" 写道：
>
>> It's covered by SQE interoperability tests.
> That's enough.
>
>> In terms of regression tests, I think we should not put any 3rd party
>> provider-related st
Java (at least Oracle JDK) does not support PKINIT.
Yes, you can do it outside, create a KerberosTicket and a
KerberosPrincipal, create a JAAS Subject containing them, and call
Subject.doAs() later. It should work.
On Windows, if you manage to use Windows' own login and have the ticket
store
Hi, Hotspot guys
We (SE security) received a bug report on a new crash for 7u25 and need
some help from you:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8017264
Here the top frames look like:
C [msvcr100.dll+0x10b3b] wcspbrk+0x12d
V [jvm.dll+0xa9b63]
C [w2k_lsa_auth.dll+0x167c]
Hi,
webrev: http://cr.openjdk.java.net/~xuelei/8017049/webrev.00/
In update of 7188658
(http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a76858faad59), we defines a
new system property, "jdk.tls.rejectClientInitializedRenego", in order
to disable client initiated renegotiation. However, the name is no
Java provides the javax.smartcardio package for direct access to the smart
card. But that's probably not what he's looking for. Mike
Sent from my iPad
On Jun 25, 2013, at 19:29, "Henry B. Hotz" wrote:
> I'm not authoritative, but AFAIK there is no smart card support in Java,
> though there
Jason
Can you please add the appropriate noreg- label for the 2 bugs -
JDK-8017325 & JDK-8017326
Thanks
Nithya
On 6/25/2013 1:32 PM, Joe Darcy wrote:
Hi Jason,
The javadoc changes look good to go back.
Thanks,
-Joe
On 6/25/2013 1:23 PM, Jason Uh wrote:
Joe,
Here are the updated webrevs
25 matches
Mail list logo
