Oracle returning null to getCodeBase() is a bug

2013-09-01 Thread Jerry Jongerius
Oracle claims the fix was 'security' related, and was required to prevent a sandboxed applet from obtaining access to "file path" information (the folder name where the applet is being run). But Oracle failed horrible, as explained in great detail here: http://www.duckware.com/tech/java-securit

Code review request, JKD-8024068 sun/security/ssl/javax/net/ssl/ServerName/IllegalSNIName.java fails

2013-09-01 Thread Xuelei Fan
Hi Weijun, Please review this simple test fix. There is a typo in the test. The issue is exposed after the fix of JDK-8023881. webrev: http://cr.openjdk.java.net/~xuelei/8024068/webrev.00/ This bug may not have been published to bugs.sun.com. The typo and the patch look like: String[

Re: Code review request, JKD-8024068 sun/security/ssl/javax/net/ssl/ServerName/IllegalSNIName.java fails

2013-09-01 Thread Xuelei Fan
On 9/2/2013 10:38 AM, Xuelei Fan wrote: > Hi Weijun, > > Please review this simple test fix. There is a typo in the test. The > issue is exposed after the fix of JDK-8023881. > > webrev: http://cr.openjdk.java.net/~xuelei/8024068/webrev.00/ > > This bug may not have been published to bugs.sun.c

Re: Code review request, JKD-8024068 sun/security/ssl/javax/net/ssl/ServerName/IllegalSNIName.java fails

2013-09-01 Thread Weijun Wang
Code change looks fine. --Max On 9/2/13 10:41 AM, Xuelei Fan wrote: On 9/2/2013 10:38 AM, Xuelei Fan wrote: Hi Weijun, Please review this simple test fix. There is a typo in the test. The issue is exposed after the fix of JDK-8023881. webrev: http://cr.openjdk.java.net/~xuelei/8024068/webre

Re: Code review request, JKD-8024068 sun/security/ssl/javax/net/ssl/ServerName/IllegalSNIName.java fails

2013-09-01 Thread Bradford Wetmore
Same. Brad On 9/1/2013 7:45 PM, Weijun Wang wrote: Code change looks fine. --Max On 9/2/13 10:41 AM, Xuelei Fan wrote: On 9/2/2013 10:38 AM, Xuelei Fan wrote: Hi Weijun, Please review this simple test fix. There is a typo in the test. The issue is exposed after the fix of JDK-8023881. w

hg: jdk8/tl/jdk: 8024068: sun/security/ssl/javax/net/ssl/ServerName/IllegalSNIName.java fails

2013-09-01 Thread xuelei . fan
Changeset: ead6babac5a9 Author:xuelei Date: 2013-09-01 20:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ead6babac5a9 8024068: sun/security/ssl/javax/net/ssl/ServerName/IllegalSNIName.java fails Reviewed-by: weijun ! test/sun/security/ssl/javax/net/ssl/ServerName/IllegalS