hg: jdk8/tl/langtools: 8023974: Drop 'implements Completer' and 'implements SourceCompleter' from ClassReader resp. JavaCompiler.

2013-09-05 Thread joel . franck
Changeset: a76c663a9cac Author:jfranck Date: 2013-09-05 11:27 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a76c663a9cac 8023974: Drop 'implements Completer' and 'implements SourceCompleter' from ClassReader resp. JavaCompiler. Reviewed-by: jjg, jfranck Contributed-by

Re: Code Review Request: 8004283 SecretKeysBasic.sh failing intermittently

2013-09-05 Thread Vincent Ryan
Your fix looks fine to me. Thanks. On 5 Sep 2013, at 18:51, Anthony Scarpino wrote: > Hi, > > I'd like a code review, really short, for 8004283 > test/sun/security/pkcs11/KeyStore/SecretKeysBasic.sh failing intermittently. > > http://cr.openjdk.java.net/~ascarpino/8004283/webrev.00/ > > thank

hg: jdk8/tl/jdk: 8023943: Method description fix for String.toLower/UpperCase() methods

2013-09-05 Thread naoto . sato
Changeset: 4c711ef41bfa Author:naoto Date: 2013-09-05 10:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4c711ef41bfa 8023943: Method description fix for String.toLower/UpperCase() methods Reviewed-by: okutsu ! src/share/classes/java/lang/String.java

Code Review Request: 8004283 SecretKeysBasic.sh failing intermittently

2013-09-05 Thread Anthony Scarpino
Hi, I'd like a code review, really short, for 8004283 test/sun/security/pkcs11/KeyStore/SecretKeysBasic.sh failing intermittently. http://cr.openjdk.java.net/~ascarpino/8004283/webrev.00/ thanks Tony

hg: jdk8/tl/jdk: 8024283: 10 nashorn tests fail with similar stack trace InternalError with cause being NoClassDefFoundError

2013-09-05 Thread robert . field
Changeset: 9cc74675a854 Author:rfield Date: 2013-09-05 14:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9cc74675a854 8024283: 10 nashorn tests fail with similar stack trace InternalError with cause being NoClassDefFoundError Summary: Fix pre-existing 292 bug tickled by c

Re: [JDK 8] Code review request 7188657, There should be a way to reorder the JSSE ciphers

2013-09-05 Thread Xuelei Fan
If no objections, I will push the changeset. Xuelei On 9/4/2013 11:34 AM, Xuelei Fan wrote: > new webrev: http://cr.openjdk.java.net/~xuelei/7188657/webrev.01/ > > On 9/4/2013 10:35 AM, Weijun Wang wrote: >> Mostly good, only some word/style issues. >> >> SSLParameters.java: >> >> 83 * se