Alan,
I checked the httpsever and sctp changes. All look good to me.
-Chris.
On 10/06/2013 09:03 PM, Alan Bateman wrote:
As a follow-up to Joe Darcy's rename of jdk.Supported to jdk.Exported,
I'd like to have another attempt at adding the annotation to a number of
JDK specific APIs that are l
The JAAS and JGSS changes look fine too.
On 7 Oct 2013, at 09:23, Chris Hegarty wrote:
> Alan,
>
> I checked the httpsever and sctp changes. All look good to me.
>
> -Chris.
>
> On 10/06/2013 09:03 PM, Alan Bateman wrote:
>>
>> As a follow-up to Joe Darcy's rename of jdk.Supported to jdk.Exp
Hi Alan,
The com.sun.management changes look good.
-- daniel
On 10/6/13 10:03 PM, Alan Bateman wrote:
As a follow-up to Joe Darcy's rename of jdk.Supported to jdk.Exported,
I'd like to have another attempt at adding the annotation to a number of
JDK specific APIs that are long standing export
On 10/6/2013 1:03 PM, Alan Bateman wrote:
The webrev with the proposed update is here:
http://cr.openjdk.java.net/~alanb/8008662/webrev.02/
I went through the entire webrev and the change looks good.
For the review then the intention is that @jdk.Exported be added to
the package-info a
Changeset: 0ac9dc315071
Author:alanb
Date: 2013-10-07 11:48 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0ac9dc315071
8025983: Typo in Javadoc of Files.isRegularFile()
Reviewed-by: mchung, chegar
! src/share/classes/java/nio/file/Files.java
! src/share/classes/java/nio/fil
On 07/10/2013 11:31, Mandy Chung wrote:
:
For the review then the intention is that @jdk.Exported be added to
the package-info and all public/protected types in these APIs. The
only exceptions are two cases where I've added @jdk.Exported(false),
specifically:
- com.sun.management.OSMBeanF
7 classes in com.sun.security.auth have been deprecated for several
major releases now. Should they still have this annotation?
--Sean
On 10/06/2013 04:03 PM, Alan Bateman wrote:
As a follow-up to Joe Darcy's rename of jdk.Supported to jdk.Exported,
I'd like to have another attempt at adding
On 07/10/2013 13:26, Sean Mullan wrote:
7 classes in com.sun.security.auth have been deprecated for several
major releases now. Should they still have this annotation?
--Sean
I know but aren't they still exported and supported?
DialogCallbackHandler is the only one with its name on a bullet.
On 10/07/2013 08:28 AM, Alan Bateman wrote:
On 07/10/2013 13:26, Sean Mullan wrote:
7 classes in com.sun.security.auth have been deprecated for several
major releases now. Should they still have this annotation?
--Sean
I know but aren't they still exported and supported?
They have all had AP
On 07/10/2013 13:36, Sean Mullan wrote:
We have only started removing some deprecated things in JDK, so it
just was never thought about until now. Marking these as supported
going forward strikes me as a bit strange, since we don't really want
anyone using these anymore.
As a guide, I think w
On 10/07/2013 08:58 AM, Alan Bateman wrote:
On 07/10/2013 13:36, Sean Mullan wrote:
We have only started removing some deprecated things in JDK, so it
just was never thought about until now. Marking these as supported
going forward strikes me as a bit strange, since we don't really want
anyone
I would also send this to core-libs-dev for someone to look over the
non-security component changes.
--Sean
On 10/04/2013 06:24 PM, Valerie (Yu-Ching) Peng wrote:
Well, can someone please review the following trivial fix today or early
Monday?
8025967: addition of -Werror broke the old build
Thanks Vinnie for the review~
Forwarding this request to core-libs-dev per Sean's suggestion.
Changes are for getting rid of compiler warnings in order for JCE
provider build (still using the old build process) to complete
successfully - either add the annotation to suppress rawtype warnings or
Changeset: f0ad3e2918b4
Author:henryjen
Date: 2013-10-07 11:25 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f0ad3e2918b4
8025968: Integrate test improvements made in lambda repo
Reviewed-by: psandoz
! test/java/util/stream/bootlib/java/util/stream/OpTestCase.java
!
test/j
Hello,
I skimmed the patch and it looked fine.
More generally, we want every package and top-level class in the
com.sun.* namespace to be either explicitly exported or not.
Cheers,
-Joe
On 10/6/2013 1:03 PM, Alan Bateman wrote:
As a follow-up to Joe Darcy's rename of jdk.Supported to jdk.
Changeset: 4dd7ffbf01fb
Author:darcy
Date: 2013-10-07 16:51 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4dd7ffbf01fb
8026017: Make history of AnnotatedConstruct methods in jx.l.m.e.Element clearer
Reviewed-by: jjg
! src/share/classes/javax/lang/model/element/Element
Changeset: 0cffe1dab0bf
Author:henryjen
Date: 2013-10-07 15:18 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0cffe1dab0bf
8026009: Changes for 8025968 break all stream tests
Reviewed-by: mduigou
! test/java/util/stream/bootlib/java/util/stream/OpTestCase.java
Changeset: 0d5f4f1782e8
Author:xuelei
Date: 2013-10-07 18:46 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0d5f4f1782e8
6956398: make ephemeral DH key match the length of the certificate key
Reviewed-by: weijun
! src/share/classes/sun/security/ssl/ServerHandshaker.java
+
t
18 matches
Mail list logo
