hg: jdk8/tl/langtools: 8026857: AnnoConstruct.getAnnotationsByType does not search supertype for inherited annotations if @SomeContainer({}) is present

2013-10-22 Thread joel . franck
Changeset: f003f09144ff Author:jfranck Date: 2013-10-22 10:08 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f003f09144ff 8026857: AnnoConstruct.getAnnotationsByType does not search supertype for inherited annotations if @SomeContainer({}) is present Summary: An empty

hg: jdk8/tl/jdk: 8009411: (reflect) Class.getMethods should not include static methods from interfaces

2013-10-22 Thread joel . franck
Changeset: 04ba97b7c2f9 Author:jfranck Date: 2013-10-22 10:34 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/04ba97b7c2f9 8009411: (reflect) Class.getMethods should not include static methods from interfaces Summary: Update getMethods() and getMethod() to filter out interfac

hg: jdk8/tl/jdk: 8026962: Put java/lang/management/ClassLoadingMXBean/LoadCounts.java into ProblemList.txt

2013-10-22 Thread staffan . larsen
Changeset: bb2fb6be8b2a Author:ykantser Date: 2013-10-22 10:57 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bb2fb6be8b2a 8026962: Put java/lang/management/ClassLoadingMXBean/LoadCounts.java into ProblemList.txt Reviewed-by: sla, jbachorik ! test/ProblemList.txt

hg: jdk8/tl/jdk: 8004912: Repeating annotations - getAnnotationsByType(Class) is not working as expected for few inheritance scenarios; ...

2013-10-22 Thread joel . franck
Changeset: b07856d0de34 Author:alundblad Date: 2013-10-22 12:35 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b07856d0de34 8004912: Repeating annotations - getAnnotationsByType(Class) is not working as expected for few inheritance scenarios 8019420: Repeatable non-inheritab

hg: jdk8/tl/corba: 8021257: com.sun.corba.se.** should be on restricted package list

2013-10-22 Thread alan . bateman
Changeset: 52ad44f9a3ec Author:alanb Date: 2013-10-22 11:40 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/52ad44f9a3ec 8021257: com.sun.corba.se.** should be on restricted package list Reviewed-by: chegar, coffeys, smarks Contributed-by: [email protected], mark.shepp

hg: jdk8/tl/jdk: 8024833: (fc) FileChannel.map does not handle async close/interrupt correctly

2013-10-22 Thread alan . bateman
Changeset: f15ad52cffed Author:alanb Date: 2013-10-22 12:04 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f15ad52cffed 8024833: (fc) FileChannel.map does not handle async close/interrupt correctly Reviewed-by: alanb Contributed-by: [email protected] ! src/share/class

hg: jdk8/tl/jdk: 8021257: com.sun.corba.se.** should be on restricted package list

2013-10-22 Thread alan . bateman
Changeset: 6f9515a9519f Author:alanb Date: 2013-10-22 11:43 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6f9515a9519f 8021257: com.sun.corba.se.** should be on restricted package list Reviewed-by: chegar, coffeys, smarks, mullan Contributed-by: [email protected], mark

Re: [8] Review Request for 8021191: Add isAuthorized check to limited doPrivileged methods

2013-10-22 Thread Sean Mullan
On 10/21/2013 10:00 PM, Weijun Wang wrote: In AccessController.java, existing doc always has a "specified" between "the" and "{@code AccessControlContext}". Fixed. BTW, maybe a little off-topic, I am not sure about the exact meaning of "with no permissions". jre/lib/security/java.policy has g

RFR 8027026: Change keytool -genkeypair to use -keyalg RSA

2013-10-22 Thread Weijun Wang
There is a bug on Solaris on DSA keypair generation, and DSA related test has a 1/256 probability to fail at signature verification. This fix updates all non algorithm related "keytool -genkeypair" calls to using RSA. Please take a review: http://cr.openjdk.java.net/~weijun/8027026/webrev.0

hg: jdk8/tl/langtools: 8025290: javac implicit versus explicit lambda compilation error

2013-10-22 Thread vicente . romero
Changeset: 963c57175e40 Author:vromero Date: 2013-10-22 13:54 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/963c57175e40 8025290: javac implicit versus explicit lambda compilation error Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/comp/Attr.java !

Re: RFR 8027026: Change keytool -genkeypair to use -keyalg RSA

2013-10-22 Thread Alan Bateman
On 22/10/2013 13:55, Weijun Wang wrote: There is a bug on Solaris on DSA keypair generation, and DSA related test has a 1/256 probability to fail at signature verification. This fix updates all non algorithm related "keytool -genkeypair" calls to using RSA. Please take a review: http://cr

Re: RFR 8027026: Change keytool -genkeypair to use -keyalg RSA

2013-10-22 Thread Chris Hegarty
On 22/10/2013 14:00, Alan Bateman wrote: On 22/10/2013 13:55, Weijun Wang wrote: There is a bug on Solaris on DSA keypair generation, and DSA related test has a 1/256 probability to fail at signature verification. This fix updates all non algorithm related "keytool -genkeypair" calls to using RS

hg: jdk8/tl/jdk: 8017779: java/net/Authenticator/B4769350.java fails

2013-10-22 Thread chris . hegarty
Changeset: 7cafbb397683 Author:chegar Date: 2013-10-22 14:00 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7cafbb397683 8017779: java/net/Authenticator/B4769350.java fails Reviewed-by: chegar Contributed-by: Tristan Yan , Kurchi Subhra Hazra ! test/java/net/Authenticator/

hg: jdk8/tl/jdk: 3 new changesets

2013-10-22 Thread sean . mullan
Changeset: 5f4aecd73caa Author:mullan Date: 2013-10-22 08:03 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5f4aecd73caa 8021191: Add isAuthorized check to limited doPrivileged methods Reviewed-by: weijun, xuelei ! src/share/classes/java/security/AccessControlContext.java !

hg: jdk8/tl/jdk: 7074436: (sc) SocketChannel can do short gathering writes when channel configured blocking (win)

2013-10-22 Thread alan . bateman
Changeset: 54869853c06c Author:alanb Date: 2013-10-22 14:13 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/54869853c06c 7074436: (sc) SocketChannel can do short gathering writes when channel configured blocking (win) Reviewed-by: chegar ! src/windows/native/sun/nio/ch/Socke

Re: RFR 8027026: Change keytool -genkeypair to use -keyalg RSA

2013-10-22 Thread Sean Mullan
Looks good. --Sean On 10/22/2013 08:55 AM, Weijun Wang wrote: There is a bug on Solaris on DSA keypair generation, and DSA related test has a 1/256 probability to fail at signature verification. This fix updates all non algorithm related "keytool -genkeypair" calls to using RSA. Please take a

Re: [8] Request for Review: 8025287: NPE in api/java_security/cert/PKIXRevocationChecker/GeneralTests_GeneralTests

2013-10-22 Thread Sean Mullan
Hi Jason, The fix looks good. Even though there is a TCK test for this, I think you should add a regression test, and it should be very easy to add. You can add it to jdk/test/java/security/cert/PKIXRevocationChecker/UnitTest.java, ex: $ hg diff UnitTest.java diff -r 54869853c06c test/java/

hg: jdk8/tl/nashorn: 5 new changesets

2013-10-22 Thread sundararajan . athijegannathan
Changeset: d8d5b7919c57 Author:sundar Date: 2013-10-22 14:27 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/d8d5b7919c57 8027016: Array.prototype.indexOf should return -1 when array is of length zero Reviewed-by: lagergren, attila ! src/jdk/nashorn/internal/objects/Nativ

hg: jdk8/tl/jdk: 8023390: Test java/net/NetworkInterface/MemLeakTest.java failed with the latest jdk8 build

2013-10-22 Thread chris . hegarty
Changeset: 6a1989dc302d Author:igerasim Date: 2013-10-15 18:41 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6a1989dc302d 8023390: Test java/net/NetworkInterface/MemLeakTest.java failed with the latest jdk8 build Summary: Removing the test as it is unreliable and fails inte

Re: [8] 8012636: OCSP validation fails even when public key is trusted

2013-10-22 Thread Sean Mullan
I am still reviewing, but here are some comments so far: * X509CertImpl I would prefer if getSubjectKeyIdentifier returned a KeyIdentifier so that it is consistent with the getAuthKeyId method. Also, in OCSPResponse, you can then just call KeyIdentifier.equals instead of comparing the bytes y

hg: jdk8/tl/nashorn: 4 new changesets

2013-10-22 Thread sundararajan . athijegannathan
Changeset: 0ecbc0188b64 Author:attila Date: 2013-10-22 16:43 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/0ecbc0188b64 8027031: complete merging of loads and converts Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java ! src/jdk/nash

hg: jdk8/tl/jdk: 8026806: Incomplete test of getaddrinfo() return value could lead to incorrect exception for Windows Inet 6

2013-10-22 Thread brian . burkhalter
Changeset: 9758edb6976f Author:bpb Date: 2013-10-22 10:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9758edb6976f 8026806: Incomplete test of getaddrinfo() return value could lead to incorrect exception for Windows Inet 6 Summary: Check getaddrinfo return value before ca

hg: jdk8/tl/jdk: 8026818: Defmeth failures with -mode invoke

2013-10-22 Thread eric . mccorkle
Changeset: 23b124cbf242 Author:drchase Date: 2013-10-22 12:57 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/23b124cbf242 8026818: Defmeth failures with -mode invoke Summary: Added test for IllegalAccessException -> IllegalAccessError path to check if root cause was Abstract

Re: [8] 8012636: OCSP validation fails even when public key is trusted

2013-10-22 Thread Sean Mullan
I still need to review RevocationChecker but a few more comments ... * OCSPResponse - the responderKeyId field is never set. I believe line 299 should be: responderKeyId = seq.getData().getOctetString(); - lines 372-385. I think it would be better to not do any matching yet, and store all

hg: jdk8/tl/jdk: 8026873: tools/launcher/VersionCheck.java fails in jprt because of jmc.ini

2013-10-22 Thread alexander . zuev
Changeset: 72c0f289a8cb Author:kizune Date: 2013-10-22 22:18 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/72c0f289a8cb 8026873: tools/launcher/VersionCheck.java fails in jprt because of jmc.ini Reviewed-by: ksrini ! test/tools/launcher/VersionCheck.java

hg: jdk8/tl/jdk: 7179567: JCK8 tests: api/java_net/URLClassLoader/index.html#Ctor3 failed with NPE; ...

2013-10-22 Thread brian . burkhalter
Changeset: 2be08cdd1ced Author:bpb Date: 2013-10-22 11:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2be08cdd1ced 7179567: JCK8 tests: api/java_net/URLClassLoader/index.html#Ctor3 failed with NPE 6445180: URLClassLoader does not describe the behavior of several methods w

Re: [8] Request for Review: 8025287: NPE in api/java_security/cert/PKIXRevocationChecker/GeneralTests_GeneralTests

2013-10-22 Thread Jason Uh
Hi Sean, Thanks. I've added a test and have removed "noreg-jck." I'll push if you're okay with the change. http://cr.openjdk.java.net/~juh/8025287/webrev.01/ Jason On 10/22/2013 06:49 AM, Sean Mullan wrote: Hi Jason, The fix looks good. Even though there is a TCK test for this, I think you

Re: [8] Request for Review: 8025287: NPE in api/java_security/cert/PKIXRevocationChecker/GeneralTests_GeneralTests

2013-10-22 Thread Sean Mullan
Just add the bugid to the @bug tag in the test and it looks good to push. --Sean On 10/22/2013 02:41 PM, Jason Uh wrote: Hi Sean, Thanks. I've added a test and have removed "noreg-jck." I'll push if you're okay with the change. http://cr.openjdk.java.net/~juh/8025287/webrev.01/ Jason On 10/

hg: jdk8/tl/jdk: 8027062: Fix lint and doclint issues in java.lang.{ClassLoader, ClassValue, SecurityManager}

2013-10-22 Thread joe . darcy
Changeset: 9a32af82bd1e Author:darcy Date: 2013-10-22 12:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9a32af82bd1e 8027062: Fix lint and doclint issues in java.lang.{ClassLoader, ClassValue, SecurityManager} Reviewed-by: chegar, forax, alanb, mduigou ! src/share/classe

hg: jdk8/tl/jdk: 8025287: NPE in api/java_security/cert/PKIXRevocationChecker/GeneralTests_GeneralTests

2013-10-22 Thread jason . uh
Changeset: c956a5d0618f Author:juh Date: 2013-10-22 11:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c956a5d0618f 8025287: NPE in api/java_security/cert/PKIXRevocationChecker/GeneralTests_GeneralTests Reviewed-by: mullan ! src/share/classes/sun/security/provider/certpat

hg: jdk8/tl/jdk: 3 new changesets

2013-10-22 Thread roger . riggs
Changeset: e2b814e68956 Author:rriggs Date: 2013-10-22 15:03 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e2b814e68956 8024686: Cleanup of java.time serialization source Summary: optimize serialized form of OffsetTime, OffsetDateTime; correct order of modifiers Reviewed-by

Re: [8] 8012636: OCSP validation fails even when public key is trusted

2013-10-22 Thread Sean Mullan
Just one more comment on RevocationChecker: - I'd prefer if the getResponderCert methods remained static. You can do that by creating a local variable in getResponderCerts(X509CertSelector,Set,List) to hold the certs and then returning that. --Sean On 10/22/2013 02:08 PM, Sean Mullan wrote:

hg: jdk8/tl/jdk: 8026982: javadoc errors in core libs

2013-10-22 Thread roger . riggs
Changeset: 4bb758a77fd7 Author:rriggs Date: 2013-10-22 17:02 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4bb758a77fd7 8026982: javadoc errors in core libs Summary: Cleanup of javadoc -Xlint errors Reviewed-by: lancea, mduigou, darcy, mullan, mchung ! src/share/classes/jav

hg: jdk8/tl/jdk: 3 new changesets

2013-10-22 Thread michael . fang
Changeset: e84413f066e0 Author:mfang Date: 2013-10-22 14:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e84413f066e0 8026109: [ja] overtranslation of jarsigner in command line output Reviewed-by: naoto ! src/share/classes/sun/security/tools/jarsigner/Resources_ja.java C

hg: jdk8/tl/jdk: 8026427: deprecate obsolete APIs from java.rmi

2013-10-22 Thread stuart . marks
Changeset: 9fbf35589211 Author:smarks Date: 2013-10-22 14:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9fbf35589211 8026427: deprecate obsolete APIs from java.rmi Reviewed-by: alanb, dfuchs ! src/share/classes/java/rmi/RMISecurityManager.java ! src/share/classes/java/rm

hg: jdk8/tl/jdk: 8025909: Lambda Library Spec Updates; ...

2013-10-22 Thread henry . jen
Changeset: 0913c3bab168 Author:henryjen Date: 2013-10-22 15:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0913c3bab168 8025909: Lambda Library Spec Updates 8024179: Document limitations and performance characteristics of stream sources and operations 8024138: (Spec clari

hg: jdk8/tl/jdk: 2 new changesets

2013-10-22 Thread sean . mullan
Changeset: fc7a6fa3589a Author:ascarpino Date: 2013-10-22 19:37 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fc7a6fa3589a 8025763: Provider does not override new Hashtable methods Reviewed-by: mullan ! src/share/classes/java/security/Provider.java Changeset: b065de1700d3

hg: jdk8/tl/langtools: 8023668: Desugar serializable lambda bodies using more robust naming scheme

2013-10-22 Thread robert . field
Changeset: 6cd16d8ed2b9 Author:rfield Date: 2013-10-22 16:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6cd16d8ed2b9 8023668: Desugar serializable lambda bodies using more robust naming scheme Summary: lambda / bridged method-reference naming overhaul Reviewed-by: k

hg: jdk8/tl/jdk: 8027026: Change keytool -genkeypair to use -keyalg RSA

2013-10-22 Thread weijun . wang
Changeset: d545d67e2f68 Author:weijun Date: 2013-10-23 08:32 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d545d67e2f68 8027026: Change keytool -genkeypair to use -keyalg RSA Reviewed-by: alanb, chegar, mullan ! test/ProblemList.txt ! test/java/util/TimeZone/TimeZoneDatePer

hg: jdk8/tl/langtools: 2 new changesets

2013-10-22 Thread jonathan . gibbons
Changeset: 351d6808c1a5 Author:jjg Date: 2013-10-22 17:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/351d6808c1a5 8027119: Cleanup javadoc comments for taglet API Reviewed-by: mduigou ! src/share/classes/com/sun/javadoc/Tag.java Changeset: 41d3ffca22ff Author:

Re: [8] 8012636: OCSP validation fails even when public key is trusted

2013-10-22 Thread Xuelei Fan
OCSPResponse.java line 442-445: - I like the old style that once the certs in response is not empty, we should check that the cert are trusted. This update may ignore the certs in response. Xuelei On 10/22/2013 12:41 PM, Xuelei Fan wrote: > OCSPRequest.java > ==