In JDK 8 we deprecated the JDK 1.1-era SecurityManager methods
checkTopLevelWindow, checkSystemClipboard and
checkAccessAwtEventQueueAccess with a warning that they would be changed
in a future release to check AllPermission. At the same time we changed
the java.awt.Window and Toolkit methods
DialogCallbackHandler is the sample Swing based CallbackHandler in the
JDK-specific API to JAAS. It's problematic for our modularity efforts
and as folks may recall, we deprecated it in JDK 8 with a warning to say
that it would be removed in a future release. It was also flagged in JEP
162 as
Alan,
in case you need to make a second revision, I would sneak in the removal
of the TextCallbackHandler import in NoQuoteParams. It seems not to be
used similiar to the DialogCallback.
Another nit, For the Login.java I would add the password to the
constructor of $PasswordCallbackHandle
Thanks for your reviews. I’ve made a minor change to include a message in
the CPVE, as suggested by Max.
% hg diff OCSPResponse.java
diff --git a/src/share/classes/sun/security/provider/certpath/OCSPResponse.java
b/src/share/classes/sun/security/provider/certpath/OCSPResponse.java
--- a/src/share
I have no objections to removing this class. Fix looks fine. I'm ok with
adding Bernd's suggestions as well, as they are both trivial cleanups.
--Sean
On 12/10/2013 11:46 AM, Alan Bateman wrote:
DialogCallbackHandler is the sample Swing based CallbackHandler in the
JDK-specific API to JAAS. I
Alan,
The change looks good. A minor one - in the class description of
java.lang.SecurityManager, I suggest to remove the references to
java.awt.AWTPermission line 143 and 214.
Mandy
On 12/10/2013 5:51 AM, Alan Bateman wrote:
In JDK 8 we deprecated the JDK 1.1-era SecurityManager method
Looks fine.
Not as part of this fix, but as a future perf. improvement we should
intern (see X509Factory.intern) the X509CertImpl objects that are
created from the contents of the OCSP response, so that they are put in
the certificate memory cache. If the same OCSP responder is used
frequentl
On 10/12/2013 19:20, Phil Race wrote:
> was trusted to bring up a top-level winodw. It no longer has a use
What's a winodw ? :-)
Thanks, I'll fix that.
"It no longer has a use" suggests it does nothing so might be better
phrased as
"no longer the recommended or sole way to perform this chec
> was trusted to bring up a top-level winodw. It no longer has a use
What's a winodw ? :-)
"It no longer has a use" suggests it does nothing so might be better
phrased as
"no longer the recommended or sole way to perform this check and is
superseded by .. "
Is there a CCC for this ? It seem
