RFR 8034762: Move krb5.conf related tests into a single place

2014-02-12 Thread Wang Weijun
Hi All The bug is at https://bugs.openjdk.java.net/browse/JDK-8034762. Basically there is nothing to review. I just move 10 files to a different directory and not a single bit of their contents was changed. They are test/sun/security/krb5/ConfPlusProp.java test/sun/security/krb5/ConfigW

Re: RFR 8034762: Move krb5.conf related tests into a single place

2014-02-12 Thread Xuelei Fan
OK to me to make the changes. Xuelei On 2/12/2014 6:01 PM, Wang Weijun wrote: > Hi All > > The bug is at https://bugs.openjdk.java.net/browse/JDK-8034762. > > Basically there is nothing to review. I just move 10 files to a different > directory and not a single bit of their contents was change

Result: New Security Group Member: Jason Uh

2014-02-12 Thread Sean Mullan
The vote for Jason Uh [1] is now closed. Yes: 5 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. Sean Mullan [1] http://mail.openjdk.java.net/pipermail/security-dev/2014-January/010087.html

[9] Request for Review: 8031025: SQE test CertPath/CertPathBuilderTest/* failed with java.lang.IndexOutOfBoundsException

2014-02-12 Thread Jason Uh
Hi all, Please review this fix for JDK 9, which checks for an empty cert path list in RevocationChecker. webrev: http://cr.openjdk.java.net/~juh/8031025/webrev.01 noreq-sqe, as the fix can be verified with existing SQE tests. Thanks, Jason

Re: [9] Request for Review: 8031025: SQE test CertPath/CertPathBuilderTest/* failed with java.lang.IndexOutOfBoundsException

2014-02-12 Thread Sean Mullan
Looks good. --Sean On 02/12/2014 06:17 PM, Jason Uh wrote: Hi all, Please review this fix for JDK 9, which checks for an empty cert path list in RevocationChecker. webrev: http://cr.openjdk.java.net/~juh/8031025/webrev.01 noreq-sqe, as the fix can be verified with existing SQE tests. Thanks

Re: RFR: 8034033: [parfait] JNI exception pending in share/native/sun/security/krb5/nativeccache.c

2014-02-12 Thread Valerie (Yu-Ching) Peng
Max, Changes look fine. However, I noticed some calls which may throw exceptions but no check is added, e.g. 593 (*env)->SetObjectArrayElement(env, address_list, index, address); BTW, I noticed there are several existing calls to ExceptionOccurred(...) which can be replaced with Ex

Re: RFR: 8034033: [parfait] JNI exception pending in share/native/sun/security/krb5/nativeccache.c

2014-02-12 Thread Wang Weijun
On Feb 13, 2014, at 8:48, Valerie (Yu-Ching) Peng wrote: > Max, > > Changes look fine. > However, I noticed some calls which may throw exceptions but no check is > added, e.g. > > 593 (*env)->SetObjectArrayElement(env, address_list, index, address); That's in a while loop. Maybe par