Re: RFR 8023197: Pre-configured command line options for keytool and jarsigner

On 6/10/2014 2:17 PM, Wang Weijun wrote: >>> 176 st.whitespaceChars(0x00, 0x20); >>> 177 st.wordChars(0x21, 0xFF); >>> I'm not sure of the code above, would you like have to test for >>> none-ASCII characters? >>> >> >>> >> I cannot find any spec on this, but th

Re: RFR: 8039212 SecretKeyBasic.sh needs to avoid NSS libnss3 and libsoftokn3 version mismatches

This looks fine until the NSS issue is resolved. On 10 Jun 2014, at 03:53, Anthony Scarpino wrote: > Hi, > > I need a review to address a failure in the SecretKeyBasic test. If the > libnss3 and libsoftokn3 do not match we skip this test. > > http://cr.openjdk.java.net/~ascarpino/8039212/web

Re: RFR: JDK-8046368

Looks fine to me. Since there is no regression test, please add a "noreg-cleanup" label to the bug. Thanks, Sean On 06/10/2014 02:01 AM, Jamil Nimeh wrote: Hello all, These are some minor clean-up changes in SeedGenerator.java that were found while fixing a different issue. http://cr.openjdk

[9] review request for 8040812: Uninitialised memory in jdk/src/share/native/sun/security/ec/impl/mpi.c

Please review this trivial fix to initialize a local variable before use: Bug: https://bugs.openjdk.java.net/browse/JDK-8040812 Webrev: http://cr.openjdk.java.net/~vinnie/8040812/webrev.00/ Thanks.

Re: [9] review request for 8040812: Uninitialised memory in jdk/src/share/native/sun/security/ec/impl/mpi.c

Looks fine to me. Please add a noreg label to the bug before you push. --Sean On 06/10/2014 09:43 AM, Vincent Ryan wrote: Please review this trivial fix to initialize a local variable before use: Bug: https://bugs.openjdk.java.net/browse/JDK-8040812 Webrev: http://cr.openjdk.java.net/~vinnie/8

Re: [9] review request for 8040812: Uninitialised memory in jdk/src/share/native/sun/security/ec/impl/mpi.c

Thanks. On 10 Jun 2014, at 15:10, Sean Mullan wrote: > Looks fine to me. Please add a noreg label to the bug before you push. > > --Sean > > On 06/10/2014 09:43 AM, Vincent Ryan wrote: >> Please review this trivial fix to initialize a local variable before use: >> >> Bug: https://bugs.openjdk

[9] review request for 8036613: [parfait] JNI exception pending in jdk/src/windows/native/sun/security/provider/WinCAPISeedGenerator.c

Please review this fix to check for a memory allocation failure and clean-up: Bug: https://bugs.openjdk.java.net/browse/JDK-8036613 Webrev: http://cr.openjdk.java.net/~vinnie/8036613/webrev.00/ Thanks.

Re: Webrev request: JDK-8015081

Looks good to me. --Sean On 06/06/2014 06:16 PM, Jamil Nimeh wrote: One more version of this webrev with minor comment changes: http://cr.openjdk.java.net/~ascarpino/8015081/webrev.04 Thanks, --Jamil On 06/04/2014 04:29 PM, Jamil Nimeh wrote: Hello all, This is an update to the webrev for

Re: Webrev request: JDK-8015081

Hi Jamil Sorry I've just read the webrev. If you always throw an NPE after a collectionNullClean() call, isn't it simpler to let the method throw the NPE? Also, Objects.requireNonNull(o, msg) can be used in those "if (o == null)" cases. Thanks Max On Jun 10, 2014, at 23:32, Sean Mullan wrot

Re: Webrev request: JDK-8015081

Hi Max, You're probably right about collectionNullClean/throw question. When I first wrote that method I wasn't sure I'd always throw NPE as a consequent of it returning false, but it ended up working out that way. I'm already reworking a couple tests so I'll take a look at implementing thos

RFR 8046499: nativecache.c prints to stdout in debug build

Hi All Please review the code change at http://cr.openjdk.java.net/~weijun/8046499/webrev.00/ It simply removes all #ifdef DEBUG blocks. They are not really useful but the output pollutes the stdout stream. We can use the sun.security.krb5.debug system property if there are future debug info