On 22/08/2014 09:09, Wang Weijun wrote:
:
Great, this works for me.
But why does it need to be called in a doPrivileged() block? Isn't it only
about JDK-internal classes/resources?
It's a public API so it can be used by anyone. The question about
privileges and limiting them is a good quest
Hi Xuelei,
May I request you to review 1 new test to be added for PKCS12 read
operations. New test are added to address following:
- Implement tests for read operations with PKCS12 keystore.
JDK Issue:***https://bugs.openjdk.java.net/browse/JDK-8048617*
Webrev: http://cr.openjdk.java.net/~tyan
Several comments:
1. openjdk does not like binary files. I would store them in BASE64.
2. You can store a certificate in pkcs12 keystore now, so block at line 153 is
not correct anymore for all pkcs12 keystores. Of course, you can keep it
because all your testing pkcs12 stores should only conta
Hi Vincent / Jason,
Could you please help in reviewing the following test.
Thanks,
Raghu Nair
On 8/12/2014 10:28 AM, raghu k.nair wrote:
Hello,
Please review the tests for sun.security.x509 classes.
These cover tests for GeneralName, GeneralNames, GeneralSubtree,
GeneralSubtrees, IPAddressN
On 25/08/2014 03:03, Wang Weijun wrote:
New webrevs updated
http://cr.openjdk.java.net/~weijun/8055723/core/webrev.00/
Includes modules java.base and security-related modules and the jarsigner
tool
http://cr.openjdk.java.net/~weijun/8055723/client/webrev.00
Includes the java.desktop mo
Hi Michael, Chris and others
We’re working on moving our internal security tests to open idk
repo(Include refactoring effort). Could you please help to review these
tests?
Thanks,
Amanda
On 7/28/14 5:25 PM, Amanda Jiang wrote:
Hi All,
Could you please review 1 new test to be added for Sock
Just a couple of comments:
1. I think the check on lines 106-110 can be done prior to the for loop
on line 94
2. Not specifically related to your fix, but please remove the text
"NameConstraints" or "SubjectAltName" from the exception messages.
DNSNames can be specified in various places in
On 08/25/2014 03:41 PM, Sean Mullan wrote:
Just a couple of comments:
1. I think the check on lines 106-110 can be done prior to the for loop
on line 94
I think that check is actually where it should be because the for loop
on line 94 loops over each component (while the inner loop on line
On 08/25/2014 04:05 PM, Jason Uh wrote:
On 08/25/2014 03:41 PM, Sean Mullan wrote:
Just a couple of comments:
1. I think the check on lines 106-110 can be done prior to the for loop
on line 94
I think that check is actually where it should be because the for loop
on line 94 loops over each
On 08/25/2014 04:14 PM, Sean Mullan wrote:
On 08/25/2014 04:05 PM, Jason Uh wrote:
On 08/25/2014 03:41 PM, Sean Mullan wrote:
Just a couple of comments:
1. I think the check on lines 106-110 can be done prior to the for loop
on line 94
I think that check is actually where it should be be
Hi Michael
Please review the code change at
http://cr.openjdk.java.net/~weijun/8055901/webrev.00/
With this change, the policy tool can generate a file like
grant {
permission jdk.net.NetworkPermission "setOption.SO_FLOW_SLA";
};
Please confirm the grammar is correct.
BTW, I also add som
New webrevs available at
http://cr.openjdk.java.net/~weijun/8055723/client/webrev.01/
http://cr.openjdk.java.net/~weijun/8055723/core/webrev.01/
There are only 2 now. Everything non-client is in core.
Everyone, please do code review quickly because the patch touches too many
files and any
HI Max,
Request your review for backport of bug# JDK-7197159 : accept different
kvno if there no match , to 7u-dev
webrev :
http://cr.openjdk.java.net/~mbankal/7197159/webrev.00/
regression tests :
http://nightsvr.us.oracle.com/export5/users/mbankal/7u80/testing/7197159/JTreport/html/index.h
I was wondering, is it nice to address it in Java compiler to use string
builder for the string "+" operator?
Xuelei
On 8/26/2014 11:28 AM, Wang Weijun wrote:
> New webrevs available at
>
> http://cr.openjdk.java.net/~weijun/8055723/client/webrev.01/
> http://cr.openjdk.java.net/~weijun/805
Change looks good.
Thanks
Max
On Aug 26, 2014, at 12:36, mala bankal wrote:
> HI Max,
>
> Request your review for backport of bug# JDK-7197159 : accept different kvno
> if there no match , to 7u-dev
>
> webrev :
> http://cr.openjdk.java.net/~mbankal/7197159/webrev.00/
>
> regression tests
Hi Vincent,
Could you help in reviewing the following webrev.
Thanks,
Raghu
On 8/4/2014 12:51 PM, raghu k.nair wrote:
Hello ,
Please review the tests for openssl generated certificates and CRLS.
Changes made :
CustomCertificateFactory.java is made thread safe.
Here is the new webrev
Hi Max,
please review again:
http://cr.openjdk.java.net/~tyan/kevin/JDK-8050370/webrev03/
Thanks
Kevin
于 2014/8/25 14:55, Wang Weijun 写道:
lines 76 and 80, useless " " at the end of string.
Otherwise looks fine.
Thanks
Max
On Aug 25, 2014, at 14:41, zaiyao liu wrote:
Hi Max,
Please help
The change looks fine.
If you want me to push it for you, please show me the full comment you want.
Also, are you an openjdk author now? If yes, I can set you as author,
otherwise, you name appears in "Contributed-by".
--Max
On Aug 26, 2014, at 14:21, zaiyao liu wrote:
> Hi Max,
>
> please
18 matches
Mail list logo
