Re: Review request for CR 8049039 Need new tests for sun.securiy.x509 classes

2014-09-18 Thread raghu k.nair
Hi Vincent / Jason, Please find the updated webrev with minor changes like re-using println method , possible NPE fixes etc. http://cr.openjdk.java.net/~rhalade/8049039/webrev.05/ Thanks, Raghu Nair On 9/11/2014 10:28 PM, raghu k.nair wrote: Hi Jason, I have removed those lines from copyr

JDK-8039921: SHA1WithDSA with key > 1024 bits not working

2014-09-18 Thread Atsuhiko Yamanaka
Hi there, We have been developing pure java SSH2 client library named as JSch, and you may know that it has been integrated and used in Eclipse, NetBeans, IntelliJ IDEA, ant, Ivy, JGit, etc. Recently, we have received feed backs that JSch has failed to connect to some sshds on Java8. After some i

JDK-8039921: SHA1WithDSA with key > 1024 bits not working

2014-09-18 Thread Atsuhiko Yamanaka
Hi there, We have been developing pure java SSH2 client library named as JSch, and you may know that it has been integrated and used in Eclipse, NetBeans, IntelliJ IDEA, ant, Ivy, JGit, etc. Recently we have received feed backs that JSch has failed to connect to some sshd on Java8. After some inv

RFR: 8057813: Alterations to jdk_security3 test target

2014-09-18 Thread Seán Coffey
Continuation of the security test target clean up for jdk7u. 7u doesn't have the test groups concept so I had to break down some test targets to explicit directory names. Also found that the javax/xml/crypto was missing for 7u testing. http://cr.openjdk.java.net/~coffeys/webrev.7u.8057813/webr

Re: RFR: 8057813: Alterations to jdk_security3 test target

2014-09-18 Thread Sean Mullan
On 09/18/2014 10:52 AM, Seán Coffey wrote: Continuation of the security test target clean up for jdk7u. 7u doesn't have the test groups concept so I had to break down some test targets to explicit directory names. Also found that the javax/xml/crypto was missing for 7u testing. Good catch, loo

Re: JDK-8039921: SHA1WithDSA with key > 1024 bits not working

2014-09-18 Thread Valerie Peng
Atsuhiko, Back in Java7, SUN provider only supports DSA keys w/ up-to-1024 bit length. The SHA1withDSA signature doesn't explicitly check and reject longer keys though, so I understand how this may be viewed as a regression. At the time when the large DSA key support is added, we followed the

Re: JDK-8039921: SHA1WithDSA with key > 1024 bits not working

2014-09-18 Thread Atsuhiko Yamanaka
Hi, Thank you for your quick response, On Fri, Sep 19, 2014 at 9:04 AM, Valerie Peng wrote: > > Do you have any > more info such as CA certs using large DSA keys with SHA1withDSA signature > algori

Re: JDK-8039921: SHA1WithDSA with key > 1024 bits not working

2014-09-18 Thread Bernd Eckenfels
Hello, I can understand that the PKI Path implementation or SSL engine does need to do some policy decisions. And for this I guess its not really a problem to combine larger RSA with larger hashes (especially as the CAs need to phase them out anyway). But - as the SSH example shows - there are pr

[9] RFR: 8037550: Update RFC references in javadoc to RFC 5280

2014-09-18 Thread Jason Uh
Please review this changeset, which updates references to RFC 3280 to RFC 5280. RFC 5280 has obsoleted 3280. http://cr.openjdk.java.net/~juh/8037550/webrev.03/ Thanks, Jason

Re: [9] RFR: 8037550: Update RFC references in javadoc to RFC 5280

2014-09-18 Thread Wang Weijun
Hi Jason The change looks quite straightforward, but have you checked if our codes actually comply with RFC 5280 especially for those areas where RFC 5280 is different from RFC 3280? http://tools.ietf.org/html/rfc5280#page-5 lists the differences. For example, there is an item: * Section

Re: RFR 8048619: Implement tests for converting PKCS12 keystores

2014-09-18 Thread zaiyao liu
Hi Max, Can you help to review it? Thanks Kevin 于 2014/9/1 13:25, Wang Weijun 写道: On vacation now. Can you look for someone else? I will be back in Sep 17 if you are not in a hurry. --Max On Sep 1, 2014, at 9:37, zaiyao liu wrote: Hi Max, Please review the code change,the purpose of thi