You should change the @since tags to 1.9 since this is its first
inclusion in OpenJDK.
Looks good otherwise.
--Sean
On 10/13/2014 07:54 PM, Valerie Peng wrote:
Hi, Sean,
Could you please review the changes for 8046002: Move Ucrypto to the
open jdk repo?
Once you reviewed it, I will request a
Hi Vincent,
it seems we've stalled on this somewhere.
What do I need to do to have the patch accepted?
regards,
Florian
On 21.08.14 11:28, Vincent Ryan wrote:
Hello Florian,
I can sponsor this changeset and attribute the fix to you.
On 21 Aug 2014, at 09:52, Florian Bruckner (3kraft)
w
I’m the blocker. I’ll try to get your changset pushed by the end of this week.
On 14 Oct 2014, at 13:24, Florian Bruckner (3kraft)
wrote:
> Hi Vincent,
>
> it seems we've stalled on this somewhere.
>
> What do I need to do to have the patch accepted?
>
> regards,
>
> Florian
>
>
> On 21.
Hello all, this is another update to JDK-8032573. This link adds the
JDK 8 backport. It's pretty much the same fix, with the addition of
moving a couple StringBuffers to StringBuilders. I'm also still looking
for a yea/nay on the JDK 9 proposed fix as well.
JDK 9 webrev: http://cr.openjdk.j
Jamil
Both code changes look fine.
One suggestion: you might want to mention that the first character in
invalidcert.pem in the test was "M". It is modified to "X" to be invalid. This
would help maintainers understand where it comes from.
Thanks
Max
On Oct 15, 2014, at 1:42, Jamil Nimeh wrot
Thank you for the reviews and I will go make the comment changes as you
suggest.
--Jamil
On 10/14/2014 7:11 PM, Wang Weijun wrote:
Jamil
Both code changes look fine.
One suggestion: you might want to mention that the first character in invalidcert.pem in the test
was "M". It is modified to
Okay, one more round. This has the comment changes Max asked for and
some additional cleanup of NetBeans warnings in the test code. No
changes were made to X509Factory.java.
JDK 8: http://cr.openjdk.java.net/~ascarpino/8057141/webrev.02
JDK 9: http://cr.openjdk.java.net/~ascarpino/8032573/webr
