OK, I will take a look.
Thanks,
Valerie
On 11/5/2014 10:04 PM, Wang Weijun wrote:
Ping ping...
On Oct 20, 2014, at 13:22, Wang Weijun wrote:
Anyone can take a look?
On Sep 25, 2014, at 18:54, Wang Weijun wrote:
Hi All
Please review the code change at
http://cr.openjdk.java.net/~weijun
Hi,
I need a review of this change to the pkcs11 wrapper code. The changes
allow encryption to work properly when -Xcheck:jni is called. A recent
change to -Xcheck:jni caused the failures to occur.
http://cr.openjdk.java.net/~ascarpino/8063700/webrev/
thanks
Tony
It looks ok to me although I think Valerie should also review it. Is it
possible to add a simple regression test for this and not be dependent
on the JCK tests?
--Sean
On 11/06/2014 05:14 PM, Anthony Scarpino wrote:
Hi,
I need a review of this change to the pkcs11 wrapper code. The changes
It's completely dependent on Xcheck:jni. I figured that was an option
part of the testing process. Not something that one put into a test.
Is that wrong?
Tony
On 11/06/2014 02:37 PM, Sean Mullan wrote:
It looks ok to me although I think Valerie should also review it. Is it
possible to add a
The changes look fine.
Valerie
On 11/6/2014 4:06 PM, Anthony Scarpino wrote:
It's completely dependent on Xcheck:jni. I figured that was an option
part of the testing process. Not something that one put into a test.
Is that wrong?
Tony
On 11/06/2014 02:37 PM, Sean Mullan wrote:
It looks o