> On Nov 11, 2014, at 15:06, Xuelei Fan wrote:
>
> On 11/11/2014 1:31 PM, Wang Weijun wrote:
>> A subclass of Exception would also return true when using instanceof, where
>> I think the class name is still informational.
>>
> Got it. But Exception is still informational as it means it is not
Looks fine to me.
Xuelei
On 11/11/2014 4:54 PM, Wang Weijun wrote:
>
>> On Nov 11, 2014, at 15:06, Xuelei Fan wrote:
>>
>> On 11/11/2014 1:31 PM, Wang Weijun wrote:
>>> A subclass of Exception would also return true when using instanceof, where
>>> I think the class name is still informational
Looks good.
--Sean
On 11/10/2014 04:53 PM, Vincent Ryan wrote:
I’ve updated the fix to reduce the casts to KeyEntry:
http://cr.openjdk.java.net/~vinnie/8046777/webrev.02/
On 10 Nov 2014, at 18:48, Vincent Ryan wrote:
On 10 Nov 2014, at 18:13, Sean Mullan wrote:
You missed one of my
On 11/10/2014 10:33 PM, Xuelei Fan wrote:
Looks fine to me.
A pretty minor comment.
share/classes/javax/xml/crypto/dsig/spec/XPathType.java
---
157 this.expression = expression;
158 this.filter = filter;
159 if (namespaceMap == null) {
160
