Re: RFR 8044500: Add kinit options and krb5.conf flags that allow users to obtain renewable tickets and specify ticket lifetimes

2014-11-17 Thread Wang Weijun
> On Nov 15, 2014, at 09:25, Valerie Peng wrote: > > Max, > > Most looks fine, just some questions. > > - Kinit.java: line 56, it should be "sun.security.krb5.internal.tools.Kinit"? Correct. > - Kinit.java: for the switch block from 135 - 142: add a default case to > catch illegal values?

Result: New Security Group Member: Anthony Scarpino

2014-11-17 Thread Sean Mullan
The vote for Anthony Scarpino [1] is now closed. Yes: 7 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. Sean Mullan [1] http://mail.openjdk.java.net/pipermail/security-dev/2014-November/011378.html

Re: RFR 8044500: Add kinit options and krb5.conf flags that allow users to obtain renewable tickets and specify ticket lifetimes

2014-11-17 Thread Valerie Peng
The default value 0 for the "renew_lifetime" is documented in MIT's Kerberos conf documentation. http://web.mit.edu/kerberos/krb5-devel/doc/admin/conf_files/krb5_conf.html However, I am not sure how this 0 value should be interpreted/handled. Valerie On 11/17/2014 12:23 AM, Wang Weijun wrote:

Re: RFR 8044500: Add kinit options and krb5.conf flags that allow users to obtain renewable tickets and specify ticket lifetimes

2014-11-17 Thread Wang Weijun
> On Nov 18, 2014, at 07:43, Valerie Peng wrote: > > > The default value 0 for the "renew_lifetime" is documented in MIT's Kerberos > conf documentation. > http://web.mit.edu/kerberos/krb5-devel/doc/admin/conf_files/krb5_conf.html > However, I am not sure how this 0 value should be interprete

Re: RFR 8061253: CCC 8043071 doesn't fully approve the change in JDK9b25

2014-11-17 Thread Wang Weijun
Re-request for code review at http://cr.openjdk.java.net/~weijun/8061253/webrev.01/ Most are still spec changes, with only one code change in KerberosTicket.java where KerberosPrincipal.toString() is changed to KerberosPrincipal.getName(). This is also because the spec for getName() is more s