Re: RFR 8044500: Add kinit options and krb5.conf flags that allow users to obtain renewable tickets and specify ticket lifetimes

2014-12-02 Thread Wang Weijun
Are you OK with this difference? Thanks Max > On Nov 18, 2014, at 15:02, Wang Weijun wrote: > > >> On Nov 18, 2014, at 07:43, Valerie Peng wrote: >> >> >> The default value 0 for the "renew_lifetime" is documented in MIT's Kerberos >> conf documentation. >> http://web.mit.edu/kerberos/krb

[9] request for review 8044445: Create PKCS12 Keystores by Default

2014-12-02 Thread Vincent Ryan
Please review the following enhancement to improve keystore security by creating PKCS12 keystores by default. Previously, JKS keystores were created by default. PKCS12 has the advantage of supporting stronger crypto and hashing algorithms. It is also an open, extensible format and supports asso

Re: [9] request for review 8044445: Create PKCS12 Keystores by Default

2014-12-02 Thread Sean Mullan
Comments: * JceKeyStore [906] add @Override to engineProbe method * KeyStore [1615] use @throws instead of @exception. Should probably also add an @throws NullPointerException if keystore is null. You need to define what happens if the File does not exist. You could either throw a KeyStore

Re: RFR 8044500: Add kinit options and krb5.conf flags that allow users to obtain renewable tickets and specify ticket lifetimes

2014-12-02 Thread Valerie Peng
The difference seems minor enough to me. Just wondering, have any one reported/complained about this though? Thanks, Valerie On 12/2/2014 12:21 AM, Wang Weijun wrote: Are you OK with this difference? Thanks Max On Nov 18, 2014, at 15:02, Wang Weijun wrote: On Nov 18, 2014, at 07:43, Vale

Re: RFR 8048619: Implement tests for converting PKCS12 keystores

2014-12-02 Thread zaiyao liu
Hi Max, Please help to review the update: http://cr.openjdk.java.net/~rhalade/8048619/webrev.02/ Thanks Kevin 于 2014/9/23 15:08, zaiyao liu 写道: Hi Max, Please help to check this update:http://sqeweb.us.oracle.com/net/sqenfs-1/export1/comp/jsn/users/kevin1/webrev/8048619/webrev/ Thanks Kevi

Re: RFR JDK-8049432: Need new tests for testing TLS property jdk.tls.client.protocols with various protocols and values

2014-12-02 Thread zaiyao liu
Hi Xuelei, Can you help to review this code change? Thanks and Regards. Kevin 于 2014/9/10 10:29, zaiyao liu 写道: Hi All, Please review the code change,the purpose of this fix is to address following: -Sets the property jdk.tls.client.protocols to one of this protocols:SSLv3,TLSv1,TLSv1,TLSv1

Re: RFR 8048619: Implement tests for converting PKCS12 keystores

2014-12-02 Thread Wang Weijun
Looks fine. One nit, line 231, remove "Certs don't match ". Thanks Max > On Dec 3, 2014, at 10:26, zaiyao liu wrote: > > Hi Max, > > Please help to review the update: > http://cr.openjdk.java.net/~rhalade/8048619/webrev.02/ > > Thanks > Kevin > 于 2014/9/23 15:08, zaiyao liu 写道: >> Hi Max, >>