Re: RFR 8074935: jdk8 keytool doesn't validate pem files for RFC 1421 correctness, as jdk7 did

2015-03-22 Thread Sean Mullan
Looks ok, though the copyright date on BadPem.java is incorrect. --Sean On 03/17/2015 06:02 AM, Wang Weijun wrote: Hi All Please review the code change at http://cr.openjdk.java.net/~weijun/8074935/webrev.00/ In jdk8, we use Base64.getMimeDecoder() to parse PEM-encoded certs and it ignor

Re: JDK 9 RFR of JDK-8075567: Mark intermittently failuring security-libs tests

2015-03-22 Thread Sean Mullan
Looks fine to me, Joe. --Sean On 03/19/2015 09:12 PM, joe darcy wrote: Hello, Per a policy to mark intermittently failing tests (see http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-March/032383.html), please review the changes below to mark two security libs tests as failing intermit

Re: [JDK-9] RFR: 8048618 Tests for PKCS12 write operations

2015-03-22 Thread zaiyao liu
Hi Max, Thanks for review, please check the update: http://cr.openjdk.java.net/~zailiu/8048618/webrev.02/test/java/security/KeyStore/PKCS12/WriteP12Test.java.html Please help to push code after you finished review with following full comments: 8048618: Tests for PKCS12 write operations. Review