Re: Please review CR 8050409: Test for JAAS getPrivateCredentials

2015-06-18 Thread Weijun Wang
Hi Amanda The test looks fine. Thanks Max On 2/26/2015 4:54 AM, Amanda Jiang wrote: Hi All, Could you please review following changeset, which includes one new test to test permission checks with Subject.getPrivateCredentials. Bug: https://bugs.openjdk.java.net/browse/JDK-8050409 Webrev:http

Re: RFR: 8046943: RSA Acceleration

2015-06-18 Thread Anthony Scarpino
On 06/16/2015 07:33 AM, Andrew Haley wrote: On 06/15/2015 05:58 PM, Andrew Haley wrote: 3. I fused squaring and multiplication into a single montgomeryMultiply method. ... I don't agree with fusing them together. I think there should two separate intrinsics. For one, SPARC has a montsqr a

Re: RFR: 8046943: RSA Acceleration

2015-06-18 Thread Andrew Haley
On 06/18/2015 06:00 PM, Anthony Scarpino wrote: > Question, on the hotspot side you said in a previous post this was > C2-only. Was there a reason you don't have it for all? None. It's up for negotiation. What do you want? C1, interp? Andrew.

Re: RFR: 8046943: RSA Acceleration

2015-06-18 Thread Anthony Scarpino
On 06/18/2015 10:07 AM, Andrew Haley wrote: On 06/18/2015 06:00 PM, Anthony Scarpino wrote: Question, on the hotspot side you said in a previous post this was C2-only. Was there a reason you don't have it for all? None. It's up for negotiation. What do you want? C1, interp? Andrew. I'd

Re: RFR 7191662: JCE providers should be located via ServiceLoader

2015-06-18 Thread Sean Mullan
On 06/16/2015 10:40 PM, Valerie Peng wrote: It's to make the runtime configuration of 3rd party PKCS11 provider easier on non-Solaris systems. With this entry, callers can simply do Security.getProvider("SunPKCS11") and then call Provider.configure with their own configuration file. Otherwise, t

Re: RFR: 8046943: RSA Acceleration

2015-06-18 Thread Vladimir Kozlov
Andrew, We have few new rules regarding intrinsics. You need to add private static java method which does range checks because their are not executed in intrinsic code - see squareToLen() implementation, for example. Note, we will rewrite multiplyToLen() too soon. Also method which will be intr

Re: RFR 8087157: PKCS11 provider not instantiated with security manager

2015-06-18 Thread Valerie Peng
Well, the othervm mode is needed not because of the cleanup/disable of SecurityManager, but to ensure that SunPKCS11 provider is created under a SecurityManager. Without the othervm mode, the test will always pass even if the necessary permission is not in java.policy because SunPKCS11 provide

Re: RFR 8087157: PKCS11 provider not instantiated with security manager

2015-06-18 Thread Sean Mullan
On 06/18/2015 05:44 PM, Valerie Peng wrote: Well, the othervm mode is needed not because of the cleanup/disable of SecurityManager, but to ensure that SunPKCS11 provider is created under a SecurityManager. Without the othervm mode, the test will always pass even if the necessary permission is no

RFR: JEP 249 (OCSP Stapling for TLS)

2015-06-18 Thread Jamil Nimeh
Hello all, I have a first cut at the OCSP stapling webrev posted for your review: JEP: https://bugs.openjdk.java.net/browse/JDK-8046321 Webrev: http://cr.openjdk.java.net/~jnimeh/reviews/8046321/webrev.0/ A couple items to note: * I'm in the process of updating the JEP with some more details.

Re: Please review CR 8050409: Test for JAAS getPrivateCredentials

2015-06-18 Thread Amanda Jiang
Max, Thanks for reviewing this, could you please sponsor it? (My JDK author ID is amjiang) Thanks, Amanda On 6/18/15, 2:21 AM, Weijun Wang wrote: Hi Amanda The test looks fine. Thanks Max On 2/26/2015 4:54 AM, Amanda Jiang wrote: Hi All, Could you please review following changeset, whic

Re: RFR: JEP 249 (OCSP Stapling for TLS)

2015-06-18 Thread Xuelei Fan
src/java.base/share/classes/javax/net/ssl/ExtendedSSLSession.java = - * Obtains a {@link List} containing all status responses presented by - * the peer. + * Obtains a {@link List} containing DER-encoded OCSP responses + * (using t