Re: RFR: 8046943: RSA Acceleration

2015-06-19 Thread Andrew Haley
On 18/06/15 20:28, Vladimir Kozlov wrote: > We have few new rules regarding intrinsics. > You need to add private static java method which does range checks > because their are not executed in intrinsic code - see squareToLen() > implementation, for example. Okay. > Note, we will rewrite multi

RFR 8023546: sun/security/mscapi/ShortRSAKey1024.sh fails intermittently

2015-06-19 Thread Weijun Wang
I might have found a reason for SunMSCAPI crash http://cr.openjdk.java.net/~weijun/8023546/webrev.00 Before this fix, the native function convertToLittleEndian() fails if you want to convert a 63 byte array to a 64 byte one. However, I observed that when a 1024 bit RSA private key is generat

Re: RFR: JEP 249 (OCSP Stapling for TLS)

2015-06-19 Thread Jamil Nimeh
Hi Xuelei, those are all good comments. I'll make the changes. Thanks for the quick spec feedback. --Jamil On 6/18/2015 9:21 PM, Xuelei Fan wrote: src/java.base/share/classes/javax/net/ssl/ExtendedSSLSession.java = - * Obtains a

RFR 8098854: Do cleanup in a proper order in mscapi

2015-06-19 Thread Ivan Gerasimov
Hello everyone! The changeset consists of two parts: - checking systematically for NULL result of FindClass() and GetMethodID(), - calling CryptReleaseContext() after CryptDestroyHash(), as it is suggested in MSDN [1]. BUGURL: https://bugs.openjdk.java.net/browse/JDK-8098854 WEBREV: http://cr.

RFR 8050461: Tests for syntax checking of JAAS configuration file

2015-06-19 Thread Amanda Jiang
Hello, Please help to review following changeset, which includes new tests to Verify syntax checking of java.security.auth.login.config file. Bug: https://bugs.openjdk.java.net/browse/JDK-8050461 Webrev: http://cr.openjdk.java.net/~amjiang/8050461/webrev.02/ Thanks, Amanda