Re: [9] RFR(M): 8076112: Add @HotSpotIntrinsicCandidate annotation to indicate methods for which Java Runtime has intrinsics

On 06/29/2015 10:47 PM, John Rose wrote: On Jun 29, 2015, at 10:48 AM, Doug Simon > wrote: As I understand it, part of this change is to split intrinsification into one method that does the checks that then calls a second method which the VM may intrinsify on the

Re: [Update]: JEP 249 (OCSP Stapling for TLS)

src/java.base/share/classes/sun/security/ssl/HandshakeMessage.java == 676 private List encodedResponses = new ArrayList<>(4); 4 may be not the best estimate. Maybe better to make the initialization in the constructor.

RE: [9] RFR: 8075301: Tests for sun.security.krb5.principal system property

Hi Max, Here is the updated webrev link. http://cr.openjdk.java.net/~asmotrak/siba/8075301/webrev.02/ Changes: - More test cases added and due to that there are changes in policy file. [createLoginContext.]. - Combined the jaas configuration to a single file name "jaas.conf". -

Re: [9] RFR: 8075301: Tests for sun.security.krb5.principal system property

Hi Siba The code change looks fine. If you need someone to sponsor the bug and push the changeset, just tell me your openjdk user name (or email if you haven't one yet) and I'll do that for you. Please make sure the changeset passes jcheck first. Thanks Max On 06/30/2015 06:20 PM, Sibabrata

[9] review request for 8130151: Exclude sun/security/provider/SecureRandom/StrongSecureRandom.java from testruns on MacOSX 10.10

Please approve this temporary addition to the ProblemList to exclude a single test on Mac OS X 10.10 only. It is related to the issue being tracked by https://bugs.openjdk.java.net/browse/JDK-8051770 Bug: https://bugs.openjdk.java.net/browse/JD

RFR: 8130150: RSA Acceleration

On 06/29/2015 10:32 AM, Andrew Haley wrote: > On 29/06/15 09:37, Vladimir Kozlov wrote: >> Hi, Andrew >> >> Did you file RFE for this change? 8046943 is JEP. > > No; I will do so. Done. >> typo? "less" -> "more". >> >> + * number of ints in the number is less than this value we do not >> +

Re: [Update]: JEP 249 (OCSP Stapling for TLS)

Hi Jamil, On 06/27/2015 11:06 AM, Jamil Nimeh wrote: Hello all, I've posted an updated webrev based on comments I've received so far: http://cr.openjdk.java.net/~jnimeh/reviews/8046321/webrev.1 I didn't have time to review the tests yet but was able to review most of the code in the other fi

Re: [Update]: JEP 249 (OCSP Stapling for TLS)

Hi Xuelei, I'm working on your comments now. Thanks for all the useful feedback. I'm working on the comments in your other emails, too. On 06/30/2015 02:46 AM, Xuelei Fan wrote: src/java.base/share/classes/sun/security/ssl/HandshakeMessage.java

Re: [Update]: JEP 249 (OCSP Stapling for TLS)

On 06/29/2015 10:29 PM, Xuelei Fan wrote: src/java.base/share/classes/sun/security/ssl/ClientHandshaker.java == minor comment: 1603 if (!staplingActive) { 1604 fatalSE(Alerts.alert_unexpected_message, 1605

Re: [9] review request for 8130151: Exclude sun/security/provider/SecureRandom/StrongSecureRandom.java from testruns on MacOSX 10.10

Looks fine to me. Xuelei On 7/1/2015 1:34 AM, Vincent Ryan wrote: > Please approve this temporary addition to the ProblemList to exclude a > single test on Mac OS X 10.10 only. > It is related to the issue being tracked > by https://bugs.openjdk.java.net/browse/JDK-8051770 > > Bug: https://bugs.

Re: [Update]: JEP 249 (OCSP Stapling for TLS)

On 7/1/2015 6:39 AM, Jamil Nimeh wrote: >> src/java.base/share/classes/sun/security/ssl/HandshakeMessage.java >> == >> line 713/714, 730/731 throws SSLHandshakeException for extension >> constructor in server side. That's unlikely to

Re: [Update]: JEP 249 (OCSP Stapling for TLS)

On 7/1/2015 7:38 AM, Jamil Nimeh wrote: >> src/java.base/share/classes/sun/security/validator/PKIXValidator.java >> = >> minor comment: >> >> Is it more instinctive if changing the parameter name from responseList >> to ocspRespons

Re: [Update]: JEP 249 (OCSP Stapling for TLS)

On 06/30/2015 06:04 PM, Xuelei Fan wrote: On 7/1/2015 6:39 AM, Jamil Nimeh wrote: src/java.base/share/classes/sun/security/ssl/HandshakeMessage.java == line 713/714, 730/731 throws SSLHandshakeException for extension constructor i

Re: [Update]: JEP 249 (OCSP Stapling for TLS)

On 06/30/2015 06:53 PM, Xuelei Fan wrote: On 7/1/2015 7:38 AM, Jamil Nimeh wrote: src/java.base/share/classes/sun/security/validator/PKIXValidator.java = minor comment: Is it more instinctive if changing the parameter name fr

Re: [Update]: JEP 249 (OCSP Stapling for TLS)

On 7/1/2015 10:02 AM, Jamil Nimeh wrote: > > > On 06/30/2015 06:04 PM, Xuelei Fan wrote: >> On 7/1/2015 6:39 AM, Jamil Nimeh wrote: src/java.base/share/classes/sun/security/ssl/HandshakeMessage.java == line 713/714, 73

Re: [Update]: JEP 249 (OCSP Stapling for TLS)

src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java Minor comment: Not necessary, but in order to indicate the initialization, better to set statusResponses variable to null explicitly in the constructor. --- li