Nice catch! Looks fine to me, too.
Thanks,
Xuelei
On 6/10/2016 1:27 PM, Anthony Scarpino wrote:
> Looks fine to me.
>
> Tony
>
>> On Jun 9, 2016, at 9:49 PM, Jamil Nimeh wrote:
>>
>> Hi folks, can I please get a quick review for a very simple javadoc fix in
>> X509KeyManager?
>>
>> Bug: ht
On 06/09/2016 10:32 PM, Mandy Chung wrote:
Hi Claes,
I don’t like the PropertiesWrapper idea. The caller should be
cautious in storing any sensitive information. For the system
properties, these callsites use it in the local scope that I don’t
see any reason and benefit to introduce a wrapper.
On 06/09/2016 04:38 PM, Valerie Peng wrote:
Sean,
Can you please help reviewing this? I suppose we don't need to file CCC
for this, right?
Right, since it was covered in a previous CCC.
There is already an earlier one under 7191662 and this
is just updating comments in java.security file.
B
The changes look fine..
thanks
Tony
On 06/09/2016 06:01 PM, Valerie Peng wrote:
Hi Tony,
Could you please help reviewing this? Solaris crypto team made some
changes in the Ucrypto area since S11.3 which breaks JDK build.
This is the workaround (and some minor clean up) for S11.3. This
incompa
> On Jun 10, 2016, at 4:33 AM, Sean Mullan wrote:
>
> On 06/09/2016 10:32 PM, Mandy Chung wrote:
>> Hi Claes,
>>
>> I don’t like the PropertiesWrapper idea. The caller should be
>> cautious in storing any sensitive information. For the system
>> properties, these callsites use it in the local
Sure, sounds good to me.
Will update the test with your feedback.
Thanks for the review,
Valerie
On 6/9/2016 6:15 PM, Mandy Chung wrote:
On Jun 9, 2016, at 5:26 PM, Valerie Peng wrote:
Webrev updated at: http://cr.openjdk.java.net/~valeriep/8157489/webrev.01
51 if (!pClass.
Sounds good.
Webrev updated at: http://cr.openjdk.java.net/~valeriep/8157881/webrev.01/
Thanks,
Valerie
On 6/10/2016 10:21 AM, Sean Mullan wrote:
On 06/09/2016 04:38 PM, Valerie Peng wrote:
Sean,
Can you please help reviewing this? I suppose we don't need to file CCC
for this, right?
Right,
Webrev updated at: http://cr.openjdk.java.net/~valeriep/8157489/webrev.02.
Thanks,
Valerie
On 6/10/2016 12:43 PM, Valerie Peng wrote:
Sure, sounds good to me.
Will update the test with your feedback.
Thanks for the review,
Valerie
On 6/9/2016 6:15 PM, Mandy Chung wrote:
On Jun 9, 2016, at 5:2
