Re: RFR[9] JDK-8168064: sun/security/ssl/ServerHandshaker/AnonCipherWithWantClientAuth.java failed with "Received fatal alert: handshake_failure"

2016-10-26 Thread John Jiang
Hi Artem, Please take a look at this version: http://cr.openjdk.java.net/~jjiang/8168064/webrev.02/ It set a new Server peer. Best regards, John Jiang On 2016/10/25 1:33, Artem Smotrakov wrote: Hi John, I think it is too late to set parameters for server socket in setServerApplication() bec

Re: Code Review Request JDK-8161106 Improve SSLSocket test template

2016-10-26 Thread Bradford Wetmore
Xuelei, Sorry that I didn't have time to look at this earlier. Why did you create a new file SSLSocketSample.java instead of just updating SSLSocketTemplate.java? Why should I use one vs the other? IMHO, unless there's a good reason to keep both, we should just copy the contents of SSLSocke

Re: Code Review Request JDK-8161106 Improve SSLSocket test template

2016-10-26 Thread Xuelei Fan
The new test case is just a test in order to make sure this approach works in the testing environment. I plan to remove both of the sample and template, and re-org them to a class that can be inherited from. Xuelei > On 27 Oct 2016, at 12:31 AM, Bradford Wetmore > wrote: > > Xuelei, > > So

Re: RFR[9] JDK-8168064: sun/security/ssl/ServerHandshaker/AnonCipherWithWantClientAuth.java failed with "Received fatal alert: handshake_failure"

2016-10-26 Thread Artem Smotrakov
Hi John, Looks good to me, thank you for the update. Artem On 10/26/2016 04:45 AM, John Jiang wrote: Hi Artem, Please take a look at this version: http://cr.openjdk.java.net/~jjiang/8168064/webrev.02/ It set a new Server peer. Best regards, John Jiang On 2016/10/25 1:33, Artem Smotrakov w

Re: Code Review Request JDK-8161106 Improve SSLSocket test template

2016-10-26 Thread Artem Smotrakov
There is SSLTest.java which follows SSLSocketSample.java and can be used by other tests. Artem On 10/26/2016 09:45 AM, Xuelei Fan wrote: The new test case is just a test in order to make sure this approach works in the testing environment. I plan to remove both of the sample and template, a

Code review request, JDK-8168822, Document that algorithm restrictions do not apply to trusted certs

2016-10-26 Thread Xuelei Fan
Hi, Please review the simple fix: http://cr.openjdk.java.net/~xuelei/8168822/webrev/ Algorithm restrictions do not apply to trusted certs as the application or customer has made the decision to trust the "trusted cert". However, this point is not explicit for general developers and users

Re: Code review request, JDK-8168822, Document that algorithm restrictions do not apply to trusted certs

2016-10-26 Thread Wang Weijun
I don't think this applies to jdk.jar.disabledAlgorithms. While the private key algorithm and key size are determined by the certificate, I think they are always checked even if the end-entity cert is trusted (For example, a trusted self-signed cert). Thanks Max On 10/27/2016 8:04 AM, Xuelei

Re: Code review request, JDK-8168822, Document that algorithm restrictions do not apply to trusted certs

2016-10-26 Thread Wang Weijun
One question: I thought for TLS, you check twice. First using jdk.tls.disabledAlgorithms on cipher suites etc, and second using jdk.certpath.disabledAlgorithms on certificates. Why is jdk.tls.disabledAlgorithms applied to cert at all? Thanks Max On 10/27/2016 8:30 AM, Wang Weijun wrote: I do

Re: Code review request, JDK-8168822, Document that algorithm restrictions do not apply to trusted certs

2016-10-26 Thread Xuelei Fan
New webrev: http://cr.openjdk.java.net/~xuelei/8168822/webrev.01/ On 10/27/2016 8:34 AM, Wang Weijun wrote: One question: I thought for TLS, you check twice. First using jdk.tls.disabledAlgorithms on cipher suites etc, and second using jdk.certpath.disabledAlgorithms on certificates. Why is

RFR[9] JDK-8164595: javax/net/ssl/FixingJavadocs/SSLSessionNulls.java fails intermittently with javax.net.ssl.SSLHandshakeException: Remote host terminated the handshake

2016-10-26 Thread John Jiang
Hi, Please review this patch for test javax/net/ssl/FixingJavadocs/SSLSessionNulls.java. It takes advantage of javax/net/ssl/templates/SSLTest.java to fix the intermittent SSLHandshakeException issue. Webrev: http://cr.openjdk.java.net/~jjiang/8164595/webrev.00/ Issue: https://bugs.openjdk.jav