Hi,
Please review the patch for,
JBS: https://bugs.openjdk.java.net/browse/JDK-8168423
Webrev: http://cr.openjdk.java.net/~ssahoo/8168423/webrev.00/
Description:
This webrev address all possible cases for Classloader with SecurityManager
having combination of valid/malformed policy
It looks fine. One question, line 866 of the test you print the stacktrace on a
success, was that intentional?
Tony
> On Dec 1, 2016, at 11:02 AM, Sean Mullan wrote:
>
> I enhanced the test case to test more scenarios where MD5 is either disabled
> via the jdk.tls.disabledAlgorithms or the jd
On 12/2/16 11:41 AM, Anthony Scarpino wrote:
It looks fine. One question, line 866 of the test you print the stacktrace on a
success, was that intentional?
No, good spot, it is leftover from debugging, I'll remove it before I push.
--Sean
Tony
On Dec 1, 2016, at 11:02 AM, Sean Mullan wr
On 11/29/2016 5:22 AM, Sean Mullan wrote:
On 11/27/16 7:43 AM, Xuelei Fan wrote:
On 11/27/2016 6:04 PM, Wang Weijun wrote:
This is not only a test update.
No, I happened to find an implementation issue with the new test, so fix
it altogether. The issue is that the simple validator
(SimpleVal
Hi John,
I don't think we should modify the test to disable a SecurityManager and
then reenable it to avoid a security check -- that seems like a pattern
we should avoid. Have you tried to reorganize this code so that this
setup is done before you initially enable the SecurityManager?
Thanks
Hi Xuelei,
I am not sure how the updates in SimpleValidator relate to the template
for JSSE tests. It might be better to separate those changes if I am not
missing something. This update in SimpleValidator looks okay to me, but
taking into account Sean's comments below, I'll let someone who is
The update looks fine to me.
Xuelei
On 11/29/2016 4:58 PM, Valerie Peng wrote:
Anyone has cycles to review this fix?
Some cipher tests fail when running against unlimited crypto policy due
to hardcoded checks and values.
Changes are straight-forward. However, given the dependency between the
Hi,
I need reviewers for these related bugs:
https://bugs.openjdk.java.net/browse/JDK-8170157
Enable unlimited cryptographic policy by default in OracleJDK
https://bugs.openjdk.java.net/browse/JDK-8169335
Add a crypto policy fallback in case Security Property
'crypto.policy' does not exis
Thanks for the review, Artem.
On 12/2/2016 2:41 PM, Artem Smotrakov wrote:
Hi Xuelei,
I am not sure how the updates in SimpleValidator relate to the template
for JSSE tests.
The certificates generated for the template have the same subject and
issuer for RSA, DSA and EC algorithms. If using t
Hi Xuelei,
Please see inline.
On 12/02/2016 03:53 PM, Xue-Lei Fan wrote:
Let's whether Sean or Weijun can have free cycle for the review of
this part.
Yeah, that would be great.
- Why did you remove Peer and Application interfaces? I think those
interfaces make SSLSocketTemplate more flexib
On 12/2/2016 4:34 PM, Artem Smotrakov wrote:
Hi Xuelei,
Please see inline.
On 12/02/2016 03:53 PM, Xue-Lei Fan wrote:
Let's whether Sean or Weijun can have free cycle for the review of
this part.
Yeah, that would be great.
- Why did you remove Peer and Application interfaces? I think those
Please see inline
On 12/02/2016 05:25 PM, Xue-Lei Fan wrote:
- Why did you remove Peer and Application interfaces? I think those
interfaces make SSLSocketTemplate more flexible since it allows
override
doServerSide/doClientSide logic if necessary - it doesn't seem to be
worse. If there is n
On 12/2/2016 5:53 PM, Artem Smotrakov wrote:
Please see inline
On 12/02/2016 05:25 PM, Xue-Lei Fan wrote:
- Why did you remove Peer and Application interfaces? I think those
interfaces make SSLSocketTemplate more flexible since it allows
override
doServerSide/doClientSide logic if necessary
13 matches
Mail list logo
