Re: RFR release notes for multiple enhancements: krb5, SASL, JAAS, policytool

2017-02-13 Thread Sean Mullan
On 1/19/17 9:20 AM, Weijun Wang wrote: On 01/19/2017 10:45 AM, Weijun Wang wrote: One more: https://bugs.openjdk.java.net/browse/JDK-8173018 (https://bugs.openjdk.java.net/browse/JDK-8076535) Deprecate the com.sun.jarsigner package The `com.sun.jarsigner` package is being deprecated. This

Re: RFR release notes for multiple enhancements: krb5, SASL, JAAS, policytool

2017-02-13 Thread Sean Mullan
On 1/19/17 9:20 AM, Weijun Wang wrote: Another one: https://bugs.openjdk.java.net/browse/JDK-8173035 (https://bugs.openjdk.java.net/browse/JDK-8029904) Remove com.sun.security.auth.callback.DialogCallbackHandler `com.sun.security.auth.callback.DialogCallbackHandler` has been removed in JDK

RFR: 8174837: Add "since=9" to deprecated ContentSigner and ContentSignerParameters classes

2017-02-13 Thread Sean Mullan
Could I get a quick code review for this simple fix for https://bugs.openjdk.java.net/browse/JDK-8174837?: diff --git a/src/jdk.jartool/share/classes/com/sun/jarsigner/ContentSigner.java b/src/jdk.jartool/share/classes/com/sun/jarsigner/ContentSigner.java --- a/src/jdk.jartool/share/classes/c

Re: RFR: 8174837: Add "since=9" to deprecated ContentSigner and ContentSignerParameters classes

2017-02-13 Thread Vincent Ryan
Your fix looks fine. Minor nit with the copyright header in ContentSigner.java: it’s missing a comma after ‘2017’. Thanks. > On 13 Feb 2017, at 16:25, Sean Mullan wrote: > > Could I get a quick code review for this simple fix for > https://bugs.openjdk.java.net/browse/JDK-8174837?: > > diff

[RFR] 8174849: Change SHA1 certpath restrictions

2017-02-13 Thread Anthony Scarpino
Hi, I need a quick review on a simple certpath config change. http://cr.openjdk.java.net/~ascarpino/8174849/webrev/ thanks Tony

Re: [RFR] 8174849: Change SHA1 certpath restrictions

2017-02-13 Thread Sean Mullan
Looks fine. You'll need to add a noreg label to the bug though. --Sean On 2/13/17 4:47 PM, Anthony Scarpino wrote: Hi, I need a quick review on a simple certpath config change. http://cr.openjdk.java.net/~ascarpino/8174849/webrev/ thanks Tony

JDK 9 RFR of JDK-8174887: Problem list javax/net/ssl/DTLS/RespondToRetransmit.java

2017-02-13 Thread Amy Lu
javax/net/ssl/DTLS/RespondToRetransmit.java This test has been observed to fail intermittently with relatively high frequency at macosx (JDK-8169086). Until issue resolved, test should be problem listed for this platform. Also please note that issue originally reported in JDK-8170492. JDK-81

RFR 8168410: Multiple JCK tests are failing due to SecurityException is not thrown.

2017-02-13 Thread Weijun Wang
Please take a review at cr.openjdk.java.net/~weijun/8168410/webrev.00 JDK-8164705 introduced a compatibility layer to make sure that when FilePermission on "/pwd/x" is granted you can still read "x". The compatibility layer has 2 parts: 1. Inside our own default policy provider. 2. Insi

Re: RFR: 8174837: Add "since=9" to deprecated ContentSigner and ContentSignerParameters classes

2017-02-13 Thread Weijun Wang
Change looks fine. Thanks Max On 02/14/2017 12:25 AM, Sean Mullan wrote: Could I get a quick code review for this simple fix for https://bugs.openjdk.java.net/browse/JDK-8174837?: diff --git a/src/jdk.jartool/share/classes/com/sun/jarsigner/ContentSigner.java b/src/jdk.jartool/share/classes/co

Re: JDK 9 RFR of JDK-8174887: Problem list javax/net/ssl/DTLS/RespondToRetransmit.java

2017-02-13 Thread Xuelei Fan
looks fine to me. Thanks! Xuelei > On Feb 13, 2017, at 6:48 PM, Amy Lu wrote: > > javax/net/ssl/DTLS/RespondToRetransmit.java > > This test has been observed to fail intermittently with relatively high > frequency at macosx (JDK-8169086). Until issue resolved, test should be > problem liste

Re: [RFR] 8174849: Change SHA1 certpath restrictions

2017-02-13 Thread Bernd Eckenfels
Hello, The bug does not explain why. I would understand to completely deny SHA1 (I.e. Unconditionally), but allowing it seems strange, especially without a justification. Gruss Bernd -- http://bernd.eckenfels.net On Mon, Feb 13, 2017 at 10:57 PM +0100, "Anthony Scarpino" wrote: