Do we need an unsigned multiplyHigh?

2017-09-25 Thread Andrew Haley
We now have a multiplyHigh intrinsic, but it is signed. Unsigned multiplyHigh is in general a more useful primitive for crypto than signed, and I wonder if we need an intrinsic for that as well. I've looked at cooking up an unsigned multiplyHigh in Java, and I think the fastest way is this:

Re: Do we need an unsigned multiplyHigh?

2017-09-25 Thread Adam Petcher
I agree that an unsigned multiplyHigh would be useful for crypto purposes, and we should consider adding it. Of course, I would much rather have multiply operations that return both 64-bit parts of the result, but that is going to be hard to do well without value types. So it would be nice to h

Re: Do we need an unsigned multiplyHigh?

2017-09-25 Thread Andrew Haley
On 25/09/17 18:21, Adam Petcher wrote: > I agree that an unsigned multiplyHigh would be useful for crypto > purposes, and we should consider adding it. Of course, I would much > rather have multiply operations that return both 64-bit parts of the > result, but that is going to be hard to do well

Re: Patch for JDK-6695402: Jarsigner with multi-byte characters in class names

2017-09-25 Thread Weijun Wang
> On Sep 26, 2017, at 1:11 AM, Philipp Kunz wrote: > > Hi Max > > Thank you for the detailed assistance and I really hope it doesn't annoy you > too much with so many beginner's mistakes. Every little point of yours seems > to be absolutely justified in my point of view. I'm flattered. > >

Re: Patch for JDK-6695402: Jarsigner with multi-byte characters in class names

2017-09-25 Thread Philipp Kunz
Hi Max This time I got it with readAllBytes. Thank you for the hint. Apparently, UTF characters are allowed in source code, particularly in identifiers here, which also has caused the bug. Even if only for sending patches around I changed it and was surprised to see escaping working not only