Re: KDF API review, round 2

2017-11-29 Thread Jamil Nimeh
On 11/28/2017 9:34 AM, Michael StJohns wrote: On 11/28/2017 1:04 AM, Jamil Nimeh wrote: Hi Mike, I know I said you made arguments in favor of specifying the keys up front in init, but I'm still really uncomfortable with this.  It's been bothering me all day.  Comments below: Before I get to

RFR 8165996: PKCS11 using NSS throws an error regarding secmod.db when NSS uses sqlite

2017-11-29 Thread Martin Balao
Hi, I'd like to propose a fix for JDK-8165996 - PKCS11 using NSS throws an error regarding secmod.db when NSS uses sqlite [1]. Webrev01: * http://cr.openjdk.java.net/~akasko/mbalao/8165996.webrev.01/ (browse online) * http://cr.openjdk.java.net/~akasko/mbalao/8165996.webrev.01.zip (download)

Re: RFR: 8186535: Remove deprecated pre-1.2 SecurityManager methods and fields

2017-11-29 Thread Sean Mullan
On 11/28/17 2:41 PM, mandy chung wrote: On 11/22/17 6:37 AM, Sean Mullan wrote: Please review this change to remove the pre-JDK 1.2 SecurityManager methods that have been deprecated since JDK 1.2 and marked for removal in JDK 9. These methods are fragile, error-prone and have been obsolete s

Re: KDF API review, round 2

2017-11-29 Thread Michael StJohns
Hi Jamil et al - I think I finally understand the disconnect here - let me try and work through an explanation from another direction. The TLS 1.3 KDF is NOT HKDF-Expand, it is HKDF-Expand-Label. HKDF-Expand has a calling sequence of HKDF-Expand (Secret, Label, Length).   That results in und

Re: KDF API review, round 2

2017-11-29 Thread Michael StJohns
On 11/29/2017 8:38 AM, Jamil Nimeh wrote: On 11/28/2017 9:34 AM, Michael StJohns wrote: On 11/28/2017 1:04 AM, Jamil Nimeh wrote: Hi Mike, I know I said you made arguments in favor of specifying the keys up front in init, but I'm still really uncomfortable with this.  It's been bothering me

Re: [PATCH] JDK-8190917 : SSL session resumption, through handshake, in SSLEngine is broken for any protocols lesser than TLSv1.2

2017-11-29 Thread Jaikiran Pai
Anyone willing to sponsor/review the patch please? -Jaikiran On 24/11/17 10:52 AM, Jaikiran Pai wrote: As noted in [1], there's a regression in Java 9, where SSL session resumption no longer works for SSL protocols other than TLSv1.2. The code which is responsible for session resumption resid

Tls 1.2 support info

2017-11-29 Thread rgamarra
Hi there. I'd like to ask about TLS 1.2 support in open jdk 1.6 and 1.7. Starting in which version/update is the protocol supported? Is it the client-side default in any version / update? Any reference / link that can be provided will be most helpful. Regaring Oracle's version, I have found: