RFR 8201867: Kerberos keytabs with holes in certain places are parsed incorrectly

2018-04-24 Thread Weijun Wang
Please take a review at http://cr.openjdk.java.net/~weijun/8201867/webrev.00/ When the hole in keytab is right on the 8192 buffer boundary, skip(n) does not return n. I are not sure if I can do something like "while (i < n) i += skip(n)" because skip(n) can return zero and it does not unders

Re: RFR (+CSR) 8201627: Kerberos sequence number issues

2018-04-24 Thread Valerie Peng
Hi Max, Most changes look good. I have only some comments and questions (see below): - InitSecContextToken.java, line 62: bad -> unrecognized? - According to the class javadoc of various Token classes and Kerberos spec, the sequence number is 8-byte integer from header byte 8-15, but java int

Re: RFR (+CSR) 8201627: Kerberos sequence number issues

2018-04-24 Thread Wang Weijun
RFC 4120 5.5.1 has > seq-number > This optional field includes the initial sequence number to be used by the > KRB_PRIV or KRB_SAFE messages when sequence numbers are used to detect > replays. (It may also be used by application specific messages.) When > included in the authenticator, this fie