RE: [RFR] 8205525 : Improve exception messages during manifest parsing of jar archives

Hi Max, I - moved getErrorPosition method to Manifest.java - in read() method, removed "int offset" - in the exception message, I write now " manifest of " ... (without mentioning a manifest name) http://cr.openjdk.java.net/~mbaesken/webrevs/8205525.8/ Best regards, Matthias > --

Re: [RFR] 8205525 : Improve exception messages during manifest parsing of jar archives

Hi Matthias The change looks fine. We can enhance the name if we want to support .SF parsing later. Please revise your CSR and get it approved first. Thanks Max > On Sep 3, 2018, at 10:19 PM, Baesken, Matthias > wrote: > > Hi Max, I > > - moved getErrorPosition method to Manifest.java

RFR 8210338: Better output for GenerationTests.java

Please take a review at http://cr.openjdk.java.net/~weijun/8210338/webrev.00/ This test enhancement adds section breaks and ensures everything written to stdout is flushed asap. With these info we will have a better understanding of when timeout happens in this test and what the best fix (to

Re: RFR 8210338: Better output for GenerationTests.java

Looks fine to me. Xuelei On 9/3/2018 7:50 PM, Weijun Wang wrote: Please take a review at http://cr.openjdk.java.net/~weijun/8210338/webrev.00/ This test enhancement adds section breaks and ensures everything written to stdout is flushed asap. With these info we will have a better underst