On 9/25/2018 11:57 AM, Xuelei Fan wrote:
On 9/25/2018 8:34 AM, Adam Petcher wrote:
There will be nothing provider-dependent in the TLS implementation.
The point of #3 is to say that we should test the TLS implementation
to ensure that it will work with either "EC" provider. The only
require
Hi Valerie
I've updated the CSR to remove the "always canonicalize" choice and now the
default is "true", i.e. the current "smart-canonicalization" behavior. It's
12am here and I'll update the webrev tomorrow.
Thanks
Max
> On Sep 18, 2018, at 8:52 AM, Valerie Peng wrote:
>
> Look fine to me.
Hi Max,
Please review the updated webrev:
http://cr.openjdk.java.net/~jjiang/8209546/webrev.01/
All your comments are addressed, though this test is moved to problem
list for windows due to JDK-8204203.
Best regards,
John Jiang
On 2018/9/25 22:30, Weijun Wang wrote:
Some questions:
1. Do we
Webrev updated at https://cr.openjdk.java.net/~weijun/8210821/webrev.01.
> On Sep 26, 2018, at 11:57 PM, Weijun Wang wrote:
>
> Hi Valerie
>
> I've updated the CSR to remove the "always canonicalize" choice and now the
> default is "true", i.e. the current "smart-canonicalization" behavior. It
Hi John
1. Please add @bug to all tests.
2. Are getLibPath() and findLib() in AutoTest.java really necessary? It looks
like PKCS11Test::getNSSLibDir is doing something similar.
3. Looks like Standard.java is not necessary now. You can just make
KeyToolTest.java a @test and add a @run line ther
On 2018/9/27 10:34, Weijun Wang wrote:
Hi John
1. Please add @bug to all tests.
Which issue should be linked? JDK-8209546?
I suppose @bug should indicate a product issue here.
At least, JDK-8209546 looks have no much association with this test.
2. Are getLibPath() and findLib() in AutoTest.j
> On Sep 27, 2018, at 11:18 AM, [email protected] wrote:
>
> On 2018/9/27 10:34, Weijun Wang wrote:
>> Hi John
>>
>> 1. Please add @bug to all tests.
> Which issue should be linked? JDK-8209546?
> I suppose @bug should indicate a product issue here.
> At least, JDK-8209546 looks have no muc
On 2018/9/27 11:20, Weijun Wang wrote:
On Sep 27, 2018, at 11:18 AM, [email protected] wrote:
On 2018/9/27 10:34, Weijun Wang wrote:
Hi John
1. Please add @bug to all tests.
Which issue should be linked? JDK-8209546?
I suppose @bug should indicate a product issue here.
At least, JDK-820954
But this is not "affected by a bug fix". This is just refactoring.
Maybe any is OK, I just feel uncomfortable that there is no @bug at all.
--Max
> On Sep 27, 2018, at 11:43 AM, [email protected] wrote:
>
> On 2018/9/27 11:20, Weijun Wang wrote:
>>> On Sep 27, 2018, at 11:18 AM, sha.ji...@or
All others accepted.
> 1122 keystore.pkcs12.certProtectionAlgorithm = PBEWithSHA1AndRC2_40
>
> Shouldn't this be named certPbeAlgorithm so that it matches
> certPbeIterationCount? Same comment about keyProtectionAlgorithm.
Unfortunately we already had "keystore.pkcs12.keyProtectionAlgorithm" an
10 matches
Mail list logo
