Re: RFR 6722928: Support SSPI as a native GSS-API provider

2018-11-29 Thread Nico Williams
On Thu, Nov 29, 2018 at 10:00:02AM +0800, Weijun Wang wrote: > > - You're constructing SPNEGO tokens yourself. I'll have to review that > > very carefully. > > I wrapped the outgoing token into NetTokenInit and extracted in incoming > NegTokenTarg. This might fail if there are multiple rounds,

Re: RFR 6722928: Support SSPI as a native GSS-API provider

2018-11-29 Thread Nico Williams
On Thu, Nov 29, 2018 at 10:00:02AM +0800, Weijun Wang wrote: > > - If you can get Legal approval for including / distributing a fork of > > Martin Rex's bridge, you'll get all of the above functionality and > > also acceptor functionality. > > Anyway, one can use his bridge with -Dsun.security

Re: RFR 6913047: SunPKCS11 memory leak

2018-11-29 Thread Martin Balao
Hi Valerie, Webrev.15 * http://cr.openjdk.java.net/~mbalao/webrevs/6913047/6913047.webrev.15/ * http://cr.openjdk.java.net/~mbalao/webrevs/6913047/6913047.webrev.15.zip Property to disable this fix has been renamed to "sun.security.pkcs11.disableKeyExtraction", as requested in the CSR [1]. Th

Re: RFR 8214179: Add groupname info into keytool -list and -genkeypair output

2018-11-29 Thread Sean Mullan
On 11/26/18 8:30 PM, Weijun Wang wrote: Ping On Nov 21, 2018, at 9:56 PM, Weijun Wang wrote: Please take a review at https://cr.openjdk.java.net/~weijun/8214179/webrev.00/ Before this change, `keytool -genkeypair -keyalg EC -groupname brainpoolP256r1` shows Generating -1 bit EC key pa

Re: RFR(S)JDK-8214074: Ghash optimization using AVX instructions

2018-11-29 Thread Anthony Scarpino
[removed core-libs, added security-dev] I'm fine with the jdk changes and solaris-sparc appears to work fine with the existing security and intrinsic tests. I do not feel comfortable reviewing the hotspot changes, so either Vladimir or someone else from the hotspot team would need to look at

Re: RFR 6722928: Support SSPI as a native GSS-API provider

2018-11-29 Thread Weijun Wang
Nowadays whenever we introduce a new security-related property, we are thinking about whether it can also be both a system property and a security property. If so, it can be set "permanently" in conf/security/java.security or "temporarily" as a system property. See https://hg.openjdk.java.net/j

Re: RFR 8214179: Add groupname info into keytool -list and -genkeypair output

2018-11-29 Thread Weijun Wang
Webrev updated at https://cr.openjdk.java.net/~weijun/8214179/webrev.01/ Very glad to remove the change of Resources.java. Thanks Max > On Nov 30, 2018, at 3:36 AM, Sean Mullan wrote: > > On 11/26/18 8:30 PM, Weijun Wang wrote: >> Ping >>> On Nov 21, 2018, at 9:56 PM, Weijun Wang wrote: >>

Re: RFR[12] JDK-8214459: NSS source should be removed

2018-11-29 Thread Valerie Peng
I assume not just the two files, their containing src directory will be removed, right? Valerie On 11/28/2018 10:35 PM, [email protected] wrote: Hi, The NSS 3.16 source in test/jdk/sun/security/pkcs11/nss/src is not needed anymore, so just remove it. diff -r 1d520c376105 test/jdk/sun/se

Re: RFR[12] JDK-8214459: NSS source should be removed

2018-11-29 Thread sha . jiang
Hi Valerie, On 2018/11/30 10:28, Valerie Peng wrote: I assume not just the two files, their containing src directory will be removed, right? Yes. This directory also will be removed. Best regards, John Jiang Valerie On 11/28/2018 10:35 PM, [email protected] wrote: Hi, The NSS 3.16 sou