Re: RFR 6722928: Support SSPI as a native GSS-API provider

Hi Michael, Sorry about the late reply. I've just posted a new webrev at https://cr.openjdk.java.net/~weijun/6722928/webrev.06 Below are my replies to some of your questions. > >>> * Why do you redefine SEC_SUCCESS macro from sspi.h? >> >> Oops, I didn't realized it's a redefinition. I'll

Re: RFR 6722928: Support SSPI as a native GSS-API provider

There is been some time but I've uploaded a new webrev at https://cr.openjdk.java.net/~weijun/6722928/webrev.06 Major changes: 1. No more get expiration time from TGT, accept the one from AcquireCredentialsHandle, which makes GSS_C_INDEFINITE. 2. KRB5_TRACE can be set to any file name. /dev/

Re: [13] RFR JDK-7107615 "scalability bloker in javax.crypto.JceSecurity"

213-217: Previously, the set/get of both verificationResults and verifyingProviders are synchronized. With this update, the get of verificationResults is not out of the set synchronized block, so there is a competition introduced. I think it would be nice to double check the verificationResu

Re: RFR 8220513: Wrapper Key may get deleted when closing sessions in SunPKCS11 crypto provider

Hi Valerie, Thanks for your feedback. Here it is Webrev.02: * http://cr.openjdk.java.net/~mbalao/webrevs/8220513/8220513.webrev.02/ On 4/4/19 7:31 PM, Valerie Peng wrote: > The refList field inside the SessionKeyRef is changed to use LinkedList. > When there is a large number of P11Key objects

Re: [13] RFR JDK-7107615 "scalability bloker in javax.crypto.JceSecurity"

Hi Xuelei, Thanks for the comments. On 4/16/2019 8:58 AM, Xuelei Fan wrote: 213-217: Previously, the set/get of both verificationResults and verifyingProviders are synchronized.  With this update, the get of verificationResults is not out of the set synchronized block, so there is a competit

Re: [13] RFR JDK-7107615 "scalability bloker in javax.crypto.JceSecurity"

On 4/16/2019 2:16 PM, Valerie Peng wrote: Hi Xuelei, Thanks for the comments. On 4/16/2019 8:58 AM, Xuelei Fan wrote: 213-217: Previously, the set/get of both verificationResults and verifyingProviders are synchronized.  With this update, the get of verificationResults is not out of the set

RFR [13] JDK-8216326: SSLSocket stream close() does not close the associated socket

Hi, Could I get the following update reviewed? http://cr.openjdk.java.net/~xuelei/8216326/webrev.00/ Per the Socket specification, the close of the inputstream/outputstream should close the associated socket. The SSLSocketImpl is a sub-class of Socket and does not follow the spec. That's

Re: RFR [13] JDK-8216326: SSLSocket stream close() does not close the associated socket

Hi Xuelei, Besides the double semicolons on 983 and 1149, I think it looks fine. --Jamil On 4/16/2019 4:37 PM, Xuelei Fan wrote: Hi, Could I get the following update reviewed?    http://cr.openjdk.java.net/~xuelei/8216326/webrev.00/ Per the Socket specification, the close of the inputstream

Re: RFR [13] JDK-8216326: SSLSocket stream close() does not close the associated socket

On 4/16/2019 4:51 PM, Jamil Nimeh wrote: Hi Xuelei, Besides the double semicolons on 983 and 1149, I think it looks fine. I will update accordingly. Thanks for the quick review! Xuelei --Jamil On 4/16/2019 4:37 PM, Xuelei Fan wrote: Hi, Could I get the following update reviewed?    http