Re: RFR 6722928: Support SSPI as a native GSS-API provider

2019-06-04 Thread Weijun Wang
> On Jun 4, 2019, at 2:39 PM, Michael Osipov <[email protected]> wrote: > > Am 2019-06-04 um 04:09 schrieb Weijun Wang: >> Rethinking about this. Although this sspi.cpp is included in OpenJDK, it was >> meant to be a pure standalone DLL that has nothing to do with JNI or JVM. >> Adding this

Re: RFR 6722928: Support SSPI as a native GSS-API provider

2019-06-04 Thread Weijun Wang
I uploaded an updated webrev in place. The only changes are: 1. s/SSPI_TRACE/SSPI_BRIDGE_TRACE/ in sspi.cpp 2. Several copyright year updates. 3. Remove one unused import. Thanks, Max > On May 30, 2019, at 11:18 AM, Weijun Wang wrote: > > Here is the latest webrev > > http://cr.openjdk.java

Re: RFR 8211018: Session Resumption without Server-Side State

2019-06-04 Thread sha . jiang
Hi Tony, I have some minor comments on the test. ResumeChecksServer.java 57 static boolean clientCache = false, serverServerless = false; Should "serverServerless" be "serverStateless"? 86 if (st.compareToIgnoreCase("stateless") == 0) { 87 serverServe

Re: RFR 8211018: Session Resumption without Server-Side State

2019-06-04 Thread sha . jiang
ResumeChecksServer.java 57 static boolean clientCache = false, serverServerless = false; Should "serverServerless" be "serverStateless"? 86 if (st.compareToIgnoreCase("stateless") == 0) { 87 serverServerless = true; 88 } 89 st = Syste

Re: RFR 8211018: Session Resumption without Server-Side State

2019-06-04 Thread Anthony Scarpino
On 6/4/19 4:58 AM, [email protected] wrote: Hi Tony, I have some minor comments on the test. ResumeChecksServer.java 57 static boolean clientCache = false, serverServerless = false; Should "serverServerless" be "serverStateless"? 86 if (st.compareToIgnoreCase

Re: RFR 8211018: Session Resumption without Server-Side State

2019-06-04 Thread Xuelei Fan
On 6/4/2019 9:46 AM, Anthony Scarpino wrote: 125 if (secondSession.getCreationTime() > secondStartTime && 126 !clientCache && !serverServerless) { 127 throw new RuntimeException("Session was not reused"); 128 } If the session should be r

RFR [13] JDK-8224829 : AsyncSSLSocketClose.java has timing issue

2019-06-04 Thread Xuelei Fan
Hi, Could I get the following update reviewed? http://cr.openjdk.java.net/~xuelei/8224829/webrev.00/ If using one thread for closing, one thread for writing. Closing and writing threads are synchronized in order to delivery close_notify TLS record. There are could be race between the two

Re: RFR 8211018: Session Resumption without Server-Side State

2019-06-04 Thread Anthony Scarpino
On 6/4/19 10:02 AM, Xuelei Fan wrote: On 6/4/2019 9:46 AM, Anthony Scarpino wrote: 125 if (secondSession.getCreationTime() > secondStartTime && 126 !clientCache && !serverServerless) { 127 throw new RuntimeException("Session was not reused"); 128

[8u-dev] RFA (S): JDK-8210985: Update the default SSL session cache size to 20480

2019-06-04 Thread Hohensee, Paul
Backport JBS issue: https://bugs.openjdk.java.net/browse/JDK-8224769 Backport CSR: https://bugs.openjdk.java.net/browse/JDK-8224770 Original JBS issue: https://bugs.openjdk.java.net/browse/JDK-8210985 Original CSR: https://bugs.openjdk.java.net/browse/JDK-8213577 Original email thread: http://mai

[11u-dev] RFA (S): JDK-8210985: Update the default SSL session cache size to 20480

2019-06-04 Thread Hohensee, Paul
Backport JBS issue: https://bugs.openjdk.java.net/browse/JDK-8224765 Backport CSR: https://bugs.openjdk.java.net/browse/JDK-8224766 Original JBS issue: https://bugs.openjdk.java.net/browse/JDK-8210985 Original email thread: http://mail.openjdk.java.net/pipermail/security-dev/2018-September/018168

RE: [11u] RFR: 8208698: Improved ECC Implementation

2019-06-04 Thread Doerr, Martin
Hi Christoph, looks like quite some manual resolution just because of a small conflicting change in one file. Backport looks good, but please backport it together with JDK-8217344. After that, ECDHKeyAgreement.java should be identical to the jdk13 version. Best regards, Martin > -Original

Re: [11u-dev] RFA (S): JDK-8210985: Update the default SSL session cache size to 20480

2019-06-04 Thread Hohensee, Paul
Add Original CSR: https://bugs.openjdk.java.net/browse/JDK-8213577 On 5/24/19, 9:42 AM, "jdk-updates-dev on behalf of Hohensee, Paul" wrote: Backport JBS issue: https://bugs.openjdk.java.net/browse/JDK-8224765 Backport CSR: https://bugs.openjdk.java.net/browse/JDK-8224766 Or

Re: RFR 8211018: Session Resumption without Server-Side State

2019-06-04 Thread Anthony Scarpino
On 6/4/19 10:02 AM, Xuelei Fan wrote: On 6/4/2019 9:46 AM, Anthony Scarpino wrote: 125 if (secondSession.getCreationTime() > secondStartTime && 126 !clientCache && !serverServerless) { 127 throw new RuntimeException("Session was not reused"); 128

Re: RFR 8211018: Session Resumption without Server-Side State

2019-06-04 Thread sha . jiang
Hi Tony, On 2019/6/5 00:46, Anthony Scarpino wrote: 125 if (secondSession.getCreationTime() > secondStartTime && 126 !clientCache && !serverServerless) { 127 throw new RuntimeException("Session was not reused"); 128 } If the session

Re: RFR 8211018: Session Resumption without Server-Side State

2019-06-04 Thread Xuelei Fan
Hi Tony, There are a lot of pretty good designs in the update, for example, the cooperation of the session timeout and key rotation timeout. My following comments are mainly about the issues I can find. Most of them are minors. On 6/3/2019 5:42 PM, Anthony Scarpino wrote: http://cr.openjd