Re: RFR JDK-8241039, Retire the deprecated SSLSession.getPeerCertificateChain() method

2020-03-16 Thread Alan Bateman
On 16/03/2020 04:25, Xuelei Fan wrote: Hi, Could I get the following update reviewed? Bug: https://bugs.openjdk.java.net/browse/JDK-8241039 CSR: https://bugs.openjdk.java.net/browse/JDK-8241047 webrev: http://cr.openjdk.java.net/~xuelei/8241039/webrev.00/ I see you've created a new issue (and

Re: RFR JDK-8241039, Retire the deprecated SSLSession.getPeerCertificateChain() method

2020-03-16 Thread Daniel Fuchs
Hi Xuelei, HandshakeCompletedEvent.java: typo: 186 "This method has retired, pleaase use the " + Same in SSLSession.java: 303 "This method has retired, pleaase use the " + WRT to the HttpClient code I wonder whether the deprecated method should be kept. On the on

Re: RFR JDK-8241039, Retire the deprecated SSLSession.getPeerCertificateChain() method

2020-03-16 Thread Sean Mullan
302 throw new UnsupportedOperationException( 303 "This method has retired, pleaase use the " + 304 "getPeerCertificates() method instead."); Not sure the word "retired" is the correct term here. It is unusual to see that term with respect to APIs. I would use

Re: RFR JDK-8241039, Retire the deprecated SSLSession.getPeerCertificateChain() method

2020-03-16 Thread Xuelei Fan
Hi Alan, Thanks for the review. All comments look good to me. Here is the update webrev: http://cr.openjdk.java.net/~xuelei/8241039/webrev.01/ HandshakeCompletedEvent.java and SSLSession.java are updated. Thanks, Xuelei On 3/16/2020 12:36 AM, Alan Bateman wrote: On 16/03/2020 04:25, Xue

Re: RFR JDK-8241039, Retire the deprecated SSLSession.getPeerCertificateChain() method

2020-03-16 Thread Xuelei Fan
On 3/16/2020 3:37 AM, Daniel Fuchs wrote: Hi Xuelei, HandshakeCompletedEvent.java: typo:  186 "This method has retired, pleaase use the " + Same in SSLSession.java:  303 "This method has retired, pleaase use the " + I removed the sections per Alan's comment.

Re: RFR JDK-8241039, Retire the deprecated SSLSession.getPeerCertificateChain() method

2020-03-16 Thread Xuelei Fan
Good catch! Updated in the webrev: http://cr.openjdk.java.net/~xuelei/8241039/webrev.01/ Xuelei On 3/16/2020 5:18 AM, Sean Mullan wrote:  302 throw new UnsupportedOperationException(  303 "This method has retired, pleaase use the " +  304 "getPeerCertif

Re: RFR JDK-8241039, Retire the deprecated SSLSession.getPeerCertificateChain() method

2020-03-16 Thread Alan Bateman
On 16/03/2020 16:00, Xuelei Fan wrote: Hi Alan, Thanks for the review.  All comments look good to me.  Here is the update webrev:   http://cr.openjdk.java.net/~xuelei/8241039/webrev.01/ HandshakeCompletedEvent.java and SSLSession.java are updated. Thanks.  One suggestion is to use "The def

Re: RFR JDK-8241039, Retire the deprecated SSLSession.getPeerCertificateChain() method

2020-03-16 Thread Xuelei Fan
I updated the CSR and local code. Thanks, Xuelei On 3/16/2020 10:23 AM, Alan Bateman wrote: On 16/03/2020 16:00, Xuelei Fan wrote: Hi Alan, Thanks for the review.  All comments look good to me.  Here is the update webrev:   http://cr.openjdk.java.net/~xuelei/8241039/webrev.01/ HandshakeC

Re: RFR JDK-8241039, Retire the deprecated SSLSession.getPeerCertificateChain() method

2020-03-16 Thread Sean Mullan
On 3/16/20 12:49 PM, Xuelei Fan wrote: Good catch!  Updated in the webrev: http://cr.openjdk.java.net/~xuelei/8241039/webrev.01/ While you are in there, I was wondering if you can fix the typo in this sentence in HandshakeCompletedEvent: 182 * end-entity certiticate for X509-based ciphe

Re: RFR JDK-8241039, Retire the deprecated SSLSession.getPeerCertificateChain() method

2020-03-16 Thread Xuelei Fan
Updated in my local workspace. I would not update the webrev and CSR unless you want a check. Thanks, Xuelei On 3/16/2020 12:19 PM, Sean Mullan wrote: On 3/16/20 12:49 PM, Xuelei Fan wrote: Good catch!  Updated in the webrev: http://cr.openjdk.java.net/~xuelei/8241039/webrev.01/ While you

Re: RFR JDK-8227024 : Remove the deprecated javax.security.cert APIs

2020-03-16 Thread Paul Stanley
Hi. I believe that you should remove deprecated javax api's. By delaying it, you are pushing the problem into 2022. If they are removed now then it will force developers to use the correct crypto api's, rather than using a mixture which is what's currently happening. The compatibility probl

RFR [15] 8241014: Miscellaneous typos in documentation comments

2020-03-16 Thread Pavel Rappo
Hello, Please review the change for https://bugs.openjdk.java.net/browse/JDK-8241014: http://cr.openjdk.java.net/~prappo/8241014/webrev.00/ This is a documentation cleanup. There are no code changes involved, and the changes in documentation are mostly trivial. The following packages are affe

Re: RFR [15]: 8240684: ProblemList 70 security tests that are failing on Windows due to "Fetch artifact failed"

2020-03-16 Thread Stanislav Smirnov
Looks good to me, thanks for taking care of this Best regards, Stanislav Smirnov > On Mar 6, 2020, at 12:31 PM, Sean Mullan wrote: > > Please review this change to ProblemList 70 security tests while we diagnose > the artifactory issues. > > See https://bugs.openjdk.java.net/browse/JDK-82

Re: RFR [15] 8241014: Miscellaneous typos in documentation comments

2020-03-16 Thread Pavel Rappo
Hi Ivan, Your changes look good to me. Thanks for doing this. I will merge your changes into that patch of mine. 1. One thing that your change highlighted is that use of FQN here: public int read(java.nio.CharBuffer target) throws IOException It's been there for ages, but I believe can now

Re: OpenJDK11u: Backward incompatible behavior

2020-03-16 Thread Kumar Srinivasan
Hi Alexey - I was trying to understand the fix for the "Unexpected number of plaintext bytes” issue. But it appears that the earlier iterations of the webrevs have disappeared, only webrev.5 is available in [1] In the future it would be a good practice, to retain all the webrevs for sometime.