Re: Possible regression in JDK 14 related to SSLSessionContext / SSLSession on the server side

2020-03-31 Thread Norman Maurer
Yes thats about right… if setting to false it works as expected. Bye Norman > On 31. Mar 2020, at 01:50, Jamil Nimeh wrote: > > Hi Norman, > > I've been able to run your test code and I can reproduce it. Interestingly > enough, it appears to happen when > -Djdk.tls.server.enableSessionTic

Re: Possible regression in JDK 14 related to SSLSessionContext / SSLSession on the server side

2020-03-31 Thread Jamil Nimeh
Thanks Norman, I'm going to file a bug on this one.  After playing with it a bit more I found cases where even SSLServerSockets do run into the issue but it doesn't always happen.  Still working on characterizing it. --Jamil On 3/31/2020 7:11 AM, Norman Maurer wrote: Yes thats about right… if

Re: [15] RFR 8172680: Support SHA-3 based Hmac algorithms

2020-03-31 Thread Michael StJohns
Sorry - this one got past me. For PKCS11 - the assignment of mechanism numbers can happen at any time and doesn't necessarily result in a new version of the specification.  In this case, the API won't change, so there's no reason - since the mechanism numbers have been assigned since last May

RFR 8241960: The SHA3 message digests are not thread safe when cloned

2020-03-31 Thread Alexey Bakhtin
Hi All, Please review fix for SHA3 message digests thread safety. Issue reproduced on the JDK11, JDK13 and JDK14 JTREG test is provided in the patch JBS: https://bugs.openjdk.java.net/browse/JDK-8241960 Webrev: https://cr.openjdk.java.net/~abakhtin/8241960/webrev.v0/ Regards Alexey

Re: RFR: 8076999: SunJCE support of password-based encryption scheme 2 params (PBES2) not working

2020-03-31 Thread Valerie Peng
Hi Jamil, I looked at java.security.AlgorithmParameters and need to update my earlier comment below - By convention, each init() is a fresh start and wipes out the effect previous init() calls. But in the current webrev, they seems to apply changes on top of each other. This may not be the r

Re: RFR 8241960: The SHA3 message digests are not thread safe when cloned

2020-03-31 Thread Valerie Peng
Hi Alexey, Good catch, thanks for the report, I will review it. On a first look, it seems that this is more about the clone() method of the SHA-3 impl missed copying/cloning an internal field. Given that this is about SUN provider, I've modified the synopsis accordingly and move the priority

Re: RFR 8239385: KerberosTicket client name refers wrongly to sAMAccountName in AD

2020-03-31 Thread Martin Balao
Hi Max, Thanks for having a look at the CSR. On 3/30/20 11:39 PM, Weijun Wang wrote: > 1. I don't think there is a need to talk about the java.security.krb5.conf > system property, the krb5.conf file name is more popular. > Added a reference to the krb5.conf file in the first place. I wish we

Re: RFR 8239385: KerberosTicket client name refers wrongly to sAMAccountName in AD

2020-03-31 Thread Weijun Wang
> On Apr 1, 2020, at 8:22 AM, Martin Balao wrote: > > Hi Max, > > Thanks for having a look at the CSR. > > On 3/30/20 11:39 PM, Weijun Wang wrote: >> 1. I don't think there is a need to talk about the java.security.krb5.conf >> system property, the krb5.conf file name is more popular. >> >

Re: RFR 8241960: The SHA3 message digests are not thread safe when cloned

2020-03-31 Thread Weijun Wang
> On Apr 1, 2020, at 4:01 AM, Valerie Peng wrote: > > Hi Alexey, > > Good catch, thanks for the report, I will review it. > > On a first look, it seems that this is more about the clone() method of the > SHA-3 impl missed copying/cloning an internal field. > > Given that this is about SUN

Re: RFR 8241960: The SHA3 message digests are not thread safe when cloned

2020-03-31 Thread Valerie Peng
Right, with a closer look, it does require multiple threads to trigger this problem. Valerie On 3/31/2020 6:10 PM, Weijun Wang wrote: On Apr 1, 2020, at 4:01 AM, Valerie Peng wrote: Hi Alexey, Good catch, thanks for the report, I will review it. On a first look, it seems that this is