Re: RFR 8244565: Accept PKCS #8 with version number 1

Hi Max, I saw in the bug description that handling and parsing of the public key will be resolved in a separate enhancement which is fine with me. In addition to relaxing the PKCS8 version check to accept 1, the current webrev does not check for the trailing bytes and its validity. Perhaps w

Re: [15] RFR JDK-8242151 Improve OID mapping and reuse among JDK security providers for aliases registration

Great, thanks much for the thorough review~ Valerie On 5/15/2020 8:57 PM, Weijun Wang wrote: Well done. Everything looks fine to me. --Max On May 16, 2020, at 5:47 AM, Valerie Peng wrote: Hi Max, I have updated the webrev (http://cr.openjdk.java.net/~valeriep/8242151/webrev.05/) to addre

RFR[15] 8245151: jarsigner should not raise duplicate warnings on verification

Hi, I’d like to request a review for - JBS: https://bugs.openjdk.java.net/browse/JDK-8245151 Webrev: https://cr.openjdk.java.net/~hchao/8245151/webrev.00/ The change is to provide a distinct warning for jarsigner -verify command when it detects weak timestamp digest algorithms are used (by -tsa

Re: [15] RFR JDK-8242151 Improve OID mapping and reuse among JDK security providers for aliases registration

Updated again due to the merge with Tony's EdDSA change: http://cr.openjdk.java.net/~valeriep/8242151/webrev.06 Added Ed25519 and Ed448 to KnownOIDs, and rest are just adjustments accordingly. Touched: src/jdk.crypto.ec/share/classes/sun/security/ec/ed/EdDSAParameters.java src/jdk.crypto.ec/

Re: [15] RFR JDK-8242151 Improve OID mapping and reuse among JDK security providers for aliases registration

Still looks fine to me. Thanks, Max > On May 19, 2020, at 5:36 AM, Valerie Peng wrote: > > Updated again due to the merge with Tony's EdDSA change: > > http://cr.openjdk.java.net/~valeriep/8242151/webrev.06 > > Added Ed25519 and Ed448 to KnownOIDs, and rest are just adjustments > accordingly

Re: RFR[15] 8245151: jarsigner should not raise duplicate warnings on verification

Looks fine to me. Thanks, Max > On May 19, 2020, at 4:05 AM, Hai-May Chao wrote: > > Hi, > > I’d like to request a review for - > > JBS: https://bugs.openjdk.java.net/browse/JDK-8245151 > Webrev: https://cr.openjdk.java.net/~hchao/8245151/webrev.00/ > > The change is to provide a distinct w

Re: RFR 8244565: Accept PKCS #8 with version number 1

> On May 19, 2020, at 1:41 AM, Valerie Peng wrote: > > Hi Max, > > I saw in the bug description that handling and parsing of the public key will > be resolved in a separate enhancement which is fine with me. > > In addition to relaxing the PKCS8 version check to accept 1, the current > web