Hello Brent,
Thank you for sponsoring this change.
In the meantime, I triggered the pre-submit GitHub action job to run the
"tier1" tests for a duplicate branch of this PR. That completed
successfully https://github.com/jaikiran/jdk/actions/runs/269960940.
I'll wait for the reviews, before initi
> On Sep 23, 2020, at 2:10 AM, Eric Liu wrote:
>
> Hi Kim,
>
> Sorry for the delay.
>
> This patch removes a redundant string copy in NetworkInterface.c to avoid
> string-truncation
> warning. Other warnings we talked before, which are unable to completely fix
> in different version
> of g
On 24/09/2020 09:59, Kim Barrett wrote:
If possible, my preference would be to avoid the pragma cruft and write the
code in such a way that gcc8/9 without asan doesn't warn, and gcc10 doesn't
warn with or without asan. I've kind of lost track in the discussion of all
the variants whether that's
On Wed, 23 Sep 2020 15:06:55 GMT, Jaikiran Pai wrote:
> Can I please get a review and a sponsor for a fix for
> https://bugs.openjdk.java.net/browse/JDK-8242882?
>
> As noted in that JBS issue, if the size of the Manifest entry in the jar
> happens to be very large (such that it exceeds
> the
On Wed, 23 Sep 2020 23:38:03 GMT, Anthony Scarpino
wrote:
>> This change removes the native elliptic curves library code; as well as, and
>> calls to that code, tests, and files
>> associated with those libraries. The makefiles have been changed to remove
>> from all source builds of the ec c
On Thu, 24 Sep 2020 19:48:45 GMT, Weijun Wang wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> change exception for ec keyagreement
>> fix supportedcurves in SunEC
>
> src/java.base/share/conf/security/java.se
On Thu, 24 Sep 2020 21:15:34 GMT, Anthony Scarpino
wrote:
>> src/java.base/share/conf/security/java.security line 636:
>>
>>> 634: #
>>> 635: jdk.certpath.disabledAlgorithms=MD2, MD5, SHA1 jdkCA & usage
>>> TLSServer, \
>>> 636: RSA keySize < 1024, DSA keySize < 1024, EC keySize < 224
>>
On Thu, 24 Sep 2020 21:37:14 GMT, Weijun Wang wrote:
>> jdk.disabled.namedCurves is commented out and I don't think it's good for
>> every operation disabled algorithms call to
>> check an empty property. The description for the disabledAlgorithm
>> properties say you have to use "include", so
> This change fixes the DER encoding for ECDSA AlgorithmIdentifier to omit the
> parameters field instead of encoding a
> Null tag.
Hai-May Chao has updated the pull request incrementally with one additional
commit since the last revision:
Updated test case to use DerUtils
-
Cha
On Thu, 24 Sep 2020 23:49:08 GMT, Hai-May Chao wrote:
>> This change fixes the DER encoding for ECDSA AlgorithmIdentifier to omit the
>> parameters field instead of encoding a
>> Null tag.
>
> Hai-May Chao has updated the pull request incrementally with one additional
> commit since the last re
On Mon, 21 Sep 2020 21:10:58 GMT, Anthony Scarpino
wrote:
> This change removes the native elliptic curves library code; as well as, and
> calls to that code, tests, and files
> associated with those libraries. The makefiles have been changed to remove
> from all source builds of the ec code.
On Fri, 25 Sep 2020 00:45:09 GMT, Weijun Wang wrote:
>> Hai-May Chao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated test case to use DerUtils
>
> src/java.base/share/classes/sun/security/x509/AlgorithmId.java line 214:
>
>> 212
> This change fixes the DER encoding for ECDSA AlgorithmIdentifier to omit the
> parameters field instead of encoding a
> Null tag.
Hai-May Chao has updated the pull request incrementally with one additional
commit since the last revision:
Added comment for RFC
-
Changes:
- al
13 matches
Mail list logo
