Re: RFR: 8256818: SSLSocket that is never bound or connected leaks socket resources [v2]

2020-11-22 Thread Christoph Langer
> There is a flaw in sun.security.ssl.SSLSocketImpl::close() which leads to > leaking socket resources after JDK-8224829. > > The close method calls duplexCloseOutput() and duplexCloseInput(). In case of > an exception in any of these methods, the call to closeSocket() is bypassed, > and the un

Re: RFR: 8256523: Streamline Java SHA2 implementation

2020-11-22 Thread Aleksey Shipilev
On Fri, 20 Nov 2020 20:05:19 GMT, Valerie Peng wrote: >> Thank you, @valeriepeng. I am not sure what is the review policy for this >> code, should I wait for another reviewer? > > One reviewer is good enough. You can go ahead and integrate. Thanks~ Got it, thanks! - PR: https://gi

Integrated: 8256523: Streamline Java SHA2 implementation

2020-11-22 Thread Aleksey Shipilev
On Wed, 18 Nov 2020 08:29:49 GMT, Aleksey Shipilev wrote: > Current `sun/security/provider/SHA2` implementation is written with lots of > small method invocations on the fastpath in `implCompress0`. Normally it does > not matter much, because compilers are able to inline through it, and then >

Re: RFR: 8256818: SSLSocket that is never bound or connected leaks socket resources [v3]

2020-11-22 Thread Christoph Langer
> There is a flaw in sun.security.ssl.SSLSocketImpl::close() which leads to > leaking socket resources after JDK-8224829. > > The close method calls duplexCloseOutput() and duplexCloseInput(). In case of > an exception in any of these methods, the call to closeSocket() is bypassed, > and the un