Hi!
Kindly review this patch to replace switch statements with switch expressions
(where it makes sense) in the http client modules. The rationale is to improve
readability of the code.
Regards,
Kartik
-
Commit messages:
- Use switch expressions in jdk.internal.net.http and java.ne
> Hi!
> Kindly review this patch to replace switch statements with switch expressions
> (where it makes sense) in the http client modules. The rationale is to
> improve readability of the code.
> Regards,
> Kartik
Kartik Ohri has refreshed the contents of this pull request, and previous
commits
On Wed, 25 Nov 2020 20:24:52 GMT, Sean Mullan wrote:
> There are several infra test failures that were caused by the fix for
> JDK-8202343 (Disable TLS 1.0 and 1.1).
>
> The problem is that
> test/jdk/javax/net/ssl/TLSCommon/interop/JdkProcClient.java is designed to be
> run with different ve
On Fri, 27 Nov 2020 19:40:35 GMT, Weijun Wang wrote:
> There should only be one curve having type BD or PD in CurveDB.java for any
> given length. Here we keep the last one (sect163r2) so there's no behavior
> change.
>
> I tried to search on the net to see if there is a consensus on which cur
In the SunJSSE provider implementation, there are a few non-null check, used
together with "instanceof" check. For such cases, the non-null check is
redundant as it could be covered by the "instanceof" check. This update will
remove the non-null check, like:
- if ((cause != null) && (cause i
> Hello all,
> This change brings in support for certificates with EdDSA keys (both Ed25519
> and Ed448) allowing those signature algorithms to be used both on the
> certificates themselves and used during the handshaking process for messages
> like CertificateVerify, ServerKeyExchange and so fo
On Mon, 30 Nov 2020 18:34:40 GMT, Valerie Peng wrote:
> Based on CurveDB line 141, it seems we uses the first one and discards the
> rest? Are you sure we keep the last one?
> Don't have answers for your questions though.
Before this change both sect163k1 and sect163r2 have "BD" so both will be
On Mon, 30 Nov 2020 19:51:42 GMT, Xue-Lei Andrew Fan wrote:
> In the SunJSSE provider implementation, there are a few non-null check, used
> together with "instanceof" check. For such cases, the non-null check is
> redundant as it could be covered by the "instanceof" check. This update will
On Mon, 30 Nov 2020 20:42:35 GMT, Weijun Wang wrote:
>
>
> > Based on CurveDB line 141, it seems we uses the first one and discards the
> > rest? Are you sure we keep the last one?
> > Don't have answers for your questions though.
>
> Before this change both sect163k1 and sect163r2 have "BD"
On Mon, 30 Nov 2020 21:07:03 GMT, Valerie Peng wrote:
> > > Based on CurveDB line 141, it seems we uses the first one and discards
> > > the rest? Are you sure we keep the last one?
> > > Don't have answers for your questions though.
> >
> >
> > Before this change both sect163k1 and sect163r2
On Mon, 30 Nov 2020 21:31:18 GMT, Weijun Wang wrote:
>>>
>>>
>>> > Based on CurveDB line 141, it seems we uses the first one and discards
>>> > the rest? Are you sure we keep the last one?
>>> > Don't have answers for your questions though.
>>>
>>> Before this change both sect163k1 and sect16
On Fri, 27 Nov 2020 19:40:35 GMT, Weijun Wang wrote:
> There should only be one curve having type BD or PD in CurveDB.java for any
> given length. Here we keep the last one (sect163r2) so there's no behavior
> change.
>
> I tried to search on the net to see if there is a consensus on which cur
On Mon, 30 Nov 2020 19:51:42 GMT, Xue-Lei Andrew Fan wrote:
> In the SunJSSE provider implementation, there are a few non-null check, used
> together with "instanceof" check. For such cases, the non-null check is
> redundant as it could be covered by the "instanceof" check. This update will
On Fri, 27 Nov 2020 19:40:35 GMT, Weijun Wang wrote:
> There should only be one curve having type BD or PD in CurveDB.java for any
> given length. Here we keep the last one (sect163r2) so there's no behavior
> change.
>
> I tried to search on the net to see if there is a consensus on which cur
On Fri, 27 Nov 2020 19:40:35 GMT, Weijun Wang wrote:
> There should only be one curve having type BD or PD in CurveDB.java for any
> given length. Here we keep the last one (sect163r2) so there's no behavior
> change.
>
> I tried to search on the net to see if there is a consensus on which cur
> Could someone please help review this PKCS#11 v3.0 header files update?
>
> Changes are straight-forward as below:
> 1) Updated pkcs11.h, pkcs11f.h, pkcs11t.h to v3.0
> 2) Updated java side w/ the new constants definitions and name/error code
> mappings.
>
> For the native headers, it's a dire
On Wed, 28 Oct 2020 21:35:25 GMT, Valerie Peng wrote:
> Could someone please help review this PKCS#11 v3.0 header files update?
>
> Changes are straight-forward as below:
> 1) Updated pkcs11.h, pkcs11f.h, pkcs11t.h to v3.0
> 2) Updated java side w/ the new constants definitions and name/error co
On Sat, 21 Nov 2020 11:45:42 GMT, Kartik Ohri
wrote:
> Hi!
> Kindly review this patch to replace switch statements with switch expressions
> (where it makes sense) in the http client modules. The rationale is to
> improve readability of the code.
> Regards,
> Kartik
Just a question.
Do we hav
18 matches
Mail list logo
