Re: RFR: 8263069: Exclude some failing tests from security/infra/java/security/cert/CertPathValidator

2021-03-10 Thread Matthias Baesken
On Fri, 5 Mar 2021 08:38:54 GMT, Christoph Langer wrote: > Exclude some failing tests from > security/infra/java/security/cert/CertPathValidator Looks good, thanks! - Marked as reviewed by mbaesken (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/2840

Re: RFR: 8263105: security-libs doclint cleanup [v3]

2021-03-10 Thread Roger Riggs
On Tue, 9 Mar 2021 22:19:28 GMT, Bradford Wetmore wrote: >> Fix various things pointed out by the most recent doclint run in the >> security-libs area. >> >> This is docs only: I will be checking doccheck/doclint, and will be running >> tier1/tier2 tests. Minor spot checks on generated files

Re: RFR: 8263105: security-libs doclint cleanup [v2]

2021-03-10 Thread Roger Riggs
On Tue, 9 Mar 2021 00:56:25 GMT, Bradford Wetmore wrote: >> Fix various things pointed out by the most recent doclint run in the >> security-libs area. >> >> This is docs only: I will be checking doccheck/doclint, and will be running >> tier1/tier2 tests. Minor spot checks on generated files

Integrated: 8262438: sun/security/ssl/SSLLogger/LoggingFormatConsistency.java failed with "SocketException: Socket is closed"

2021-03-10 Thread Evan Whelan
On Fri, 26 Feb 2021 14:28:23 GMT, Evan Whelan wrote: > Hi all, > > Please review my test fix relating to JDK-8262438 > > This patch introduces as Thread.sleep at the start of each iteration which > creates a new test jvm. > This allows the server socket sufficient time to release the previous

Re: RFR: 8263105: security-libs doclint cleanup [v3]

2021-03-10 Thread Iris Clark
On Tue, 9 Mar 2021 22:19:28 GMT, Bradford Wetmore wrote: >> Fix various things pointed out by the most recent doclint run in the >> security-libs area. >> >> This is docs only: I will be checking doccheck/doclint, and will be running >> tier1/tier2 tests. Minor spot checks on generated files

Re: RFR: 8263105: security-libs doclint cleanup [v3]

2021-03-10 Thread Sean Mullan
On Tue, 9 Mar 2021 22:19:28 GMT, Bradford Wetmore wrote: >> Fix various things pointed out by the most recent doclint run in the >> security-libs area. >> >> This is docs only: I will be checking doccheck/doclint, and will be running >> tier1/tier2 tests. Minor spot checks on generated files

Re: RFR: 8263105: security-libs doclint cleanup [v3]

2021-03-10 Thread Bradford Wetmore
On Wed, 10 Mar 2021 14:53:53 GMT, Roger Riggs wrote: >> Bradford Wetmore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> More Codereview Comments > > src/java.base/share/classes/java/security/AllPermission.java line 165: > >> 163: >> 1

Re: RFR: 8263105: security-libs doclint cleanup [v2]

2021-03-10 Thread Bradford Wetmore
On Wed, 10 Mar 2021 15:10:35 GMT, Roger Riggs wrote: >> Bradford Wetmore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Codereview Comment > > src/java.base/share/classes/javax/crypto/SealedObject.java line 425: > >> 423: * Restor

Re: RFR: 8263105: security-libs doclint cleanup [v3]

2021-03-10 Thread Bradford Wetmore
On Wed, 10 Mar 2021 19:02:40 GMT, Sean Mullan wrote: >> Bradford Wetmore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> More Codereview Comments > > src/java.base/share/classes/java/security/PrivilegedActionException.java line > 101: >

Re: RFR: 8255255: Update Apache Santuario (XML Signature) to version 2.2.1 [v8]

2021-03-10 Thread Weijun Wang
> This is a multi-commits PR that upgrades xmldsig to be equivalent to > Santuario 2.2.0. > > The first step is an auto-import. The JDK implementation is removed first and > Santuario code are imported. Some unrelated files (Ex: encryption) are > removed, and package names are renamed to be int

Re: RFR: 8263105: security-libs doclint cleanup [v4]

2021-03-10 Thread Bradford Wetmore
On Mon, 8 Mar 2021 19:50:06 GMT, Bradford Wetmore wrote: >> src/java.base/share/classes/java/security/BasicPermission.java line 497: >> >>> 495: /** >>> 496: * @serialData Default fields. >>> 497: */ >> >> FWIW, this doc comment will be ignored, because it will be superseded by th

Re: RFR: 8263105: security-libs doclint cleanup [v4]

2021-03-10 Thread Bradford Wetmore
> Fix various things pointed out by the most recent doclint run in the > security-libs area. > > This is docs only: I will be checking doccheck/doclint, and will be running > tier1/tier2 tests. Minor spot checks on generated files. Bradford Wetmore has updated the pull request incrementally w

Integrated: 8263105: security-libs doclint cleanup

2021-03-10 Thread Bradford Wetmore
On Sat, 6 Mar 2021 07:31:09 GMT, Bradford Wetmore wrote: > Fix various things pointed out by the most recent doclint run in the > security-libs area. > > This is docs only: I will be checking doccheck/doclint, and will be running > tier1/tier2 tests. Minor spot checks on generated files. Th

RFR: 8252833: Correct "no comment" warnings from javadoc in java.smartcardio module

2021-03-10 Thread Bradford Wetmore
Disable the "missing" target for java.smartcardio from doclint. - Commit messages: - Forgot copyright date update - 8252833: Correct "no comment" warnings from javadoc in java.smartcardio module Changes: https://git.openjdk.java.net/jdk/pull/2930/files Webrev: https://webrevs.ope

Re: RFR: 8252833: Correct "no comment" warnings from javadoc in java.smartcardio module

2021-03-10 Thread Iris Clark
On Thu, 11 Mar 2021 01:13:12 GMT, Bradford Wetmore wrote: > Disable the "missing" target for java.smartcardio from doclint. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2930