On 12/03/2021 5:12 pm, Anton Kozlov wrote:
On Fri, 12 Mar 2021 05:24:10 GMT, David Holmes wrote:
Anton Kozlov has updated the pull request incrementally with one additional
commit since the last revision:
8262903: [macos_aarch64] Thread::current() called on detached thread
src/hotspot/s
SonarCloud actually found this:
Verify this is the index that was intended; it was already set before.
public byte[][] toByteArray() {
byte[][] result = new byte[nameStrings.length][];
for (int i = 0; i < nameStrings.length; i++) {
result[i] = new byte[nameStrin
> Please review the implementation of JEP 391: macOS/AArch64 Port.
>
> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
> windows/aarch64.
>
> Major changes are in:
> * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks
> JDK-8253817, JDK-8253818)
On Tue, 2 Mar 2021 08:12:10 GMT, Anton Kozlov wrote:
>> I wasn't able to replicate JDK-8020753 and JDK-8186286. So will remove these
>> workaround
>> @gerard-ziemski, 8020753 was originally your fix, do you know if it still
>> needed on intel-mac ?
>
> The x86_bsd still carries the workaround
On Thu, 11 Mar 2021 20:28:46 GMT, Stefan Karlsson wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8262903: [macos_aarch64] Thread::current() called on detached thread
>
> Marked as reviewed by stefank (Reviewer).
On Thu, 11 Mar 2021 19:51:19 GMT, Ziyi Luo wrote:
> This is a P2 regression introduced by JDK-8254717.
>
> In `RSAKeyFactory.engineGetKeySpec`, when the key is a RSA key and the
> KeySpec is RSAPrivateKeySpec or RSAPrivateCrtKeySpec. The method behavior is
> described as follow:
>
> X-axis: t
On Thu, 11 Mar 2021 00:06:50 GMT, Weijun Wang wrote:
>> This is a multi-commits PR that upgrades xmldsig to be equivalent to
>> Santuario 2.2.0.
>>
>> The first step is an auto-import. The JDK implementation is removed first
>> and Santuario code are imported. Some unrelated files (Ex: encrypt
On Tue, 9 Mar 2021 16:12:36 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
> SonarCloud actually found this:
> Verify this is the index that was intended; it was already set before.
>
>
> public byte[][] toByteArray() {
> byte[][] result = new byte[nameStrings.length][];
> for (int i = 0; i < nameStrings.length; i++) {
> result[i] = ne
On Fri, 12 Mar 2021 15:39:48 GMT, Weijun Wang wrote:
>> This is a P2 regression introduced by JDK-8254717.
>>
>> In `RSAKeyFactory.engineGetKeySpec`, when the key is a RSA key and the
>> KeySpec is RSAPrivateKeySpec or RSAPrivateCrtKeySpec. The method behavior is
>> described as follow:
>>
>>
> Please review the implementation of JEP 391: macOS/AArch64 Port.
>
> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
> windows/aarch64.
>
> Major changes are in:
> * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks
> JDK-8253817, JDK-8253818)
On Tue, 9 Mar 2021 18:01:11 GMT, Anton Kozlov wrote:
>> src/hotspot/cpu/aarch64/globalDefinitions_aarch64.hpp line 62:
>>
>>> 60:
>>> 61: #if defined(__APPLE__) || defined(_WIN64)
>>> 62: #define R18_RESERVED
>>
>> #define R18_RESERVED true```
>
> We always check for `R18_RESERVED` with `#if(n
On Fri, 12 Mar 2021 09:22:40 GMT, Aleksey Shipilev wrote:
> SonarCloud actually found this:
> Verify this is the index that was intended; it was already set before.
>
>
> public byte[][] toByteArray() {
> byte[][] result = new byte[nameStrings.length][];
> for (int i = 0;
> This PR is to introduce a new random number API for the JDK. The primary API
> is found in RandomGenerator and RandomGeneratorFactory. Further description
> can be found in the JEP https://openjdk.java.net/jeps/356 .
>
> javadoc can be found at
> http://cr.openjdk.java.net/~jlaskey/prng/doc/a
> This is a P2 regression introduced by JDK-8254717.
>
> In `RSAKeyFactory.engineGetKeySpec`, when the key is a RSA key and the
> KeySpec is RSAPrivateKeySpec or RSAPrivateCrtKeySpec. The method behavior is
> described as follow:
>
> X-axis: type of `keySpec`
> Y-axis: type of `key`
>
> Before
On Fri, 12 Mar 2021 15:39:48 GMT, Weijun Wang wrote:
>> This is a P2 regression introduced by JDK-8254717.
>>
>> In `RSAKeyFactory.engineGetKeySpec`, when the key is a RSA key and the
>> KeySpec is RSAPrivateKeySpec or RSAPrivateCrtKeySpec. The method behavior is
>> described as follow:
>>
>>
On Fri, 12 Mar 2021 22:04:35 GMT, Ziyi Luo wrote:
>> My understanding is that the problem here is the 2 `isAssignableFrom` checks
>> are in wrong order. The parent class RSA_PRIV_KEYSPEC_CLS should be checked
>> first.
>>
>> BTW, please add a regression test to the fix. Thanks.
>
> Hi @wangwei
On Thu, 11 Mar 2021 05:47:00 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review the patch which moves `ClassFileInstaller` class to
> `jdk.test.lib.helpers` package?
> to reduce changes in the tests, `ClassFileInstaller` in the default package
> is kept w/ just `main` method that
On Fri, 12 Mar 2021 02:08:09 GMT, Mikhailo Seledtsov
wrote:
>> Hi all,
>>
>> could you please review the patch which moves `ClassFileInstaller` class to
>> `jdk.test.lib.helpers` package?
>> to reduce changes in the tests, `ClassFileInstaller` in the default package
>> is kept w/ just `main`
On Fri, 12 Mar 2021 22:06:40 GMT, Weijun Wang wrote:
>> Hi @wangweij Thanks for your review. As @SalusaSecondus commented,
>> RSAPrivateKeyCrtSpec should be favored over RSAPrivateKeySpec when the
>> PrivateKey is a Crt Key. I just modified our JTreg test to include all four
>> cases described
Hi all,
could you please review this dull patch that replaces `ClassFileInstaller` w/
`jdk.test.lib.helpers.ClassFileInstaller` in all jtreg test descriptions to
ensure we won't get split testlibrary, and removes
`jdk/test/lib/ClassFileInstaller.java` (so it won't be accidentally used).
from J
On Sat, 13 Mar 2021 04:31:31 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review this dull patch that replaces `ClassFileInstaller` w/
> `jdk.test.lib.helpers.ClassFileInstaller` in all jtreg test descriptions to
> ensure we won't get split testlibrary, and removes
> `jdk/test/lib
On Fri, 12 Mar 2021 16:44:38 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
On Sat, 13 Mar 2021 04:31:31 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review this dull patch that replaces `ClassFileInstaller` w/
> `jdk.test.lib.helpers.ClassFileInstaller` in all jtreg test descriptions to
> ensure we won't get split testlibrary, and removes
> `jdk/test/lib
> Hi all,
>
> could you please review this dull patch that replaces `ClassFileInstaller` w/
> `jdk.test.lib.helpers.ClassFileInstaller` in all jtreg test descriptions to
> ensure we won't get split testlibrary, and removes
> `jdk/test/lib/ClassFileInstaller.java` (so it won't be accidentally us
> Hi all,
>
> could you please review this dull patch that replaces `ClassFileInstaller` w/
> `jdk.test.lib.helpers.ClassFileInstaller` in all jtreg test descriptions to
> ensure we won't get split testlibrary, and removes
> `jdk/test/lib/ClassFileInstaller.java` (so it won't be accidentally us
On Sat, 13 Mar 2021 06:16:37 GMT, Ioi Lam wrote:
>> Igor Ignatyev has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request contains one
>> new commit s
On Sat, 13 Mar 2021 06:16:37 GMT, Ioi Lam wrote:
> But I don't understand why this error can happen. It seems like jtreg would
> allow two test cases to interfere with each other.
The root cause seems to be
https://bugs.openjdk.java.net/browse/CODETOOLS-7902847
-
PR: https://git.
28 matches
Mail list logo
