On Thu, 23 Dec 2021 21:06:51 GMT, Valerie Peng wrote:
>> Hmm, this "ADD" case should be covered by existing regression tests. I will
>> take a look. Thanks.
>
> Hmm, existing test does add an alias, the legacyMap.get() would returns null
> upon 'aliasAlg' (type: String). To test this particular
Hello , please review this XXS test adjustment. After 8278344, it has been
commented that better shouldMatch should be used for the adjusted test parsing
output of different OpenSSL versions.
-
Commit messages:
- JDK-8279385
Changes: https://git.openjdk.java.net/jdk/pull/6946/fil
On Mon, 3 Jan 2022 14:52:13 GMT, Matthias Baesken wrote:
> Hello , please review this XXS test adjustment. After 8278344, it has been
> commented that better shouldMatch should be used for the adjusted test
> parsing output of different OpenSSL versions.
Hurray! I see 2022!
-
Ma
On Mon, 3 Jan 2022 08:53:58 GMT, Aleksey Shipilev wrote:
>> Hmm, existing test does add an alias, the legacyMap.get() would returns null
>> upon 'aliasAlg' (type: String). To test this particular scenario, I enhanced
>> existing regression test to re-assign an alias and then check if the
>> re
On Mon, 3 Jan 2022 21:39:49 GMT, Valerie Peng wrote:
>> Ping @valeriepeng ^^^
>
> The test update checks that the alias maps to the right algorithm. However,
> the particular code change covered by this fix is for removing the alias from
> the previous algorithm which is not triggered by the te
> SonarCloud reports:
> A "Map" cannot contain a "String" in a "ServiceKey"
> type.
>
>
> // clean up old alias if present
> Service prevAliasService = legacyMap.get(aliasAlg);
>
>
> Should be `aliasKey`, like other accesses to `legacyMap`. This code is
> introduced by
> [JDK-8276
On Mon, 3 Jan 2022 22:36:32 GMT, Valerie Peng wrote:
>> The test update checks that the alias maps to the right algorithm. However,
>> the particular code change covered by this fix is for removing the alias
>> from the previous algorithm which is not triggered by the test change. Alias
>> is
On Mon, 3 Jan 2022 14:52:13 GMT, Matthias Baesken wrote:
> Hello , please review this XXS test adjustment. After 8278344, it has been
> commented that better shouldMatch should be used for the adjusted test
> parsing output of different OpenSSL versions.
This pull request has now been integra
