Changeset: 5871d7b1673c
Author:coffeys
Date: 2013-04-25 21:12 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5871d7b1673c
8000529: Regression: SimpleDateFormat incorrectly parses dates formatted with Z
and z pattern letters
Reviewed-by: okutsu
! src/share/classes/java/text/
Changeset: c4480e0d9f53
Author:coffeys
Date: 2013-06-06 14:10 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c4480e0d9f53
8000450: Restrict access to com/sun/corba/se/impl package
Reviewed-by: alanb, chegar, lancea
! src/share/lib/security/java.security-linux
! src/share/lib
Changeset: 45a3584bfacf
Author:coffeys
Date: 2013-06-14 15:14 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/45a3584bfacf
8015978: Incorrect transformation of XPath expression "string(-0)"
Reviewed-by: darcy, joehw
Contributed-by: aleksej.efi...@oracle.com
+ test/javax/xml/j
Changeset: 659828443145
Author:coffeys
Date: 2013-06-14 15:14 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/659828443145
8015978: Incorrect transformation of XPath expression "string(-0)"
Reviewed-by: darcy, joehw
Contributed-by: aleksej.efi...@oracle.com
! src/com/sun/org
Changeset: 83c2976ef8ee
Author:coffeys
Date: 2013-07-09 16:00 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/83c2976ef8ee
8019979: Replace CheckPackageAccess test with better one from closed repo
Reviewed-by: mullan
! test/java/lang/SecurityManager/CheckPackageAccess.java
Changeset: 7cc35dd1885d
Author:coffeys
Date: 2013-07-15 13:42 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7cc35dd1885d
8017566: Backout 8000450 - Cannot access to com.sun.corba.se.impl.orb.ORBImpl
Reviewed-by: mchung
! src/share/lib/security/java.security-linux
! src/shar
Changeset: 92a66af7f834
Author:igerasim
Date: 2013-08-26 18:26 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/92a66af7f834
8016018: Typo in AbstractStringBuilder#indexOf and #lastIndexOf descriptions
Reviewed-by: alanb, chegar
! src/share/classes/java/lang/AbstractStringBuil
Changeset: 5920155dd080
Author:coffeys
Date: 2013-09-03 22:37 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5920155dd080
8017195: Introduce option to setKeepAlive parameter on CORBA sockets
Reviewed-by: chegar, msheppar
+ test/com/sun/corba/transport/KeepAliveSockets.java
Changeset: af8e5bc3a150
Author:coffeys
Date: 2013-09-03 22:35 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/af8e5bc3a150
8017195: Introduce option to setKeepAlive parameter on CORBA sockets
Reviewed-by: chegar, msheppar
!
src/share/classes/com/sun/corba/se/impl/transport
Changeset: 368172cb6dc5
Author:coffeys
Date: 2013-10-02 09:21 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/368172cb6dc5
8024952: ClassCastException in PlainSocketImpl.accept() when using custom
socketImpl
Reviewed-by: chegar
! src/windows/classes/java/net/PlainSocketImpl.
Changeset: 60e3cdbe8cdf
Author:aefimov
Date: 2013-10-13 14:19 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/60e3cdbe8cdf
8025255: (tz) Support tzdata2013g
Reviewed-by: okutsu, mfang
! make/sun/javazic/tzdata/VERSION
! make/sun/javazic/tzdata/africa
! make/sun/javazic/tzdata
Changeset: 2af3f5a61322
Author:coffeys
Date: 2013-10-23 16:53 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2af3f5a61322
5036554: unmarshal error on CORBA alias type in CORBA any
Reviewed-by: chegar, smarks
+ test/com/sun/corba/5036554/JavaBug.java
+ test/com/sun/corba/5036
Changeset: a90e9efa4264
Author:coffeys
Date: 2013-10-23 16:45 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/a90e9efa4264
5036554: unmarshal error on CORBA alias type in CORBA any
Reviewed-by: chegar, smarks
! src/share/classes/com/sun/corba/se/impl/corba/AnyImpl.java
Changeset: ee7f1c78bec7
Author:coffeys
Date: 2013-10-23 20:51 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ee7f1c78bec7
8026405: javax/xml/ws/clientjar/TestWsImport.java failing on JDK 8 nightly
aurora test runs
Reviewed-by: chegar
! test/javax/xml/ws/clientjar/TestWsImpo
Changeset: d34c5e860d5f
Author:aefimov
Date: 2013-10-24 17:23 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d34c5e860d5f
8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing
Reviewed-by: okutsu, mfang, alanb
! test/ProblemList.txt
! test/sun/util/resources/Time
Changeset: d1bb85f0a45a
Author:coffeys
Date: 2013-11-19 14:47 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d1bb85f0a45a
8028583: Add helper methods to test libraries
Reviewed-by: chegar
! test/java/rmi/testlibrary/TestLibrary.java
! test/lib/testlibrary/jdk/testlibrary/Fil
Changeset: f2ccd3530476
Author:coffeys
Date: 2013-11-19 16:22 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f2ccd3530476
8016728: TEST_BUG:
test/java/rmi/transport/closeServerSocket/CloseServerSocket.java failing
intermittently
Reviewed-by: chegar
! test/java/rmi/transpor
Changeset: cd56de5896b4
Author:aefimov
Date: 2013-11-15 15:06 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cd56de5896b4
8027848: The ZoneInfoFile doesn't honor future GMT offset changes
Reviewed-by: sherman, coffeys
! src/share/classes/sun/util/calendar/ZoneInfoFile.java
Changeset: 0f1332dd805c
Author:coffeys
Date: 2013-12-04 17:03 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0f1332dd805c
8029347: sun/rmi/runtime/Log/checkLogging/CheckLogging.java fails in nightly
intermittently
Reviewed-by: alanb
! test/sun/rmi/runtime/Log/checkLogging/C
Changeset: 5ca1b4c282b8
Author:ssides
Date: 2013-12-23 18:42 +
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/5ca1b4c282b8
8029231: Update copyright years for files in corba repository for 2013
Reviewed-by: mchung, coffeys
! src/share/classes/com/sun/corba/se/impl/io/IIOPInp
Changeset: 46c727d6ecc2
Author:aefimov
Date: 2013-12-30 16:46 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/46c727d6ecc2
8025051: Update resource files for TimeZone display names
Reviewed-by: okutsu, mfang
! src/share/classes/sun/util/resources/de/TimeZoneNames_de.java
! sr
Changeset: 0683ee308085
Author:coffeys
Date: 2014-02-26 23:04 +
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/0683ee308085
8035618: Four api/org_omg/CORBA TCK tests fail under plugin only
Reviewed-by: mchung, chegar
! src/share/classes/com/sun/corba/se/spi/orb/ORB.java
Changeset: 426e5f2dbea3
Author:coffeys
Date: 2010-10-18 18:04 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/426e5f2dbea3
6974104: TEST: sun/nio/ch/6645197.java should be fixed in 1.5.0u25b05 and jdk6
workspace
Reviewed-by: alanb
+ test/java/nio/channels/Selector/TemporaryS
Changeset: aed81a97aae3
Author:coffeys
Date: 2010-11-05 13:52 +
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/aed81a97aae3
6696028: JMXServiceURL like service:jmx:rmi:///jndi/iiop:// should be rejected
by the RMI conn provider.
6984520: NPE IN RMIConnector.connect
Reviewed-by
Changeset: 5de001f5f8b4
Author:coffeys
Date: 2010-11-05 17:15 +
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5de001f5f8b4
6957378: JMX memory leak
Reviewed-by: emcmanus, kevinw
! src/share/classes/com/sun/jmx/remote/internal/ServerNotifForwarder.java
+ test/javax/management/
Changeset: 43ae1a1cc7a4
Author:coffeys
Date: 2010-12-10 15:11 +
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/43ae1a1cc7a4
6998583: NativeSeedGenerator is making 8192 byte read requests from entropy
pool on each init.
Reviewed-by: wetmore, andrew, vinnie
! src/share/classes/
Changeset: dff9b6d18628
Author:coffeys
Date: 2011-02-03 11:28 +
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/dff9b6d18628
7016897: Copyright header correction :
test/sun/security/provider/SeedGenerator/SeedGeneratorChoice.java
Reviewed-by: vinnie
! test/sun/security/provide
Changeset: 732faed56eb0
Author:coffeys
Date: 2011-03-03 16:51 +
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/732faed56eb0
6750362: Very large LDAP requests throw a OOM on LDAP servers which aren't
aware of Paged Results Controls
6748156: add an new JNDI property to control t
Changeset: 339342f311cc
Author:coffeys
Date: 2011-03-07 14:43 +
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/339342f311cc
7025105: TEST_BUG test/com/sun/jndi/ldap/NoWaitForReplyTest.java should be
cleaned up
Reviewed-by: alanb
! test/com/sun/jndi/ldap/NoWaitForReplyTest.jav
Changeset: 48f659a09ed4
Author:coffeys
Date: 2011-04-22 11:03 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/48f659a09ed4
7025227: SSLSocketImpl does not close the TCP layer socket if a close notify
cannot be sent to the peer
6932403: SSLSocketImpl state issue
Reviewed-by: x
Changeset: 08fdfdb19ad6
Author:coffeys
Date: 2011-06-14 18:05 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/08fdfdb19ad6
7049774: UID construction appears to hang if time changed backwards
Reviewed-by: alanb, dholmes, chegar, mduigou
! src/share/classes/java/rmi/server/UID.
Changeset: e88093d75e36
Author:coffeys
Date: 2011-07-05 15:25 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e88093d75e36
7041125: LDAP API does not catch malformed filters that contain two operands
for the ! operator
Reviewed-by: weijun, xuelei
! src/share/classes/com/sun/
Changeset: ddcb874581eb
Author:coffeys
Date: 2011-08-11 12:40 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ddcb874581eb
7047325: Internal API to improve management of direct buffers
Reviewed-by: alanb, mduigou
! make/com/oracle/Makefile
- make/com/oracle/net/Makefile
! mak
Changeset: 3a13b7ab57f7
Author:coffeys
Date: 2011-08-26 10:47 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3a13b7ab57f7
7024697: SessionRef.dispose() should determine if the token referred to by the
token object is still valid
Reviewed-by: valeriep
! src/share/classes/sun
Changeset: 946e3b786d2d
Author:coffeys
Date: 2011-09-05 11:28 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/946e3b786d2d
7049079: NTSYSTEM CLASS IS LEAKING WINDOWS TOKENS
Reviewed-by: weijun
! src/share/classes/com/sun/security/auth/module/NTSystem.java
! src/windows/native
Changeset: e0c1282a0ead
Author:coffeys
Date: 2011-09-13 11:21 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e0c1282a0ead
7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file
descriptor be closed when still in use
Reviewed-by: alanb
! src/share/classes/java
Changeset: 64ccf18bbad5
Author:coffeys
Date: 2011-10-27 10:32 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/64ccf18bbad5
7099658: Properties.loadFromXML fails with ClassCastException
Reviewed-by: alanb, mchung
! src/share/classes/sun/util/xml/XMLUtils.java
Changeset: 9dd994f319ee
Author:coffeys
Date: 2011-11-11 10:08 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9dd994f319ee
7105952: Improve finalisation for
FileInputStream/FileOutputStream/RandomAccessFile
Reviewed-by: alanb
! src/share/classes/java/io/FileInputStream.java
Changeset: 44c269731425
Author:coffeys
Date: 2011-11-11 10:16 +
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/44c269731425
7091388: Regular unexplained npe's from corba libs after system has been
running for days
Reviewed-by: alanb
! src/share/classes/com/sun/corba/se/impl
Changeset: d27f0b2f1476
Author:coffeys
Date: 2011-11-23 14:55 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d27f0b2f1476
7102369: remove java.rmi.server.codebase property parsing from registyimpl
7094468: rmiregistry clean up
Reviewed-by: smarks
! src/share/classes/sun/rmi/
Changeset: a589a8dbde79
Author:coffeys
Date: 2012-02-24 09:10 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a589a8dbde79
7133138: Improve io performance around timezone lookups
Reviewed-by: okutsu
! make/tools/src/build/tools/javazic/Mappings.java
! src/share/classes/sun/ut
Changeset: 0a350fb8b174
Author:coffeys
Date: 2012-02-24 09:17 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0a350fb8b174
7144488: Infinite recursion for some equals tests in Collections
Reviewed-by: alanb, dholmes, mduigou
! src/share/classes/java/util/Collections.java
+ te
Changeset: 134d9f4f9498
Author:coffeys
Date: 2012-03-12 11:30 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/134d9f4f9498
7148584: Jar tools fails to generate manifest correctly when boundary condition
hit
Reviewed-by: alanb, sherman
! src/share/classes/java/util/jar/Manife
Changeset: 6bbafa8404eb
Author:coffeys
Date: 2012-03-13 11:01 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6bbafa8404eb
7149608: Default TZ detection fails on linux when symbolic links to non default
location used.
Reviewed-by: alanb, okutsu
! src/solaris/native/java/util
Changeset: 9cdcc0152526
Author:coffeys
Date: 2012-04-20 17:34 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/9cdcc0152526
7161925: sjava files in corba don't have copyright string and legal notice
Reviewed-by: chegar
Contributed-by: misha.by...@oracle.com
! src/share/class
Changeset: fdf5e15293e6
Author:coffeys
Date: 2012-05-10 10:45 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fdf5e15293e6
7163470: Build fails if javax.crypto src files not present
Reviewed-by: valeriep
! make/com/oracle/security/ucrypto/Makefile
! make/common/shared/Defs-ja
Changeset: 3e83229a3779
Author:coffeys
Date: 2012-05-11 10:09 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3e83229a3779
7167359: (tz) SEGV on solaris if TZ variable not set
Reviewed-by: okutsu
! src/solaris/native/java/util/TimeZone_md.c
Changeset: 00c9d6cce3ec
Author:coffeys
Date: 2012-06-15 14:16 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/00c9d6cce3ec
7156963: Incorrect copyright header in java/io/SerialCallbackContext
Reviewed-by: weijun, coffeys
Contributed-by: edvard.wende...@oracle.com
! src/share/
Changeset: 612e56cf284c
Author:coffeys
Date: 2012-06-27 21:10 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/612e56cf284c
6893617: JDK 6 CNCtx always uses the default ORB
Reviewed-by: lancea
! src/share/classes/com/sun/jndi/cosnaming/CNCtx.java
Changeset: 47adb42076f1
Author:coffeys
Date: 2012-06-27 21:09 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/47adb42076f1
7162902: Umbrella port of a number of corba bug fixes from JDK 6 to jdk7u/8
Reviewed-by: lancea
! src/share/classes/com/sun/corba/se/impl/encoding/Cach
Changeset: 35fec642fd32
Author:coffeys
Date: 2012-07-26 22:00 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/35fec642fd32
7179879: SSLSocket connect times out instead of throwing socket closed exception
Reviewed-by: xuelei, chegar
! src/share/classes/sun/security/ssl/SSLSock
Changeset: 39b01268b845
Author:coffeys
Date: 2012-08-16 10:35 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/39b01268b845
7056731: Race condition in CORBA code causes re-use of ABORTed connections
Reviewed-by: lancea
Contributed-by: d.macdon...@auckland.ac.nz
! test/Makefile
Changeset: 18a02ad8dc73
Author:coffeys
Date: 2012-08-16 10:33 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/18a02ad8dc73
7056731: Race condition in CORBA code causes re-use of ABORTed connections
Reviewed-by: lancea
Contributed-by: d.macdon...@auckland.ac.nz
!
src/share/
Changeset: 56d8756749bd
Author:coffeys
Date: 2012-08-16 10:48 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/56d8756749bd
7185965: Build error in javadoc make stage for bundles not containing crypto
package
Reviewed-by: chegar
! make/common/shared/Defs-java.gmk
Changeset: da1436b21bc2
Author:coffeys
Date: 2012-08-31 12:25 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/da1436b21bc2
7195063: [TEST] jtreg flags com/sun/corba/cachedSocket/7056731.sh with Error
failure.
Reviewed-by: chegar
! test/com/sun/corba/cachedSocket/7056731.sh
Changeset: fffbb33df102
Author:coffeys
Date: 2012-09-07 21:22 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fffbb33df102
7180362: RFE: Implement date cutover functionality for currency.properties file
Reviewed-by: naoto
! src/share/classes/java/util/Currency.java
! test/jav
Changeset: fecba6a8b78e
Author:coffeys
Date: 2012-10-09 12:50 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fecba6a8b78e
7196533: TimeZone.getDefault() slow due to synchronization bottleneck
Reviewed-by: okutsu
! src/share/classes/java/util/TimeZone.java
Changeset: 71de5e31d497
Author:coffeys
Date: 2012-10-09 19:45 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/71de5e31d497
7181793: Socket getOutputStream create streams that cannot be GC'ed until
Socket is closed
Reviewed-by: alanb, chegar
! src/share/classes/java/net/Abstr
Changeset: 679e8ad9874f
Author:coffeys
Date: 2012-10-09 20:14 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/679e8ad9874f
7196086: update copyright years for files in corba repository (JDK 8)
Reviewed-by: lancea
! make/common/Defs-bsd.gmk
! make/common/internal/Resources.g
Changeset: 885bb24f6018
Author:coffeys
Date: 2013-02-19 14:07 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/885bb24f6018
7197187: Currency.isPastCutoverDate should be made more robust
Reviewed-by: alanb
! src/share/classes/java/util/Currency.java
Changeset: 01b6b0dd2006
Au
Continuation of RFR thread from
http://mail.openjdk.java.net/pipermail/security-dev/2020-August/022373.html
CSR has been approved.
-
Commit messages:
- JDK-8250968
Changes: https://git.openjdk.java.net/jdk/pull/56/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=56&ran
> Continuation of RFR thread from
> http://mail.openjdk.java.net/pipermail/security-dev/2020-August/022373.html
>
> CSR has been approved.
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
Copyright and t
On Mon, 7 Sep 2020 13:48:57 GMT, Sean Coffey wrote:
> Continuation of RFR thread from
> http://mail.openjdk.java.net/pipermail/security-dev/2020-August/022373.html
>
> CSR has been approved.
This pull request has now been integrated.
Changeset: 7686e871
Author: Sean
Looks fine. Approved for jdk8u-dev.
regards,
Sean.
On 08/07/2016 18:04, Ivan Gerasimov wrote:
Hello!
I'd like to backport this fix into jdk8u-dev.
The fix is essentially the same as in jdk9, but could not be used
verbatim because of the code derivation.
Bug: https://bugs.openjdk.java.net/br
rypto.policy=crypto.policydir-tbd." Does that work for you?
> Instead of throwing an exception here, I wonder if it would make more
> sense to assume a default value of "limited" if the property is not
> set or is empty.
We could, but see above.
Sean Coffey wrote:
&g
On Sat, 12 Mar 2022 00:55:07 GMT, Bradford Wetmore wrote:
> JDK-8253368 changed the behavior of SSLSocket to no longer throw a fatal
> internal_error (80) and invalidate existing sessions (either completed or
> under construction) as described in (RFC 4346/TLSv1.1+) if a connection was
> close
On Tue, 22 Mar 2022 00:24:41 GMT, Bradford Wetmore wrote:
>> test/jdk/sun/security/ssl/SSLSocketImpl/SSLSocketSSLEngineCloseInbound.java
>> line 130:
>>
>>> 128: * The following is to set up the keystores/trust material.
>>> 129: */
>>> 130: private static final String pathToStore
On Sat, 12 Mar 2022 00:55:07 GMT, Bradford Wetmore wrote:
> JDK-8253368 changed the behavior of SSLSocket to no longer throw a fatal
> internal_error (80) and invalidate existing sessions (either completed or
> under construction) as described in (RFC 4346/TLSv1.1+) if a connection was
> close
On Fri, 1 Apr 2022 07:32:21 GMT, Andrey Turbanov wrote:
> Let's take advantage of Java 7 language feature - "Catching Multiple
> Exception Types".
> It simplifies code. Reduces duplication.
> Found by IntelliJ IDEA inspection `Identical 'catch' branches in 'try'
> statement`
Looks fine!
-
On Tue, 12 Apr 2022 11:28:12 GMT, Daniel Jeliński wrote:
> During TLS handshake, hundreds of constraints are evaluated to determine
> which cipher suites are usable. Most of the evaluations are performed using
> `HandshakeContext#algorithmConstraints` object. By default that object
> contains
On Thu, 21 Apr 2022 19:58:39 GMT, Daniel Jeliński wrote:
> Profiling the TLS handshakes using SSLHandshake benchmark shows that a large
> portion of time is spent in HandshakeContext initialization, specifically in
> DisabledAlgorithmConstraints class.
>
> There are only a few instances of tha
On Mon, 9 May 2022 19:38:36 GMT, Daniel Jeliński wrote:
> When a TLS server resumes a session from a stateless session ticket, it
> populates the `SSLSessionImpl`'s `localCerts` and `peerCerts` fields with
> certificates deserialized from the session ticket. These certificates are
> often the
On Fri, 27 May 2022 13:20:24 GMT, Daniel Jeliński wrote:
> Session ticket extension should only contain pre-TLS1.3 stateless session
> tickets; it should not be used for sending TLS1.3 pre-shared keys.
src/java.base/share/classes/sun/security/ssl/SessionTicketExtension.java line
410:
> 408:
On Thu, 2 Jun 2022 21:02:16 GMT, Daniel Jeliński wrote:
>> Session ticket extension should only contain pre-TLS1.3 stateless session
>> tickets; it should not be used for sending TLS1.3 pre-shared keys.
>
> Daniel Jeliński has updated the pull request incrementally with one
> additional commit
removing the "closing inbound before receiving peer's close_notify" exception
that can be seen with TLS stack if calling close on inbound. After reading the
relevant parts of the TLS v1.2/v1.3 RFCs, I believe the local end point doesn't
have to wait for close_notify alert from remote end.
-
On Thu, 12 Nov 2020 06:44:27 GMT, Matthias Baesken wrote:
>> Marked as reviewed by mbaesken (Reviewer).
>
> Looks good to me !
Meant to comment earlier. Thanks for cleaning this one up!
-
PR: https://git.openjdk.java.net/jdk/pull/1166
On Fri, 13 Nov 2020 21:18:30 GMT, Weijun Wang wrote:
>> Without this method, `PSSParameterSpec::toString` shows something like:
>> MD: SHA-256
>> MGF: java.security.spec.MGF1ParameterSpec@77b52d12
>> SaltLength: 32
>> TrailerField: 1
>> This is ugly.
>>
>> Noreg-trivial.
>
> Do you want me to co
On Mon, 16 Nov 2020 14:25:20 GMT, Weijun Wang wrote:
>> Without this method, `PSSParameterSpec::toString` shows something like:
>> MD: SHA-256
>> MGF: java.security.spec.MGF1ParameterSpec@77b52d12
>> SaltLength: 32
>> TrailerField: 1
>> This is ugly.
>>
>> Noreg-trivial.
>
> Weijun Wang has upda
On Tue, 17 Nov 2020 17:55:19 GMT, Sean Mullan wrote:
>> This change disables the TLSv1 and TLSv1.1 protocols by adding them to the
>> jdk.tls.disabledAlgorithms security property in the java.security file.
>> These protocols use weak algorithms and are being deprecated by the IETF.
>> They sho
On Fri, 13 Nov 2020 14:16:35 GMT, Sean Coffey wrote:
> removing the "closing inbound before receiving peer's close_notify" exception
> that can be seen with TLS stack if calling close on inbound. After reading
> the relevant parts of the TLS v1.2/v1.3 RFCs, I bel
r close_notify alert from remote end.
Sean Coffey has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains three additional commits since
the last revision:
- ve
On Fri, 13 Nov 2020 14:16:35 GMT, Sean Coffey wrote:
> removing the "closing inbound before receiving peer's close_notify" exception
> that can be seen with TLS stack if calling close on inbound. After reading
> the relevant parts of the TLS v1.2/v1.3 RFCs, I bel
On Mon, 11 Jan 2021 04:57:19 GMT, Xue-Lei Andrew Fan wrote:
> The SSLSocketImpl and SSLEngineImpl implementation does not override the
> toString() method. The old code did. BTW, I also made a few code clean up
> in the SSLSocketImpl.java.
>
> Code clean up, trivial update, no new regression
Correction of NPE and updating of test cases. Minor refactoring of test library
also.
-
Commit messages:
- 8255348: NPE in PKIXCertPathValidator event logging code
Changes: https://git.openjdk.java.net/jdk/pull/2150/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2150&
> Correction of NPE and updating of test cases. Minor refactoring of test
> library also.
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
Sean Mullan review update
-
Changes:
- all: https://git.openjdk.java.n
On Tue, 19 Jan 2021 17:54:33 GMT, Sean Coffey wrote:
> Correction of NPE and updating of test cases. Minor refactoring of test
> library also.
This pull request has now been integrated.
Changeset: 18eb6d9e
Author: Sean Coffey
URL: https://git.openjdk.java.net/jdk/commit/18
On Mon, 1 Feb 2021 23:06:30 GMT, Hai-May Chao wrote:
> This change is made for compliance with RFC 5280 section 4.2.1.1 for
> Authority Key Identifier extension.
Marked as reviewed by coffeys (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2343
On Tue, 9 Feb 2021 12:35:27 GMT, Chris Hegarty wrote:
> This issue adds a new event to improve diagnostic information of Java
> deserialization. The event captures the details of deserialization activity
> from ObjectInputStream. The event details are similar to that of the serial
> filter, bu
On Thu, 11 Feb 2021 15:28:07 GMT, Chris Hegarty wrote:
>> This issue adds a new event to improve diagnostic information of Java
>> deserialization. The event captures the details of deserialization activity
>> from ObjectInputStream. The event details are similar to that of the serial
>> filte
On Fri, 12 Feb 2021 16:26:09 GMT, Chris Hegarty wrote:
>> This issue adds a new event to improve diagnostic information of Java
>> deserialization. The event captures the details of deserialization activity
>> from ObjectInputStream. The event details are similar to that of the serial
>> filte
On Fri, 9 Apr 2021 11:15:40 GMT, Abdul Kolarkunnu
wrote:
>> There is a lack of tests in the area of java.net.Socket.shutdownInput() and
>> java.net.Socket.shutdownOutput() , so added more tests in this area of with
>> different TLS versions. Please review.
>
> Abdul Kolarkunnu has updated the
On Tue, 2 Mar 2021 10:31:03 GMT, Abdul Kolarkunnu
wrote:
>> There is a lack of tests in the area of java.net.Socket.shutdownInput() and
>> java.net.Socket.shutdownOutput() , so added more tests in this area of with
>> different TLS versions. Please review.
>
> @coffeys
Thanks for increasing
Added capability to allow the PKCS11 Token to be destroyed once a session is
logged out from. New configuration properties via pkcs11 config file. Cleaned
up the native resource poller also.
New unit test case to test behaviour. Some PKCS11 tests refactored to allow
pkcs11 provider to be config
Trivial enough change. Improved the exception thrown from JceKeyStore also.
-
Commit messages:
- Fix white space
- 8236671: NullPointerException in JKS keystore
Changes: https://git.openjdk.java.net/jdk/pull/3588/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3588&ran
On Tue, 20 Apr 2021 17:00:40 GMT, Xue-Lei Andrew Fan wrote:
> It looks like a public behavior change to me. Did you want to file a CSR and
> update the specification (KeyStore) as well? I think it would be nice if we
> could keep use the old exception, IllegalArgumentException, as described in
On Mon, 26 Apr 2021 17:29:26 GMT, Sean Mullan wrote:
> This change will restrict JARs signed with SHA-1 algorithms and treat them as
> if they were unsigned. This applies to the algorithms used to digest, sign,
> and optionally timestamp the JAR. It also applies to the signature and digest
> a
> Trivial enough change. Improved the exception thrown from JceKeyStore also.
Sean Coffey has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains f
On Thu, 29 Apr 2021 17:51:17 GMT, Weijun Wang wrote:
>> It's awkward that for a password-less pkcs12 keystore, `keytool -list` does
>> not prompt for a password but `keytool -list -storetype pkcs12` does.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit si
On Wed, 28 Apr 2021 12:39:42 GMT, Sean Coffey wrote:
>> Trivial enough change. Improved the exception thrown from JceKeyStore also.
>
> Sean Coffey has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated cha
On Tue, 20 Apr 2021 11:54:39 GMT, Sean Coffey wrote:
> Trivial enough change. Improved the exception thrown from JceKeyStore also.
This pull request has now been integrated.
Changeset: 276a1bf7
Author: Sean Coffey
URL:
https://git.openjdk.java.net/jdk/com
1 - 100 of 137 matches
Mail list logo