Re: RFR: 8289275: Remove incorrect __declspec(dllimport) attributes from pointers in jdk.crypto.cryptoki [v4]

2022-07-13 Thread Julian Waters
> Several instances of function pointers in jdk.crypto.cryptoki are marked with > the dllimport attribute, which should only be applied to symbol declarations, > of which a typedef'd function pointer is not. This would only be useful if a > function pointer defined in the linked dll is desired t

Re: RFR: 8289275: Remove incorrect __declspec(dllimport) attributes from pointers in jdk.crypto.cryptoki [v3]

2022-07-13 Thread Julian Waters
> Several instances of function pointers in jdk.crypto.cryptoki are marked with > the dllimport attribute, which should only be applied to symbol declarations, > of which a typedef'd function pointer is not. This would only be useful if a > function pointer defined in the linked dll is desired t

Re: RFR: 8289275: Remove incorrect __declspec(dllimport) attributes from pointers in jdk.crypto.cryptoki

2022-07-13 Thread Julian Waters
On Wed, 13 Jul 2022 16:40:48 GMT, Valerie Peng wrote: > > > pkcs11.h is a standard header file from OASIS. Best to leave it alone. > > > Just my .02. > > > > > > The only change to pkcs11.h is in a comment though, the other changes are > > outside the ANSI C headers from the standard. Should

Re: Case-sensitive Keystore for PKCS#12

2022-07-13 Thread Xuelei Fan
> On Jul 13, 2022, at 2:20 PM, Michael StJohns wrote: > > On 7/13/2022 3:26 PM, Xuelei Fan wrote: >> Is it possible make it in the application layer? For example, mapping >> case-sensitive name to case-in-sensitive name before calling into the >> standard KeyStore APIs. It may be not good

Re: Case-sensitive Keystore for PKCS#12

2022-07-13 Thread Michael StJohns
On 7/13/2022 3:26 PM, Xuelei Fan wrote: Is it possible make it in the application layer? For example, mapping case-sensitive name to case-in-sensitive name before calling into the standard KeyStore APIs. It may be not good to break the standards for corner cases? Xuelei Hi Xuelei - It wou

Re: Case-sensitive Keystore for PKCS#12

2022-07-13 Thread Xuelei Fan
Is it possible make it in the application layer? For example, mapping case-sensitive name to case-in-sensitive name before calling into the standard KeyStore APIs. It may be not good to break the standards for corner cases? Xuelei > On Jul 13, 2022, at 4:38 AM, Ravi Patel8 wrote: > > We hav

Re: Case-sensitive Keystore for PKCS#12

2022-07-13 Thread Michael StJohns
On 7/13/2022 7:38 AM, Ravi Patel8 wrote: We have a customer who is having a security requirement. He wants to know, Is it possible to have case-sensitive support for PKCS#12? We referred the RFCs for PKCS#12. We found that PKCS#12 uses a case in-sensitive alias and the alias Name is mapped with

Re: RFR: 8289908: Skip bounds check for cases when String is constructed from entirely used byte[] [v4]

2022-07-13 Thread Сергей Цыпанов
On Wed, 13 Jul 2022 15:44:04 GMT, Roger Riggs wrote: >> Сергей Цыпанов has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >> commits

Re: RFR: 8289908: Skip bounds check for cases when String is constructed from entirely used byte[] [v5]

2022-07-13 Thread Сергей Цыпанов
> We can skip bounds check and null check for Charset in case we use the array > entirely and the Charset is either default one or proven to be non-null. > > Benchmark results: > > before > > Benchmark Mode Cnt Score > Error Units > StringC

Re: RFR: 8289275: Remove incorrect __declspec(dllimport) attributes from pointers in jdk.crypto.cryptoki

2022-07-13 Thread Valerie Peng
On Sat, 9 Jul 2022 06:05:09 GMT, Julian Waters wrote: > > pkcs11.h is a standard header file from OASIS. Best to leave it alone. Just > > my .02. > > The only change to pkcs11.h is in a comment though, the other changes are > outside the ANSI C headers from the standard. Should I just revert t

Re: RFR: 8289908: Skip bounds check for cases when String is constructed from entirely used byte[] [v4]

2022-07-13 Thread Roger Riggs
On Wed, 13 Jul 2022 15:11:25 GMT, Сергей Цыпанов wrote: >> We can skip bounds check and null check for Charset in case we use the array >> entirely and the Charset is either default one or proven to be non-null. >> >> Benchmark results: >> >> before >> >> Benchmark

Re: RFR: 8289908: Skip bounds check for cases when String is constructed from entirely used byte[] [v4]

2022-07-13 Thread Сергей Цыпанов
> We can skip bounds check and null check for Charset in case we use the array > entirely and the Charset is either default one or proven to be non-null. > > Benchmark results: > > before > > Benchmark Mode Cnt Score > Error Units > StringC

Re: RFR: 8289908: Skip bounds check for cases when String is constructed from entirely used byte[] [v4]

2022-07-13 Thread Сергей Цыпанов
On Tue, 12 Jul 2022 15:57:12 GMT, Roger Riggs wrote: >> Benchmark results after: >> >> Benchmark Mode Cnt Score >> Error Units >> StringConstructor.newStringFromArray avgt 50 4,354 >> ± 0,195 ns/op >> StringConstru

Case-sensitive Keystore for PKCS#12

2022-07-13 Thread Ravi Patel8
We have a customer who is having a security requirement. He wants to know, Is it possible to have case-sensitive support for PKCS#12? We referred the RFCs for PKCS#12. We found that PKCS#12 uses a case in-sensitive alias and the alias Name is mapped with friendlyName attribute, which is specifie