Re: RFR: 8291511: Redefinition of EXIT_FAILURE in libw2k_lsa_auth [v2]

2022-08-07 Thread Julian Waters
On Sun, 7 Aug 2022 08:51:50 GMT, Julian Waters wrote: >> EXIT_FAILURE is defined as -1 in NativeCreds.c, and is not only unused, but >> also incorrect, as it incorrectly redefines the existing EXIT_FAILURE, which >> is actually 1 on Windows, not -1. Can be safely commented out as it isn't >> u

Re: RFR: 8291511: Redefinition of EXIT_FAILURE in libw2k_lsa_auth [v3]

2022-08-07 Thread Julian Waters
> EXIT_FAILURE is defined as -1 in NativeCreds.c, and is not only unused, but > also incorrect, as it incorrectly redefines the existing EXIT_FAILURE, which > is actually 1 on Windows, not -1. Can be safely commented out as it isn't > used anywhere, except for in a call to ExitProcess which has

Integrated: 8291957: Redundant import statements in sun.security.ec

2022-08-07 Thread raspberry-hu
On Sat, 6 Aug 2022 15:12:44 GMT, raspberry-hu wrote: > remove unused imports This pull request has now been integrated. Changeset: 8e2c006c Author:raspberry-hu <76903172+raspberry...@users.noreply.github.com> Committer: John Jiang URL: https://git.openjdk.org/jdk/commit/8e2c006cd149

Re: [jdk19] RFR: 8278274: Update nroff pages in JDK 19 before RC

2022-08-07 Thread David Holmes
Hi Patrick, On 6/08/2022 7:05 pm, Patrick Pfeifer wrote: On Mon, 18 Jul 2022 15:22:01 GMT, Jonathan Gibbons wrote: Please review these changes to the nroff manpage files so that they match their markdown sources that Oracle maintains. Not a problem with this PR as such, but we still have a

PKCS8 with PBES2 protection supported by EncryptedPrivateKeyInfo?

2022-08-07 Thread Bernd
Hello, there is a longstanding issue in the PostgreSQL JDBC driver which reads secret keys in PKCS#8 format, but does not support the newer PKCS#5 2.0 (PBES2) modes (-v1 works). The (naive) code is here: pgjdbc/LazyKeyManager.java at 80d4ed34c99d51dd8b06df00baad0265fd620fec · pgjdbc/pgjdbc · GitH

Re: RFR: JDK-8290975 Minor cleanup could be done in javax.security [v4]

2022-08-07 Thread Sean Mullan
On Fri, 5 Aug 2022 21:49:01 GMT, Mark Powers wrote: >> https://bugs.openjdk.org/browse/JDK-8290975 > > Mark Powers has updated the pull request incrementally with one additional > commit since the last revision: > > comment applies to two files Marked as reviewed by mullan (Reviewer). -

Re: RFR: 8291511: Redefinition of EXIT_FAILURE in libw2k_lsa_auth [v2]

2022-08-07 Thread Julian Waters
> EXIT_FAILURE is defined as -1 in NativeCreds.c, and is not only unused, but > also incorrect, as it incorrectly redefines the existing EXIT_FAILURE, which > is actually 1 on Windows, not -1. Can be safely commented out as it isn't > used anywhere, except for in a call to ExitProcess which has