Hi,
Please review this simple fix for readability.
In the AES cipher implementation, the AESCipher class is defined as abstract.
As is not necessary as there is no abstract method in this class. Code reader
may try to search for abstract methods if the abstract keyword is present.
BTW, I also
On Fri, 9 Sep 2022 14:43:50 GMT, Mark Powers wrote:
> What happens when deserialization encounters a missing field like `testing`?
> Does it ignore it?
Have we tried this to know for sure that it is ignored? I think you should
verify this by serializing w/o this "testing" field and de-serializ
On Wed, 7 Sep 2022 19:49:53 GMT, Mark Powers wrote:
> https://bugs.openjdk.org/browse/JDK-8291974
I've added my name as a reviewer of the CSR.
As for the test, I think it makes sense to serialize the object in an old JDK,
hardcode the bytes in a new test and try to deserialize it, and make sur
On Mon, 22 Aug 2022 21:45:39 GMT, Mark Powers wrote:
> https://bugs.openjdk.org/browse/JDK-8291509
This pull request has now been integrated.
Changeset: 4cec141a
Author:Mark Powers
Committer: Weijun Wang
URL:
https://git.openjdk.org/jdk/commit/4cec141a90bc5d3b8ec17c024291d9c74a112c
On Tue, 13 Sep 2022 19:31:27 GMT, Sean Mullan wrote:
>> https://bugs.openjdk.org/browse/JDK-8291974
>
> I would write a test which serializes the data (before your change) and
> deserializes it after. There should be some regression tests that already do
> that.
@seanjmullan There is an existi
On Wed, 14 Sep 2022 23:15:29 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8291509
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> final comments from Max
Thanks Sean and Max for being tenacious reviewing t
On Wed, 14 Sep 2022 05:58:10 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> Please review this simple code cleanup.
>
> The following checking for key in the makeSessionKey() method is redundant as
> it the same checking has been performance before calling the method.
>
>
> if (k == null)
On Thu, 15 Sep 2022 12:58:57 GMT, Weijun Wang wrote:
> This is not a fix for the bug itself, therefore I suggest either create a new
> issue or create a subtask for this code change.
Hi, this one is just for the better/more detailed exception . For the real
issue we still have JDK-8293097 .
On Thu, 15 Sep 2022 08:11:38 GMT, Matthias Baesken wrote:
> Currently we see on various Windows machines the following exception :
> https://bugs.openjdk.org/browse/JDK-8293097
>
> java.security.KeyStoreException: Access is denied.
>
> This should probably be enhanced a bit so that the exceptio
Currently we see on various Windows machines the following exception :
https://bugs.openjdk.org/browse/JDK-8293097
java.security.KeyStoreException: Access is denied.
This should probably be enhanced a bit so that the exception tell us more about
what went wrong exactly.
-
Commit me
10 matches
Mail list logo
