RFR: 8305761: Resolve multiple definition of 'jvm' when statically linking with JDK native libraries

2023-04-07 Thread Jiangli Zhou
… with JDK native libraries - Commit messages: - 8305761: Resolve multiple definition of 'jvm' when statically linking with JDK native libraries Changes: https://git.openjdk.org/jdk/pull/13397/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13397&range=00 Issue: https://b

Withdrawn: 8305761: Resolve multiple definition of 'jvm' when statically linking with JDK native libraries

2023-04-07 Thread Jiangli Zhou
On Fri, 7 Apr 2023 23:32:46 GMT, Jiangli Zhou wrote: > Rename various 'jvm' variables to 'jvm_' to avoid duplicate symbol > problems when statically linking the launcher executable with JDK native > libraries. > > 8305761: Resolve multiple definition of 'jvm' when statically linking with > JD

RFR: 8305761: Resolve multiple definition of 'jvm' when statically linking with JDK native libraries

2023-04-07 Thread Jiangli Zhou
Rename various 'jvm' variables to 'jvm_' to avoid duplicate symbol problems when statically linking the launcher executable with JDK native libraries. 8305761: Resolve multiple definition of 'jvm' when statically linking with JDK native libraries - Commit messages: - Resolve link

Re: RFR: JDK-8302696 Revert API signature changes made in JDK-8285504 and JDK-8285263

2023-04-07 Thread Sean Mullan
On Fri, 7 Apr 2023 19:09:43 GMT, Mark Powers wrote: > https://bugs.openjdk.org/browse/JDK-8302696 Marked as reviewed by mullan (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/13391#pullrequestreview-1376528212

RFR: JDK-8302696 Revert API signature changes made in JDK-8285504 and JDK-8285263

2023-04-07 Thread Mark Powers
https://bugs.openjdk.org/browse/JDK-8302696 - Commit messages: - Merge - first iteration Changes: https://git.openjdk.org/jdk/pull/13391/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13391&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8302696 Stats: 3 lines in 3

Re: RFR: 8302819: Remove JAR Index [v6]

2023-04-07 Thread Eirik Bjorsnos
On Fri, 7 Apr 2023 16:29:31 GMT, Alan Bateman wrote: > I've updated the CSR to align it with the proposed solution. Please review > again and if you happy, press "Finalize". Thanks, Alan, this looks good to me. I have pressed "Finalize". The CSR makes promises about the Release Note. Do you th

Re: RFR: 8302819: Remove JAR Index [v6]

2023-04-07 Thread Alan Bateman
On Fri, 7 Apr 2023 07:47:49 GMT, Eirik Bjorsnos wrote: >> This PR removes the JAR index feature from the runtime: >> >> - `URLClassPath` is updated to remove the `enableJarIndex` system property >> and any code which would be called when this property was `true` >> - The `JarIndex` implementat

Re: RFR: 8305310: Calculate PublicKey from PrivateKey [v2]

2023-04-07 Thread Sean Mullan
On Fri, 31 Mar 2023 12:48:21 GMT, Weijun Wang wrote: >> This code change is for DHKEM, which requires the function >> >> pk(skX): The KEM public key corresponding to the KEM private key skX. >> >> Only implemented for EC and XDH. Might add PKCS #11 support later. > > Weijun Wang has updated the

Re: RFR: 8304911: Use OperatingSystem enum in some modules [v4]

2023-04-07 Thread Roger Riggs
> With the addition of `jdk.internal.util.OperatingSystem` references to the > system property `os.name` can be replaced. > This PR exports jdk.internal.util to: > - java.prefs, > - java.security.jgss, > - java.smartcardio, > - jdk.charsets, > - jdk.net, > - jdk.zipfs Roger Riggs has update

Re: RFR: 8182621: JSSE should reject empty TLS plaintexts [v2]

2023-04-07 Thread Matthew Donovan
> Added code similar to the suggested patches for empty Handshake messages. I > also implemented tests to verify empty Handshake, Alert, and ChangeCipherSpec > messages result in expected behavior: for SSLEngineImpl, exceptions are > thrown, for SSLSockets the connection is closed. Matthew Dono

Re: RFR: 8182621: JSSE should reject empty TLS plaintexts [v2]

2023-04-07 Thread Matthew Donovan
On Fri, 7 Apr 2023 02:14:59 GMT, Xue-Lei Andrew Fan wrote: >> Matthew Donovan has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - added comment referring to relevant RFC >> - clarified if-statements; fixed exception message wording > > sr

Re: RFR: 8304911: Use OperatingSystem enum in some modules [v3]

2023-04-07 Thread Andrey Turbanov
On Wed, 5 Apr 2023 15:48:02 GMT, Roger Riggs wrote: >> With the addition of `jdk.internal.util.OperatingSystem` references to the >> system property `os.name` can be replaced. >> This PR exports jdk.internal.util to: >> - java.prefs, >> - java.security.jgss, >> - java.smartcardio, >> - jdk.c

Re: RFR: 8302819: Remove JAR Index [v5]

2023-04-07 Thread Eirik Bjorsnos
On Thu, 6 Apr 2023 07:32:12 GMT, Alan Bateman wrote: > One additional thing we could do is update the usage output for > -i/--generate-index to say that the option is deprecated. Looking at `jdeps > -help` output to see this for the deprecated -P/--profile option. Implemented as suggested. The

Re: RFR: 8302819: Remove JAR Index [v6]

2023-04-07 Thread Eirik Bjorsnos
> This PR removes the JAR index feature from the runtime: > > - `URLClassPath` is updated to remove the `enableJarIndex` system property > and any code which would be called when this property was `true` > - The `JarIndex` implementation class is moved into `jdk.jartool` module. > - The `Invalid