Re: RFR: 8305972: Update XML Security for Java to 3.0.2 [v7]

2023-05-15 Thread Weijun Wang
> Update XML Security for Java to 3.0.2. Some change to tests: > > 1. No more Xalan. One test case is singled out to demonstrate how to use a > special configuration. > 2. EdDSA does not support `KeyValue`. Use X.509 certificate instead. Weijun Wang has updated the pull request incrementally

Re: RFR: 8308118: Avoid multiarray allocations in AESCrypt.makeSessionKey

2023-05-15 Thread David Schlosnagle
On Mon, 15 May 2023 19:59:13 GMT, Aleksey Shipilev wrote: > One of our services has a hot path with AES/GCM cipher reuse. The JDK code > reinitializes the session key on that path, and > [JDK-8308105](https://bugs.openjdk.org/browse/JDK-8308105) shows up > prominently there. While >

Re: RFR: 8305972: Update XML Security for Java to 3.0.2 [v6]

2023-05-15 Thread Weijun Wang
> Update XML Security for Java to 3.0.2. Some change to tests: > > 1. No more Xalan. One test case is singled out to demonstrate how to use a > special configuration. > 2. EdDSA does not support `KeyValue`. Use X.509 certificate instead. Weijun Wang has updated the pull request with a new

Re: RFR: 8308118: Avoid multiarray allocations in AESCrypt.makeSessionKey

2023-05-15 Thread Xue-Lei Andrew Fan
On Mon, 15 May 2023 19:59:13 GMT, Aleksey Shipilev wrote: > One of our services has a hot path with AES/GCM cipher reuse. The JDK code > reinitializes the session key on that path, and > [JDK-8308105](https://bugs.openjdk.org/browse/JDK-8308105) shows up > prominently there. While >

Re: RFR: 8308016: Use snippets in java.io package [v4]

2023-05-15 Thread Brian Burkhalter
> Replace `{@code ...}` patterns and the like with `{@snippet > lang=java : ...}`. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 8308016: Fix link in snippet of File::toPath - Changes: - all:

RFR: 8308118: Avoid multiarray allocations in AESCrypt.makeSessionKey

2023-05-15 Thread Aleksey Shipilev
One of our services has a hot path with AES/GCM cipher reuse. The JDK code reinitializes the session key on that path, and [JDK-8308105](https://bugs.openjdk.org/browse/JDK-8308105) shows up prominently there. While [JDK-8308105](https://bugs.openjdk.org/browse/JDK-8308105) is being fixed,

Re: RFR: 8294985: SSLEngine throws IAE during parsing of X500Principal [v6]

2023-05-15 Thread Kevin Driver
On Mon, 15 May 2023 19:37:44 GMT, Sean Mullan wrote: >> It is not easy to understand the final behavior if throwing SSLException >> here. I would like to call `TransportContext.fatal()` directly to make the >> behavior more accuracy, by using Alert.DECODE_ERROR. > > You will need to pass in

Re: RFR: 8294985: SSLEngine throws IAE during parsing of X500Principal [v6]

2023-05-15 Thread Sean Mullan
On Mon, 15 May 2023 19:17:18 GMT, Xue-Lei Andrew Fan wrote: >> Yes, let's wait for @XueleiFan > > It is not easy to understand the final behavior if throwing SSLException > here. I would like to call `TransportContext.fatal()` directly to make the > behavior more accuracy, by using

Re: RFR: 8294985: SSLEngine throws IAE during parsing of X500Principal [v6]

2023-05-15 Thread Xue-Lei Andrew Fan
On Fri, 12 May 2023 20:30:04 GMT, Kevin Driver wrote: >> src/java.base/share/classes/sun/security/ssl/CertificateAuthoritiesExtension.java >> line 136: >> >>> 134: } catch (IllegalArgumentException iae) { >>> 135: throw new SSLException("X500Principal could not be

Re: RFR: 8297878: KEM: Implementation [v15]

2023-05-15 Thread Anthony Scarpino
On Thu, 11 May 2023 20:56:54 GMT, Weijun Wang wrote: >> The KEM API and DHKEM impl. Note that this PR uses new methods in >> https://github.com/openjdk/jdk/pull/13250. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > >

Re: RFR: 8308016: Use snippets in java.io package [v3]

2023-05-15 Thread Brian Burkhalter
> Replace `{@code ...}` patterns and the like with `{@snippet > lang=java : ...}`. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 8308016: Address reviewer comments since previous commit - Changes: - all:

Re: RFR: 8298127: HSS/LMS Signature Verification [v14]

2023-05-15 Thread Ferenc Rakoczi
> Implement support for Leighton-Micali Signatures (LMS) as described in RFC > 8554. LMS is an approved software signing algorithm for CNSA 2.0, with > SHA-256/192 parameters recommended. Ferenc Rakoczi has updated the pull request incrementally with one additional commit since the last

Re: RFR: 8298127: HSS/LMS Signature Verification [v13]

2023-05-15 Thread Weijun Wang
On Mon, 15 May 2023 13:44:27 GMT, Ferenc Rakoczi wrote: >> Implement support for Leighton-Micali Signatures (LMS) as described in RFC >> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with >> SHA-256/192 parameters recommended. > > Ferenc Rakoczi has updated the pull request

Re: RFR: 8298127: HSS/LMS Signature Verification [v13]

2023-05-15 Thread Weijun Wang
On Mon, 15 May 2023 13:44:27 GMT, Ferenc Rakoczi wrote: >> Implement support for Leighton-Micali Signatures (LMS) as described in RFC >> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with >> SHA-256/192 parameters recommended. > > Ferenc Rakoczi has updated the pull request

Re: RFR: 8298127: HSS/LMS Signature Verification [v11]

2023-05-15 Thread Weijun Wang
On Mon, 15 May 2023 09:30:04 GMT, Ferenc Rakoczi wrote: >> src/java.base/share/classes/sun/security/provider/SHA2.java line 51: >> >>> 49: >>> 50: private static final int ITERATION = 64; >>> 51: private static final int BLOCKSIZE = 64; >> >> I'm not sure if it's worth defining this.

Re: RFR: 8298127: HSS/LMS Signature Verification [v13]

2023-05-15 Thread Weijun Wang
On Mon, 15 May 2023 13:44:27 GMT, Ferenc Rakoczi wrote: >> Implement support for Leighton-Micali Signatures (LMS) as described in RFC >> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with >> SHA-256/192 parameters recommended. > > Ferenc Rakoczi has updated the pull request

Re: RFR: 8298127: HSS/LMS Signature Verification [v13]

2023-05-15 Thread Ferenc Rakoczi
> Implement support for Leighton-Micali Signatures (LMS) as described in RFC > 8554. LMS is an approved software signing algorithm for CNSA 2.0, with > SHA-256/192 parameters recommended. Ferenc Rakoczi has updated the pull request incrementally with one additional commit since the last

Re: RFR: 8307326: Package jdk.internal.classfile.java.lang.constant become obsolete

2023-05-15 Thread Erik Joelsson
On Mon, 15 May 2023 08:38:54 GMT, Adam Sotona wrote: > Package `jdk.internal.classfile.java.lang.constant` containing `ModuleDesc` > and `PackageDesc` become obsolete after > [JDK-8306729](https://bugs.openjdk.org/browse/JDK-8306729). > All references to

Re: RFR: 8298127: HSS/LMS Signature Verification [v12]

2023-05-15 Thread Weijun Wang
On Mon, 15 May 2023 09:45:10 GMT, Ferenc Rakoczi wrote: >> Implement support for Leighton-Micali Signatures (LMS) as described in RFC >> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with >> SHA-256/192 parameters recommended. > > Ferenc Rakoczi has updated the pull request

Re: RFR: 8298127: HSS/LMS Signature Verification [v12]

2023-05-15 Thread Ferenc Rakoczi
> Implement support for Leighton-Micali Signatures (LMS) as described in RFC > 8554. LMS is an approved software signing algorithm for CNSA 2.0, with > SHA-256/192 parameters recommended. Ferenc Rakoczi has updated the pull request incrementally with one additional commit since the last

Re: RFR: 8298127: HSS/LMS Signature Verification [v11]

2023-05-15 Thread Ferenc Rakoczi
On Fri, 12 May 2023 22:11:07 GMT, Weijun Wang wrote: >> Ferenc Rakoczi has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Removed Length from HSSPublicKey, changed the handling of X509 encoded >> keys in the factory, did some more

RFR: 8307326: Package jdk.internal.classfile.java.lang.constant become obsolete

2023-05-15 Thread Adam Sotona
Package `jdk.internal.classfile.java.lang.constant` containing `ModuleDesc` and `PackageDesc` become obsolete after [JDK-8306729](https://bugs.openjdk.org/browse/JDK-8306729). All references to `jdk.internal.classfile.java.lang.constant.ModuleDesc` and