Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v5]

2023-05-26 Thread Martin Balao
On Tue, 23 May 2023 19:29:47 GMT, Martin Balao wrote: >> We would like to propose an implementation for the [JDK-8301553: Support >> Password-Based Cryptography in >> SunPKCS11](https://bugs.openjdk.org/browse/JDK-8301553) enhancement >> requirement. >> >> In addition to pursuing the requirem

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v6]

2023-05-26 Thread Martin Balao
> We would like to propose an implementation for the [JDK-8301553: Support > Password-Based Cryptography in > SunPKCS11](https://bugs.openjdk.org/browse/JDK-8301553) enhancement > requirement. > > In addition to pursuing the requirement goals and guidelines of > [JDK-8301553](https://bugs.open

Re: RFR: 8297885: misc sun/security/pkcs11 tests timed out

2023-05-26 Thread Xue-Lei Andrew Fan
On Sat, 27 May 2023 01:49:22 GMT, Valerie Peng wrote: > Increase the timeout value of the "LargeDSAKey,java" test to address the > intermittent test failure(s). As for the other mentioned test failures, the > execution time fluctuates even less, so leaving them alone for now. > > Thanks in adv

RFR: 8297885: misc sun/security/pkcs11 tests timed out

2023-05-26 Thread Valerie Peng
Increase the timeout value of the "LargeDSAKey,java" test to address the intermittent test failure(s). As for the other mentioned test failures, the execution time fluctuates even less, so leaving them alone for now. Thanks in advance for the review~ - Commit messages: - 8297885:

Re: RFR: 8294985: SSLEngine throws IAE during parsing of X500Principal [v21]

2023-05-26 Thread Bradford Wetmore
On Fri, 26 May 2023 21:39:29 GMT, Kevin Driver wrote: >> Fixes: [JDK-8294985](https://bugs.openjdk.org/browse/JDK-8294985) > > Kevin Driver has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the

Re: RFR: JDK-8307794 Test for HSS/LMS Signature Verification [v6]

2023-05-26 Thread Mark Powers
> https://bugs.openjdk.org/browse/JDK-8307794 Mark Powers has updated the pull request incrementally with one additional commit since the last revision: Sean's additional comments - Changes: - all: https://git.openjdk.org/jdk/pull/13940/files - new: https://git.openjdk.org/jd

Re: RFR: JDK-8307794 Test for HSS/LMS Signature Verification [v5]

2023-05-26 Thread Mark Powers
On Tue, 23 May 2023 19:07:45 GMT, Sean Mullan wrote: >> Mark Powers has updated the pull request incrementally with one additional >> commit since the last revision: >> >> change class names and fix nit > > test/jdk/sun/security/provider/hss/TestHSSLMS.java line 26: > >> 24: /* >> 25: * @te

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v5]

2023-05-26 Thread Martin Balao
On Fri, 26 May 2023 22:17:01 GMT, Martin Balao wrote: >> Good point. As I see it, the problem is not in the random source itself but >> in the values. There are a couple of P11PBECipher::engineInit paths in which >> P11PBECipher initialization succeeds but the pbes2Params does not have the >>

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v5]

2023-05-26 Thread Martin Balao
On Thu, 25 May 2023 23:26:06 GMT, Martin Balao wrote: >> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11PBECipher.java >> line 112: >> >>> 110: return pbes2Params.getAlgorithmParameters( >>> 111: blkSize, pbeAlg, P11Util.getSunJceProvider(), >>> 112:

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v5]

2023-05-26 Thread Martin Balao
On Thu, 25 May 2023 20:23:19 GMT, Valerie Peng wrote: >> Martin Balao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8301553: Support Password-Based Cryptography in SunPKCS11 (iteration #3) >> >> Co-authored-by: Francisco Ferrari

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v5]

2023-05-26 Thread Martin Balao
On Thu, 25 May 2023 23:44:44 GMT, Martin Balao wrote: >> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11PBECipher.java >> line 214: >> >>> 212: protected int engineGetKeySize(Key key) >>> 213: throws InvalidKeyException { >>> 214: return cipher.engineGetKey

Re: RFR: 8294985: SSLEngine throws IAE during parsing of X500Principal [v19]

2023-05-26 Thread Kevin Driver
On Tue, 23 May 2023 18:15:57 GMT, Xue-Lei Andrew Fan wrote: >> Kevin Driver has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 17 additional >> com

Re: RFR: 8294985: SSLEngine throws IAE during parsing of X500Principal [v21]

2023-05-26 Thread Kevin Driver
> Fixes: [JDK-8294985](https://bugs.openjdk.org/browse/JDK-8294985) Kevin Driver has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 23 additional commits s

Re: RFR: 8294985: SSLEngine throws IAE during parsing of X500Principal [v20]

2023-05-26 Thread Kevin Driver
> Fixes: [JDK-8294985](https://bugs.openjdk.org/browse/JDK-8294985) Kevin Driver has updated the pull request incrementally with four additional commits since the last revision: - working testcase for CertificateRequest for TLS1.2 - new version of second test - initial commit of second test

RFR: 8306688: Support Windows serialized keystores (SST files)

2023-05-26 Thread Mat Carter
Added ability to load keystores from SST files on Windows. Example usage: KeyStore keyStore = KeyStore.getInstance("Windows-SST"); try (FileInputStream fis = new FileInputStream("mykeystore.sst")) { keyStore.load(fis, null); } Note that its not limited to file streams, it can be any stream.

Re: RFR: JDK-8287061: Support for rematerializing scalar replaced objects participating in allocation merges [v13]

2023-05-26 Thread Cesar Soares Lucas
On Tue, 23 May 2023 17:19:23 GMT, Vladimir Ivanov wrote: >>> I verified that the new test cases do trigger SR+NSR scenario. >>> >>> How do you test that deoptimization works as expected? >>> >> >> I have a copy of the tests in AllocationMergesTests.java in a separate file >> (not included in

Re: RFR: 8296411: AArch64: Accelerated Poly1305 intrinsics [v4]

2023-05-26 Thread Andrew Haley
On Wed, 24 May 2023 19:16:36 GMT, Claes Redestad wrote: > Thanks for your patience in answering my questions and addressing my comments. Thank you for asking questions that made the patch better, and even removed an instruction in what I thought was a tightly-written intrinsic! -

Re: RFR: 8308144: HttpClient - uncontrolled memory consumption in SSLFlowDelegate.Reader

2023-05-26 Thread zhurs
On Thu, 25 May 2023 20:17:39 GMT, zhurs wrote: > When using HttpClient to make requests to HTTPS resources, there is an issue > where the entire file is being downloaded into memory without the ability to > limit the buffer size. > If the SSLEngine cannot decode the entire buffer due to the alg

Re: RFR: 8308144: HttpClient - uncontrolled memory consumption in SSLFlowDelegate.Reader

2023-05-26 Thread Daniel Fuchs
On Thu, 25 May 2023 20:17:39 GMT, zhurs wrote: > When using HttpClient to make requests to HTTPS resources, there is an issue > where the entire file is being downloaded into memory without the ability to > limit the buffer size. > If the SSLEngine cannot decode the entire buffer due to the alg

Re: RFR: 8308144: HttpClient - uncontrolled memory consumption in SSLFlowDelegate.Reader

2023-05-26 Thread Daniel Fuchs
On Thu, 25 May 2023 20:17:39 GMT, zhurs wrote: > When using HttpClient to make requests to HTTPS resources, there is an issue > where the entire file is being downloaded into memory without the ability to > limit the buffer size. > If the SSLEngine cannot decode the entire buffer due to the alg

Re: RFR: 8308144: HttpClient - uncontrolled memory consumption in SSLFlowDelegate.Reader

2023-05-26 Thread Daniel Fuchs
On Thu, 25 May 2023 20:17:39 GMT, zhurs wrote: > When using HttpClient to make requests to HTTPS resources, there is an issue > where the entire file is being downloaded into memory without the ability to > limit the buffer size. > If the SSLEngine cannot decode the entire buffer due to the alg

Re: RFR: JDK-8308872: enhance logging and some exception in krb5/Config.java [v2]

2023-05-26 Thread Matthias Baesken
> There exists already some logging in krb5/Config.java (enabled by > -Dsun.security.krb5.debug=true), this could be enhanced for easier analysis > of problems. Additionally some exception(s) might be slightly adjusted. Matthias Baesken has updated the pull request incrementally with one additio

Re: RFR: 8308286 Fix clang warnings in linux code

2023-05-26 Thread Daniel JeliƄski
On Wed, 17 May 2023 12:28:47 GMT, Artem Semenov wrote: > When using the clang compiler to build OpenJDk on Linux, we encounter various > "warnings as errors". > They can be fixed with small changes. According to our docs, [clang is a supported compiler for Linux](https://github.com/openjdk/jdk